This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC] Accomodate 64-bit msymbols in expressions
- To: Michael Snyder <msnyder at cygnus dot com>, gdb-patches at sources dot redhat dot com
- Subject: Re: [RFC] Accomodate 64-bit msymbols in expressions
- From: Kevin Buettner <kevinb at cygnus dot com>
- Date: Fri, 16 Feb 2001 17:30:55 -0700
- Cc: keiths at redhat dot com, kevinb at redhat dot com
- References: <3A8DBFEF.45B230C1@cygnus.com>
On Feb 16, 4:03pm, Michael Snyder wrote:
> The following change is motivated by the fact that the addresses of
> minimal symbols currently get truncated to 32 bits in expressions.
>
> Does this look badly wrong to anybody?
Not badly wrong. The only nit that I can pick is...
> ! /* Let's make the type big enough to hold a 64-bit address. */
> ! write_exp_elt_type (builtin_type_long_long);
...that it might be preferable to use builtin_type_CORE_ADDR instead.
(I.e, think about what happens if TARGET_LONG_LONG_BIT == 32, but
TARGET_ADDR_BIT == 64.)
Kevin