This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] File-name completion improvements



On Wed, 14 Feb 2001, Fernando Nasser wrote:

> Instead of changing this:
> rl_completer_word_break_characters =
>                          gdb_completer_file_name_break_characters;
> into this:
> char *fbc = gdb_completer_file_name_break_characters;
> rl_completer_word_break_characters = fbc;
> so you can use the shorthand here:
> p > tmp_command && strchr (fbc, p[-1]) == NULL;
> just use the full name:
> p > tmp_command && strchr (gdb_completer_file_name_break_characters, \
>                            p[-1]) == NULL;
> 
> I know, it is an awful long variable name.

The _real_ reason for that funky shorthand was not that it's long to
type ("M-/" in Emacs makes that problem go away ;-).  The real reason
was that, due to reindentation, the code either looks ugly or gets
past column 80.  If people don't mind that, there's no point in
introducing a new variable.

> After committing, please post the final version so it makes into the
> list archives.

Will do.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]