This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] File-name completion improvements
- To: Fernando Nasser <fnasser at cygnus dot com>
- Subject: Re: [RFA] File-name completion improvements
- From: Eli Zaretskii <eliz at is dot elta dot co dot il>
- Date: Thu, 15 Feb 2001 13:11:17 +0200 (IST)
- cc: gdb-patches at sources dot redhat dot com
On Wed, 14 Feb 2001, Fernando Nasser wrote:
> Instead of changing this:
> rl_completer_word_break_characters =
> gdb_completer_file_name_break_characters;
> into this:
> char *fbc = gdb_completer_file_name_break_characters;
> rl_completer_word_break_characters = fbc;
> so you can use the shorthand here:
> p > tmp_command && strchr (fbc, p[-1]) == NULL;
> just use the full name:
> p > tmp_command && strchr (gdb_completer_file_name_break_characters, \
> p[-1]) == NULL;
>
> I know, it is an awful long variable name.
The _real_ reason for that funky shorthand was not that it's long to
type ("M-/" in Emacs makes that problem go away ;-). The real reason
was that, due to reindentation, the code either looks ugly or gets
past column 80. If people don't mind that, there's no point in
introducing a new variable.
> After committing, please post the final version so it makes into the
> list archives.
Will do.