This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] to gdb: portability fix: <sys/file.h>
- To: Michael Sokolov <msokolov at ivan dot Harhan dot ORG>
- Subject: Re: [patch] to gdb: portability fix: <sys/file.h>
- From: Eli Zaretskii <eliz at is dot elta dot co dot il>
- Date: Thu, 8 Feb 2001 10:30:34 +0200 (IST)
- cc: gdb-patches at sources dot redhat dot com
On Wed, 7 Feb 2001, Michael Sokolov wrote:
> > In other words, Posix platforms should not be forced in yet another
> > Autoconf test if we can avoid that. IMHO, of course.
>
> I don't see how you are avoiding yet another Autoconf test. My patch adds the
> test for <sys/file.h> to configure.in so that I can check HAVE_SYS_FILE_H.
> However, what you are proposing in another message:
>
> > #if HAVE_UNISTD_H
> > #include <unistd.h>
> > #endif
> >
> > #ifndef F_OK
> > # if HAVE_SYS_FILE_H
> > /* 4.3BSD has F_OK in sys/file.h. */
> > # include <sys/file.h>
> > # endif
> > # ifndef F_OK
> > # define F_OK 0
> > # endif
> > #endif
>
> has to check HAVE_SYS_FILE_H too, so I don't see how it is different or how are
> you avoiding "forcing in yet another Autoconf test".
You could replace HAVE_SYS_FILE_H with something 4.3BSD defines, for
example.
Anyway, it was just a suggestion.