This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: patch: remove duplicated global variables
- To: Dean Luick <luick at cray dot com>, gdb-patches at sources dot redhat dot com
- Subject: Re: patch: remove duplicated global variables
- From: Kevin Buettner <kevinb at cygnus dot com>
- Date: Mon, 5 Feb 2001 16:19:07 -0700
- References: <20010205165838.A52444@zero.mw.cray.com>
FWIW, Dean's changes to defs.h and inferior.h look right to me.
On Feb 5, 4:58pm, Dean Luick wrote:
> Subject: patch: remove duplicated global variables
> Hi,
>
> Here is a fix for what looks like two code mistakes. I ran into them
> when not using gcc to compile gdb.
>
> Dean
>
>
> 2001-02-02 Dean Luick <luick@cray.com>
>
> Remove two cases of a variable being declared in a header that is
> included by multiple files.
> * defs.h: remove unused global variable "continuation".
> * inferior.h: replace global declaration of "step_over_calls" with
> an extern.
>
>
>
> Index: defs.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/defs.h,v
> retrieving revision 1.36
> diff -c -3 -p -r1.36 defs.h
> *** defs.h 2001/01/31 03:46:23 1.36
> --- defs.h 2001/02/05 22:08:24
> *************** struct continuation
> *** 673,679 ****
> struct continuation_arg *arg_list;
> struct continuation *next;
> };
> - struct continuation continuation;
>
> /* In infrun.c. */
> extern struct continuation *cmd_continuation;
> --- 673,678 ----
> Index: inferior.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/inferior.h,v
> retrieving revision 1.13
> diff -c -3 -p -r1.13 inferior.h
> *** inferior.h 2001/01/24 16:28:20 1.13
> --- inferior.h 2001/02/05 22:08:25
> *************** enum step_over_calls_kind
> *** 348,355 ****
> {
> STEP_OVER_NONE,
> STEP_OVER_ALL,
> ! STEP_OVER_UNDEBUGGABLE,
> ! } step_over_calls;
>
> /* If stepping, nonzero means step count is > 1
> so don't print frame next time inferior stops
> --- 348,356 ----
> {
> STEP_OVER_NONE,
> STEP_OVER_ALL,
> ! STEP_OVER_UNDEBUGGABLE
> ! };
> ! extern enum step_over_calls_kind step_over_calls;
>
> /* If stepping, nonzero means step count is > 1
> so don't print frame next time inferior stops
>-- End of excerpt from Dean Luick