Re: [RFA] fix child_xfer_memory in hppah-nat.c

[Christopher Faylor <cgf at redhat dot com>]

On Sat, Feb 03, 2001 at 10:19:21PM -0800, Michael Elizabeth Chastain wrote:
>This patch fixes hppah-nat.c:xfer_child_memory to declare the new
>'struct mem_attrib *' argument.
>
>This patch is needed to build sourceware gdb on hpux 10.20.
>
>Jeff Law is the maintainer of "hpux, hp pa native", but Jeff is on
>vacation right now.  So I appeal to one of the blanket write maintainers
>for approval.
>
>I tested this patch by building on an hpux 10.20 machine.
>
>This patch does not make hpux gdb actually work.  When I run a child
>process, gdb goes catatonic.  This is the same behavior that sourceware
>gdb had in the 2001-01-22 version (a day before the interface change to
>child_xfer_memory).  By using an older gdb to debug both the 2001-01-22
>gdb and today's gdb with my patch applied, I saw that neither of them
>got as far as child_xfer_memory.
>
>OK to commit?

You might want to add an ATTRIBUTE_UNUSED to 'struct mem_attrib *mem' to
stop a potential compiler warning.

cgf

>Michael Elizabeth Chastain
><chastain@redhat.com>
>"love without fear"
>
>===
>
>2001-02-03  Michael Chastain  <chastain@redhat.com>
>
>	* hppah-nat.c (xfer_child_memory): Add parameter 'struct mem_attrib *'
>	to conform with interface change.
>
>====
>
>Index: gdb/hppah-nat.c
>===================================================================
>RCS file: /cvs/src/src/gdb/hppah-nat.c,v
>retrieving revision 1.6
>diff -c -3 -p -r1.6 hppah-nat.c
>*** gdb/hppah-nat.c	2000/12/15 01:01:47	1.6
>--- gdb/hppah-nat.c	2001/02/03 20:32:50
>*************** fetch_register (int regno)
>*** 266,271 ****
>--- 266,272 ----
>  
>  int
>  child_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int write,
>+ 		   struct mem_attrib *mem,
>  		   struct target_ops *target)
>  {
>    register int i;

-- 
cgf@cygnus.com                        Red Hat, Inc.
http://sources.redhat.com/            http://www.redhat.com/