This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] xfree() replacements for free() in gdb
- To: "John R. Moore" <jmoore at dhcp-81 dot wirespeed dot com>
- Subject: Re: [RFA] xfree() replacements for free() in gdb
- From: Fernando Nasser <fnasser at redhat dot com>
- Date: Thu, 25 Jan 2001 19:06:20 -0500
- CC: gdb-patches at sources dot redhat dot com
- Organization: Red Hat Canada
- References: <200101260047.f0Q0ljE31390@dhcp-81.wirespeed.com>
The cli part is approved.
"John R. Moore" wrote:
>
> Resubmitting the xfree fixes for RFA
>
> 2001-01-25 John R. Moore <jmoore@cygnus.com>
>
> * cli/cli-cmds.c (apropos_command): Changed free() to xfree() where
> appropriate. Also changed Copyright to include 2001.
> * gdbarch.sh (gdbarch_free): Likewise.
> * remote-utils.h (sr_set_device): Likewise.
> * symtab.h (obstack_chunk_free, SYMBOL_INIT_DEMANGLED_NAME): Likewise.
> * value.h (value_free): Likewise.
> * gdbarch.c: Regenerated.
> * gdbarch.h: Regenerated.
>
> Index: cli/cli-cmds.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
> retrieving revision 1.2
> diff -p -u -w -r1.2 cli-cmds.c
> --- cli/cli-cmds.c 2000/12/15 01:01:51 1.2
> +++ cli/cli-cmds.c 2001/01/25 22:11:12
> @@ -1,5 +1,5 @@
> /* GDB CLI commands.
> - Copyright 2000 Free Software Foundation, Inc.
> + Copyright 2000, 2001 Free Software Foundation, Inc.
>
> This file is part of GDB.
>
> @@ -557,7 +557,7 @@ apropos_command (char *searchstr, int fr
> regerror(regcomp(&pattern,searchstr,REG_ICASE),NULL,errorbuffer,512);
> error("Error in regular expression:%s",errorbuffer);
> }
> - free(pattern_fastmap);
> + xfree (pattern_fastmap);
> }
>
> static void
>
> Index: gdbarch.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbarch.c,v
> retrieving revision 1.51
> diff -p -u -w -r1.51 gdbarch.c
> --- gdbarch.c 2001/01/22 23:32:49 1.51
> +++ gdbarch.c 2001/01/25 22:11:44
> @@ -1,7 +1,7 @@
> /* *INDENT-OFF* */ /* THIS FILE IS GENERATED */
>
> /* Dynamic architecture support for GDB, the GNU debugger.
> - Copyright 1998-1999, Free Software Foundation, Inc.
> + Copyright 1998, 1999, 2001 Free Software Foundation, Inc.
>
> This file is part of GDB.
>
> @@ -467,7 +467,7 @@ void
> gdbarch_free (struct gdbarch *arch)
> {
> /* At the moment, this is trivial. */
> - free (arch);
> + xfree (arch);
> }
>
>
> Index: gdbarch.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbarch.h,v
> retrieving revision 1.40
> diff -p -u -w -r1.40 gdbarch.h
> --- gdbarch.h 2001/01/22 23:32:49 1.40
> +++ gdbarch.h 2001/01/25 22:11:58
> @@ -1,7 +1,7 @@
> /* *INDENT-OFF* */ /* THIS FILE IS GENERATED */
>
> /* Dynamic architecture support for GDB, the GNU debugger.
> - Copyright 1998-1999, Free Software Foundation, Inc.
> + Copyright 1998-2001, Free Software Foundation, Inc.
>
> This file is part of GDB.
>
> Index: gdbarch.sh
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbarch.sh,v
> retrieving revision 1.51
> diff -p -u -w -r1.51 gdbarch.sh
> --- gdbarch.sh 2001/01/22 23:32:49 1.51
> +++ gdbarch.sh 2001/01/25 22:11:25
> @@ -1,7 +1,7 @@
> #!/bin/sh -u
>
> # Architecture commands for GDB, the GNU debugger.
> -# Copyright 1998-2000 Free Software Foundation, Inc.
> +# Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
> #
> # This file is part of GDB.
> #
> @@ -531,7 +531,7 @@ cat <<EOF
> /* *INDENT-OFF* */ /* THIS FILE IS GENERATED */
>
> /* Dynamic architecture support for GDB, the GNU debugger.
> - Copyright 1998-1999, Free Software Foundation, Inc.
> + Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
>
> This file is part of GDB.
>
> @@ -1239,7 +1239,7 @@ void
> gdbarch_free (struct gdbarch *arch)
> {
> /* At the moment, this is trivial. */
> - free (arch);
> + xfree (arch);
> }
> EOF
>
> Index: remote-utils.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/remote-utils.h,v
> retrieving revision 1.5
> diff -p -u -w -r1.5 remote-utils.h
> --- remote-utils.h 2000/11/03 22:00:56 1.5
> +++ remote-utils.h 2001/01/25 22:12:09
> @@ -1,6 +1,6 @@
> /* Generic support for remote debugging interfaces.
>
> - Copyright 1993 Free Software Foundation, Inc.
> + Copyright 1993, 2001 Free Software Foundation, Inc.
>
> This file is part of GDB.
>
> @@ -53,7 +53,7 @@ extern struct _sr_settings sr_settings;
> #define sr_get_device() (sr_settings.device)
> #define sr_set_device(newval) \
> { \
> - if (sr_settings.device) free(sr_settings.device); \
> + if (sr_settings.device) xfree (sr_settings.device); \
> sr_settings.device = (newval); \
> }
>
> Index: symtab.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/symtab.h,v
> retrieving revision 1.16
> diff -p -u -w -r1.16 symtab.h
> --- symtab.h 2000/11/10 23:02:56 1.16
> +++ symtab.h 2001/01/25 22:13:10
> @@ -1,5 +1,5 @@
> /* Symbol table definitions for GDB.
> - Copyright 1986, 89, 91, 92, 93, 94, 95, 96, 1998
> + Copyright 1986, 1989, 1991, 1992, 1993, 1994, 1995, 1996, 1998, 2001
> Free Software Foundation, Inc.
>
> This file is part of GDB.
> @@ -26,7 +26,7 @@
>
> #include "obstack.h"
> #define obstack_chunk_alloc xmalloc
> -#define obstack_chunk_free free
> +#define obstack_chunk_free xfree
> #include "bcache.h"
>
> /* Don't do this; it means that if some .o's are compiled with GNU C
> @@ -182,7 +182,7 @@ extern CORE_ADDR symbol_overlayed_addres
> SYMBOL_LANGUAGE (symbol) = language_cplus; \
> SYMBOL_CPLUS_DEMANGLED_NAME (symbol) = \
> obsavestring (demangled, strlen (demangled), (obstack)); \
> - free (demangled); \
> + xfree (demangled); \
> } \
> else \
> { \
> @@ -199,7 +199,7 @@ extern CORE_ADDR symbol_overlayed_addres
> SYMBOL_LANGUAGE (symbol) = language_java; \
> SYMBOL_CPLUS_DEMANGLED_NAME (symbol) = \
> obsavestring (demangled, strlen (demangled), (obstack)); \
> - free (demangled); \
> + xfree (demangled); \
> } \
> else \
> { \
> @@ -217,7 +217,7 @@ extern CORE_ADDR symbol_overlayed_addres
> SYMBOL_LANGUAGE (symbol) = language_chill; \
> SYMBOL_CHILL_DEMANGLED_NAME (symbol) = \
> obsavestring (demangled, strlen (demangled), (obstack)); \
> - free (demangled); \
> + xfree (demangled); \
> } \
> else \
> { \
>
> Index: value.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/value.h,v
> retrieving revision 1.13
> diff -p -u -w -r1.13 value.h
> --- value.h 2001/01/09 00:12:48 1.13
> +++ value.h 2001/01/25 22:13:21
> @@ -1,5 +1,6 @@
> /* Definitions for values of C expressions, for GDB.
> - Copyright 1986, 1987, 1989, 1992-1996, 2000 Free Software Foundation, Inc.
> + Copyright 1986, 1987, 1989, 1992, 1993, 1994, 1995, 1996, 2000, 2001
> + Free Software Foundation, Inc.
>
> This file is part of GDB.
>
> @@ -456,7 +457,7 @@ extern int unop_user_defined_p (enum exp
>
> extern int destructor_name_p (const char *name, const struct type *type);
>
> -#define value_free(val) free ((PTR)val)
> +#define value_free(val) xfree ((PTR)val)
>
> extern void free_all_values (void);
>
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9