This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] strdup->xstrdup
- To: Jeff Holcomb <jeffh at redhat dot com>
- Subject: Re: [RFA] strdup->xstrdup
- From: Kevin Buettner <kevinb at cygnus dot com>
- Date: Thu, 25 Jan 2001 09:58:36 -0700
- Cc: gdb-patches at sources dot redhat dot com
- References: <Pine.SOL.3.91.1010125084431.29868f-100000@cse.cygnus.com>
On Jan 25, 8:47am, Jeff Holcomb wrote:
> > ...you are no longer removing the strdup() declaration from this file
> > as you indicate in your ChangeLog entries. (Your earlier patch did
> > remove this declaration.)
>
> Oops. Lets try again. Thanks for looking this over. :)
The patch looks okay now. The only final nit that I have regarding
this patch submission (but not for your previous ones though) is the
form of the ChangeLog entries. Normally, ChangeLog entries are not
sent as a diff...
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/src/src/gdb/ChangeLog,v
> retrieving revision 1.902
> diff -u -p -r1.902 ChangeLog
> --- ChangeLog 2001/01/24 00:26:46 1.902
> +++ ChangeLog 2001/01/25 16:44:07
> @@ -1,3 +1,20 @@
> +2001-01-24 Jeff Holcomb <jeffh@redhat.com>
> +
> + * remote-udi.c (udi_open): Change strdup to xstrdup.
> + * thread.c (thread_apply_all_command): Change strdup to xstrdup.
> + Update copyright message.
> + * varobj.c (delete_variable_1): Likewise.
> +
> + * gdb_string.h: Remove declaration of strdup. Update copyright
> + message.
> + * config/xm-mpw.h: Likewise.
> + * config/i386/xm-i386mach.h: Likewise.
> + * config/m68k/xm-apollo68b.h: Likewise.
> + * config/m68k/xm-hp300bsd.h: Likewise.
> + * config/rs6000/xm-rs6000.h: Likewise.
> + * config/vax/xm-vaxult.h: Remove declaration of strdup.
> + * config/vax/xm-vaxult2.h: Likewise.
> +
> 2001-01-23 Jim Blandy <jimb@redhat.com>
>
> * dwarf2read.c (read_tag_const_type, read_tag_volatile_type):