This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] string.h to gdb_string.h
Kevin Buettner wrote:
>
> On Jan 25, 8:06am, David Smith wrote:
>
> > Here's a revised
> > patch/changelog entry with the changes you suggested. Sorry about the
> > "," in the copyright notice. I noticed that the original files had a
> > mix of styles and I picked one style to make them consistent.
> > Unfortunately, I picked the wrong style...
>
> I don't know for certain that it's the wrong style. It didn't look right
> to me when I reviewed the patch and I didn't see that style being used
> from the random files in gdb and bfd that I looked at.
>
> > 2001-01-24 David Smith <dsmith@redhat.com>
> >
> > * event-loop.c: Change inclusion of string.h to gdb_string.h and
> > updated the copyright notice.
> > * ser-pipe.c: Ditto.
> > * mi/mi-cmds.c: Ditto.
> > * mi/mi-console.c: Ditto.
> > * mi/mi-getopt.c: Ditto.
> > * mi/mi-parse.c: Ditto.
>
> You're patch looks okay to me now. When you add your ChangeLog
> comments to the ChangeLog file make sure that a tab precedes each of
> the '*' characters instead of eight spaces. (The first one is okay,
> the rest used spaces for some reason.)
>
> I'm not the maintainer of any of these files, so you'll either need
> approval from individual maintainers or someone who has "Blanket Write
> Privs".
>
I believe these cleanup patches have just to be exposed for a couple of
days,
as the concept of the change (replace string.h by gdb_string.h) has
already
been previously decided.
In any case, the MI ones are officially approved.
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9