Re: RFA: Patch to blockframe.c, frame.h, arm-tdep.c and fr30-tdep.c (prologue cache)

[Andrew Cagney <ac131313 at cygnus dot com>]

Fernando Nasser wrote:
> 
> I believe the following fixes a bug found by Elena.
> 
> Fernando
> 
> 2000-02-17  Fernando Nasser  <fnasser@totem.to.cygnus.com>
> 
>         * blockframe.c (check_prologue_cache, save_prologue_cache,
>         flush_prologue_cache): Slightly improved version of a prologue
> cache
>         used by some targets. Here there is a flush mechanism so we
> never use
>         stale data.
>         * frame.h: Prototypes for the above functions.
>         * arm-tdep.c (check_prologue_cache, save_prologue_cache):
> Deleted.
>         Moved (with changes) to blockframe.c.

First a technical question:  Does the code work with targets with
EXTRA_FRAME_INFO and INIT_EXTRA_FRAME_INFO?  I'm not sure if that should
be saved or not?

At a less technical level I also encountered the following problems:

	o	The function flush_prologue_cache()
		is called as flush_prolog_cache().
		As it stands, the patch won't compile.

	o	the change to frame.h creates
		``extern static ... PARAMS (())''

		The PARAMS bit isn't necessary
		and I suspect the ``extern static''
		was a cut/paste mistake.

		The header should also briefly
		explain what the interface is.

	o	the file fr30-tdep.c was changed
		but the ChangeLog didn't mention it

	o	btw your mail tool corrupted the
		patch (splitting several lines)

	o	I'd recommend making the FI param
		to save_prologue_cache const.

sorry,
	Andrew