This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH for alphaev56-dec-osf5.0: MERGEPID undefined


Yes, this is good.  Can someone who's working today check it
in?  Andrew?  JimB?
				Thanks,
				Michael

Andrew Hobson wrote:
> 
> I checked out gdb 5.0 from CVS today and found a minor compilation
> issue.  In procfs.c, I find:
> 
> /* Provide default composite pid manipulation macros for systems that
>    don't have threads. */
> 
> #ifndef PIDGET
> #define PIDGET(PID)             (PID)
> #define TIDGET(PID)             (PID)
> #define MERGEPID(PID, TID)      (PID)
> #endif
> 
> ... but in defs.h I find:
> 
> /* On some systems, PIDGET is defined to extract the inferior pid from
>    an internal pid that has the thread id and pid in seperate bit
>    fields.  If not defined, then just use the entire internal pid as
>    the actual pid. */
> 
> #ifndef PIDGET
> #define PIDGET(PID) (PID)
> #define TIDGET(PID) 0
> #endif
> 
> That leaves MERGEPID undefined.  I'm not positive of the correct fix,
> but the following patch solves the problem for me.
> 
> Drew
> 
> Index: defs.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/defs.h,v
> retrieving revision 1.1.1.31
> diff -u -p -r1.1.1.31 defs.h
> --- defs.h      2000/02/05 07:29:41     1.1.1.31
> +++ defs.h      2000/02/09 20:52:56
> @@ -1218,6 +1218,7 @@ extern int use_windows;
>  #ifndef PIDGET
>  #define PIDGET(PID) (PID)
>  #define TIDGET(PID) 0
> +#define MERGEPID(PID, TID) (PID)
>  #endif
> 
>  /* If under Cygwin, provide backwards compatibility with older

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]