This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Test result of "up" command in testsuites.
- To: Fernando Nasser <fnasser at cygnus dot com>
- Subject: Re: [PATCH] Test result of "up" command in testsuites.
- From: Michael Snyder <msnyder at redhat dot com>
- Date: Tue, 05 Dec 2000 15:58:15 -0800
- CC: Michael Snyder <msnyder at cygnus dot com>, gdb-patches at sources dot redhat dot com
- Organization: Red Hat, Inc.
- References: <200012052313.PAA01923@cleaver.cygnus.com> <3A2D794A.C201A189@cygnus.com>
Fernando Nasser wrote:
>
> Michael Snyder wrote:
> >
> > There are several tests in the testsuite that perform an "up" command
> > and then blythely assume that it succeeded (by evaluating variables
> > in the callers scope etc.). I've added a FAIL msg if the "up" command
> > fails, so at least we will know why the subsequent tests failed.
>
> Thanks Michael. But please add a "pass" as well to the cases where it
> applies before you check it in.
>
> You just hit a lucky spot and found one of those cases that can
> have a FAIL without having a corresponding PASS and thus confusing the
> test comparison scripts (the you tell you that things disappeared :-)
OK, added PASS and checked in.