This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [rfc] add __FILE__ and __LINE__ to internal_error()


> Date: Fri, 01 Dec 2000 22:22:05 +1100
> From: Andrew Cagney <ac131313@cygnus.com>
> 
> 	* gdb_assert.h (gdb_assert_fail), command.c (do_setshow_command),
>  	v850-tdep.c (v850_target_architecture_hook), i386-tdep.c
>  	(i386_extract_return_value), language.c
>  	(longest_local_hex_string_custom), solib-svr4.c

This is not how ChangeLog should be formatted.

The correct format is like this:

 	* gdb_assert.h (gdb_assert_fail):
	command.c (do_setshow_command):
  	v850-tdep.c (v850_target_architecture_hook):
	i386-tdep.c (i386_extract_return_value):
	language.c (longest_local_hex_string_custom):
	....
  	breakpoint.c (print_bp_stop_message, print_one_breakpoint)
	(check_duplicates, delete_breakpoint): Update.

(Note how a long list of functions from the same file is split between
two or more lines in the last example for breakpoint.c.)

And that "Update." should probably be "Update calls to internal_error."

The format of the ChangeLog entries is described in standards.texi,
node "Style of Change Logs".

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]