Re: [RFA] gdb.base/mips_pro.exp

[Fernando Nasser <fnasser at cygnus dot com>]

Approved.

Finally the die-hard mips_pro.exp FAIL will go away.
It was hanging around forever.

Thanks Michael.

Fernando


Michael Elizabeth Chastain wrote:
> 
> Here is take #2 on my small patch to gdb/testsuite/gdb.base/mips_pro.exp .
> Thanks to some feedback from Fernando Nasser, it's even smaller now
> (it continues using gdb_test instead of gdb_expect).
> 
> (1) Add a comment with the warning messages from the original PR 3016,
>     which was filed in 1993.  If we ever see these messages again,
>     I think having these comments will help.
> 
> (2) Remove setup_xfail for the hppa case.  I have results from running
>     this test case on hppa1.1-hp-hpux10.20 which indicates that this
>     test is fine for this platform.
> 
> (3) The important part: changes the test case to accept a stack trace
>     of "middle -> main" as well as "middle -> top -> main".  This fixes
>     the test failure.
> 
> Michael Elizabeth Chastain
> <chastain@redhat.com>
> "love without fear"
> 
> Index: gdb/testsuite/gdb.base/mips_pro.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/mips_pro.exp,v
> retrieving revision 1.1.1.3
> diff -c -3 -p -r1.1.1.3 mips_pro.exp
> *** gdb/testsuite/gdb.base/mips_pro.exp 1999/06/28 16:03:33     1.1.1.3
> --- gdb/testsuite/gdb.base/mips_pro.exp 2000/11/21 22:53:02
> *************** gdb_load ${binfile}
> *** 54,62 ****
> 
>   if [runto middle] then {
>       # PR 3016
>       if {$gcc_compiled} then {
> !       setup_xfail "hppa*-*-*" "mips*-sgi-irix4*" "mips64*-*-elf"
>       }
> !     gdb_test "backtrace" "#0.*middle.*#1.*top.*#2.*main.*"
>   }
>   return 0
> --- 54,64 ----
> 
>   if [runto middle] then {
>       # PR 3016
> +     #   warning: Hit heuristic-fence-post without finding
> +     #   warning: enclosing function for pc 0x1006ead0
>       if {$gcc_compiled} then {
> !       setup_xfail "mips*-sgi-irix4*" "mips64*-*-elf"
>       }
> !     gdb_test "backtrace" "#0.*middle.*#\[12\].*main.*"
>   }
>   return 0

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9