This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[patch] fix ``show remotewritesize''; Was: gdb-5.0 bug: show remotewritesize invokes set remotewritesize


Klaus Espenlaub wrote:
> 
> Hello!
> 
> There is a small typo in gdb/remote.c that causes the command
>         show remotewritesize
> to act like
>         set remotewritesize
> 
> The bug is in _initialize_remote(), just search for "remotewritesize".  The
> first occurrence in add_cmd() is correct, the second one should pass
> show_memory_write_packet_size instead of set_memory_write_packet_size.
> 
> Sorry for not preparing a patch, but I currently don't have the source
> available here.  I'd forget reporting the bug unless I do it now.
> 
> Regards

FYI,

I've applied the attatched.

	Andrew
Wed Nov 15 00:29:46 2000  Andrew Cagney  <cagney@b1.cygnus.com>

	From Klaus Espenlaub <espenlaub@informatik.uni-ulm.de>
	* remote.c (_initialize_remote): Call
 	show_memory_write_packet_size when ``show remotewritesize''
 	command.

Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.27
diff -p -r1.27 remote.c
*** remote.c	2000/11/03 22:00:56	1.27
--- remote.c	2000/11/14 13:38:06
*************** terminating `#' character and checksum."
*** 5577,5583 ****
    add_cmd ("remotewritesize", no_class, set_memory_write_packet_size,
  	   "Set the maximum number of bytes per memory write packet (deprecated).\n",
  	   &setlist);
!   add_cmd ("remotewritesize", no_class, set_memory_write_packet_size,
  	   "Show the maximum number of bytes per memory write packet (deprecated).\n",
  	   &showlist);
    add_cmd ("memory-write-packet-size", no_class,
--- 5577,5583 ----
    add_cmd ("remotewritesize", no_class, set_memory_write_packet_size,
  	   "Set the maximum number of bytes per memory write packet (deprecated).\n",
  	   &setlist);
!   add_cmd ("remotewritesize", no_class, show_memory_write_packet_size,
  	   "Show the maximum number of bytes per memory write packet (deprecated).\n",
  	   &showlist);
    add_cmd ("memory-write-packet-size", no_class,

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]