This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] 'set step-mode' to control the step command.


On Mon, Nov 06, 2000 at 03:32:37PM -0500, Elena Zannoni wrote:
>Christopher Faylor writes:
> > This patch is from a net contributor (assignment on file) who has added
> > an interesting new feature.  To quote:
> > 
> > "Set mode of the step operation.  When set, doing a step on a function
> > without debug line information will stop at the first instruction of
> > that function.  Otherwise, the function is skipped and the step command
> > stops at a different source line."
> > 
> > Does this look reasonable?
> > 
>
>Yes, but.... Instead of using another global to control the behavior of
>the stepping, let's make step_over_calls be an enum and add a fourth
>value to it for this particular case.

I started to do this but then realized that the "set step-mode" command
has a global state and the step_over_calls changes based on the command
being executed.

So, I will submit a revised patch with a enum'ized step_over_calls but keep
the step_stop_if_no_debug, if that is ok.

I'll also include the documentation that I neglected before.

Thanks for the feedback,
cgf

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]