This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] target.c: Add support for Solaris realtime signals
- To: ac131313 at cygnus dot com (Andrew Cagney)
- Subject: Re: [RFA] target.c: Add support for Solaris realtime signals
- From: "Peter.Schauer" <Peter dot Schauer at regent dot e-technik dot tu-muenchen dot de>
- Date: Wed, 27 Sep 2000 8:59:57 MET DST
- Cc: gdb-patches at sourceware dot cygnus dot com
> > * target.c (target_signal_from_host, do_target_signal_to_host):
> > Add support for Solaris realtime signals.
>
> I suspect it should call internal_error() rather than error() - if the
> signal turns out to be outside of that range then there is something
> serious. However, you mention that the signal numbering is dynamic -
> does this mean that the number of realtime signals can be increased to
> something more than 32 at runtime?) - hence the reason I'm not 100%
> sure.
Although I doubt that there could be more than 32 at runtime, here is the
definition from /usr/include/sys/signal.h:
#define SIGRTMIN _sysconf(_SC_SIGRT_MIN) /* first realtime signal */
#define SIGRTMAX _sysconf(_SC_SIGRT_MAX) /* last realtime signal */
which leaves us with the possibility that we might get more than 32 some day.
So I'd rather call error() than internal_error().
> Other than this, I've no problems with your patch.
OK to commit ?
--
Peter Schauer pes@regent.e-technik.tu-muenchen.de