This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch for DejaGnu test case "pointers"


On Sep 7,  4:03pm, Orjan Friberg wrote:

> [...] This is my first patch submission
> (more patches are on the way), so I'd appreciate feedback if any changes
> are needed.

In addition to providing ChangeLog entries (as noted by Hans-Peter
Nilsson), you should keep the diff headers intact.  I.e, you should
preserve the lines that appeared in your diff output immediately
before the following lines:

> *************** int more_code()
> *** 194,200 ****

Kevin

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]