Re: core dump support for cygwin

[Chris Faylor <cgf at cygnus dot com>]

On Fri, Aug 25, 2000 at 12:31:20AM +0400, Egor Duda wrote:
>Hi!
>
>  this is patch to make gdb support cygwin core dumps.

Thanks.

I have a couple of very minor nits.

It looks like you should be defining O_BINARY similarly to the way that it's
done in exec.c.  Otherwise systems which don't support this open flag will have
problems.

(I wonder if this should actually be defined in defs.h or something since it is used
all over the place in gdb)

Your changes to win32-nat.c use both K&R function definitions and ANSI prototypes.
Please just use the modern usages for all of your function definitions.

I'd prefer if you renamed cygwin_solib_add to child_solib_add to make this consistent
with the rest of the function names in the file.

Also, thanks for fixing my clear_solibs typo.

I'll approve the cygwin parts of this if you make the above changes.

Thanks again for this effort.  This will be an incredibly nice addition for Cygwin.

cgf