This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH]: more dcache cleanup


>>>>> "Mark" == Mark Kettenis <kettenis@wins.uva.nl> writes:
Mark>    Enclosed is a patch that I'll be committing shortly.  
Make>
Mark>    The bulk of it is renaming "dcache_flush" to the less ambigous
Mark>    "dcache_invd".  It also fixes a problem where the cache wasn't
Mark>    invalidated when a new image was loaded with the nindy monitor,
Mark>    and a problem where the dcache i/o functions were different for
Mark>    different ROM monitors.
Mark>
Mark> Sorry, I can't resist; dcache_invd sounds pretty cryptic to me.  Any
Mark> chance of changing it to dcache_invalidate before committing the
Mark> patch?

Sorry, a bit too late for that, although there is nothing preventing
renaming it once again.  

I was thinking about the invd and wbinvd x86 instructions when I
picked the name.

In an earlier message, I trolled for opinions wrt. dcache_invalidate
vs. dcache_invd and got no bites, so I opted for the shorter name.

Any other opinions?  If I change the names, I only want to do it once
more...

        --jtc

-- 
J.T. Conklin
RedBack Networks

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]