This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: recent dejagnu changes


I think the only changes needs to be backed out are runtest.exp w.r.t.
the dir_to_run, cmdline_dir_to_run, find -maxdepth changes, and possibly
utils.exp (find) enhancement (since if runtest.exp usage is backed out
it is no longer needed anywhere, although it's a valid change).

The problem is that I thought a dejagnu test tree contains
<tool>.<something>/ as a proper suite name, anywhere.  However apparently
the GCC suite just requires the top level suite name be such.  Yes in
this case the particular patch would not find these *.exp files since
the base directory will never be part of the test_top_dirs list.
Unfortunately the GDB suite, specifically gdb.hp/, follows the
convention that any test directory would be named with the 'gdb.'
prefix, e.g. gdb.hp/gdb.base-hp/.  In some ways this is correct, since
at any level a dejagnu test tree would be able to have additional .exp
library files to support that particular local tree in a directory not
starting with the <tool> prefix, e.g. gdb.hp/lib/gdb_hp.exp, for
example, would be possible (although not the case right now), and
runtest would be correctly skipping such library files not intended as
test files.

I don't know if GCC suite can rename all its sub-test-suite directories
to gcc.<something> :)  But feel free to back this patch out.  I can live
with the change being HP local.  Better yet, comment out my changes and
provide some explanations on why this does not work everywhere,
e.g. with GCC testing, so that this does not occur again ...

- Jimmy

On 4 Aug 2000, Geoff Keating wrote:

>
>Jimmy Guo <guo@cup.hp.com> writes:
>
>> > date: 2000/08/02 22:35:10;  author: guo;  state: Exp;  lines: +8 -1
>...
>> >is the one that breaks the GCC testsuite.  As far as I can see, it can
>> >never be a correct change.  It's not possible to change the GCC
>> >testsuite to match, because old versions of the testsuite need to work
>> >too.
>> 
>> Why?  We've been using it on GDB testsuite for months now.  What breaks
>> now for GCC?  I'm just curious -- backing it out in the repository is
>> fine, esp. if it breaks in some env ... but some details on why you
>> think so would be helpful ...
>
>The failure mode is that none of the c-torture tests run, with no
>error message.  So instead of 13000 or so testruns, you get about 200.
>
>I've attached below some sample output.
>
>> >I also think that this change:
>> >
>> >* lib/target.exp (default_target_compile,default_target_assemble,
>> >default_link): Remove env() interface for *_FOR_TARGET TCL vars.
>> >
>> >and this change:
>> >
>> >* runtest.exp: Cleanup reference to $env(MULTIPASS) and
>> >$env(PASS).  These were added by HP but unused since.
>> >
>> >are unwise.  I don't know what might depend on this functionality.
>> 
>> These were unfortunately added in by yours truly last year.  If you want
>> to back it out it's fine as well.
>> 
>> 
>> >They also seem to be part of the same patch judging by the ChangeLog
>> >entry.
>> 
>> Somehow emacs Ctrl-x 4 a does not create a new date stamp for separate
>> commits in ChangeLog .. these are actually separate.  But I can see how
>> it could be confusing.
>
>Aah.  You're supposed to write, for instance:
>
>2000-07-20  Geoff Keating  <geoffk@cygnus.com>
>
>	* config/rs6000/rs6000.c (struct toc_hash_struct): Add 'key_mode'
>	field.
>	(rs6000_hash_constant): Hash mode too.
>	(toc_hash_function): Allow for key_mode.
>	(toc_hash_eq): Structures are different if key_mode differs.
>	(output_toc): Add 'mode' parameter.  Save key_mode.
>	* config/rs6000/rs6000.h (ASM_OUTPUT_SPECIAL_POOL_ENTRY):
>	Pass 'mode' parameter.
>	* config/rs6000/rs6000-protos.h (output_toc): Add 'mode' param.
>
>	* config/rs6000/rs6000.c (output_toc): Use RS6000_OUTPUT_BASENAME
>	for vtable references.
>
>
>for two separate changes that happened to be committed on the same day.
>
>I'll see if I can't limit the backing-out to just the patch that
>causes the problem.
>
>-- 
>- Geoffrey Keating <geoffk@cygnus.com>
>
>----------BAD:
>		=== gcc tests ===
>
>Using /home/s1/cygnus/dejagnu/boards/standard.exp as standard board description file for build.
>Using /home/s1/cygnus/dejagnu/boards/standard.exp as standard board description file for host.
>Schedule of variations:
>    powerpc-sim
>
>Running target powerpc-sim
>Using /home/s1/cygnus/dejagnu/boards/standard.exp as standard board description file for target.
>Using /sloth/delay/tbox/objs/share/dejagnu/baseboards/powerpc-sim.exp as board description file for target.
>Using /sloth/delay/tbox/objs/share/dejagnu/config/sim.exp as generic interface file for target.
>Using /sloth/delay/tbox/objs/share/dejagnu/baseboards/basic-sim.exp as board description file for target.
>Using /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/config/default.exp as tool-and-target-specific interface file.
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.dg/dg.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/acker1.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/dg-test.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/dhry.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/gcov.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/linkage.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/matrix1.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/mg.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/msgs.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/sieve.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/sort2.exp ...
>
>		=== gcc Summary ===
>
># of expected passes		176
># of expected failures		16
># of unsupported tests		39
>
>----------GOOD:
>		=== gcc tests ===
>
>Using /home/s1/cygnus/dejagnu/boards/standard.exp as standard board description file for build.
>Using /home/s1/cygnus/dejagnu/boards/standard.exp as standard board description file for host.
>Schedule of variations:
>    powerpc-sim
>
>Running target powerpc-sim
>Using /home/s1/cygnus/dejagnu/boards/standard.exp as standard board description file for target.
>Using /sloth/delay/tbox/objs/share/dejagnu/baseboards/powerpc-sim.exp as board description file for target.
>Using /sloth/delay/tbox/objs/share/dejagnu/config/sim.exp as generic interface file for target.
>Using /sloth/delay/tbox/objs/share/dejagnu/baseboards/basic-sim.exp as board description file for target.
>Using /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/config/default.exp as tool-and-target-specific interface file.
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.c-torture/compile/compile.exp ...
>FAIL: gcc.c-torture/compile/20000804-1.c,  -O0  
>FAIL: gcc.c-torture/compile/20000804-1.c,  -O1  
>FAIL: gcc.c-torture/compile/20000804-1.c,  -O2  
>FAIL: gcc.c-torture/compile/20000804-1.c,  -O3 -fomit-frame-pointer  
>FAIL: gcc.c-torture/compile/20000804-1.c,  -O3 -g  
>FAIL: gcc.c-torture/compile/20000804-1.c,  -O3 -fssa  
>FAIL: gcc.c-torture/compile/20000804-1.c,  -Os  
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.c-torture/execute/execute.exp ...
>FAIL: gcc.c-torture/execute/20000225-1.c execution,  -O2 
>FAIL: gcc.c-torture/execute/20000225-1.c execution,  -O3 -fomit-frame-pointer 
>FAIL: gcc.c-torture/execute/20000225-1.c execution,  -O3 -fomit-frame-pointer -funroll-loops 
>FAIL: gcc.c-torture/execute/20000225-1.c execution,  -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions 
>FAIL: gcc.c-torture/execute/20000225-1.c execution,  -O3 -g 
>FAIL: gcc.c-torture/execute/20000225-1.c execution,  -O3 -fssa 
>FAIL: gcc.c-torture/execute/20000225-1.c execution,  -Os 
>FAIL: gcc.c-torture/execute/20000412-2.c execution,  -O2 
>FAIL: gcc.c-torture/execute/20000412-2.c execution,  -O3 -fomit-frame-pointer 
>FAIL: gcc.c-torture/execute/20000412-2.c execution,  -O3 -g 
>FAIL: gcc.c-torture/execute/20000412-2.c execution,  -O3 -fssa 
>FAIL: gcc.c-torture/execute/20000412-2.c execution,  -Os 
>XPASS: gcc.c-torture/execute/20000801-4.c execution,  -O0 
>XPASS: gcc.c-torture/execute/20000801-4.c execution,  -O1 
>XPASS: gcc.c-torture/execute/20000801-4.c execution,  -O2 
>XPASS: gcc.c-torture/execute/20000801-4.c execution,  -O3 -fomit-frame-pointer 
>XPASS: gcc.c-torture/execute/20000801-4.c execution,  -O3 -g 
>XPASS: gcc.c-torture/execute/20000801-4.c execution,  -O3 -fssa 
>XPASS: gcc.c-torture/execute/20000801-4.c execution,  -Os 
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.c-torture/execute/ieee/ieee.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.c-torture/execute/memcheck/memcheck.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.c-torture/unsorted/unsorted.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.dg/cpp/cpp.exp ...
>FAIL: gcc.dg/cpp/lexstrng.c (test for excess errors)
>FAIL: gcc.dg/cpp/paste2.c (test for excess errors)
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.dg/dg.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.dg/noncompile/noncompile.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.dg/special/ecos.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/acker1.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/dg-test.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/dhry.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/gcov.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/linkage.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/matrix1.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/mg.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/msgs.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/sieve.exp ...
>Running /sloth/delay/tbox/cvs-gcc/egcs/gcc/testsuite/gcc.misc-tests/sort2.exp ...
>
>		=== gcc Summary ===
>
># of expected passes		12737
># of unexpected failures	21
># of unexpected successes	7
># of expected failures		43
># of unsupported tests		40


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]