This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] dejagnu runtest.exp cleanup


Jimmy Guo wrote:
> 
> Well some of the env variables were added by HP ... and we have since
> moved to use the site.exp TCL var interface, after I learned that the
> env var interface might interfere with the standard build process
> (e.g. gnu make).
> 
> I'm not too strong on this ... if you think keeping these env vars
> around is OK, that fine as well.
> 

After I saw how this one is used I am having second thoughts.  Specifying
things like CC_FOR_TARGET is one thing, but this MULTIPASS variable seems
to be a dangerous thing to be getting from multiple places.  Too much for
consistence.  Lets take the env() part out as you wanted.

Please check it in.

Thanks.

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@cygnus.com
2323 Yonge Street, Suite #300           Tel:  416-482-2661 ext. 311
Toronto, Ontario   M4P 2C9              Fax:  416-482-6299

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]