This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: PATCH to top level: don't use dirname in configure
- To: msokolov at ivan dot Harhan dot ORG
- Subject: Re: PATCH to top level: don't use dirname in configure
- From: Eli Zaretskii <eliz at delorie dot com>
- Date: Sun, 23 Jul 2000 07:01:17 -0400 (EDT)
- CC: binutils at sources dot redhat dot com, gcc-patches at gcc dot gnu dot org, gdb-patches at sources dot redhat dot com
- References: <0007221542.AA29888@ivan.Harhan.ORG>
- Reply-to: Eli Zaretskii <eliz at is dot elta dot co dot il>
> Date: Sat, 22 Jul 00 10:42:11 CDT
> From: msokolov@ivan.Harhan.ORG (Michael Sokolov)
>
> Eli Zaretskii <eliz@delorie.com> wrote:
>
> > This assumes that (a) $(progname) always expands to "configure", and
> > (b) that the last delimiter is '/'. I don't know whether the first
> > assumption is true on each supported system, but the second might be
> > wrong on DOS/Windows where a backslash might be used instead.
>
> Both of these assumptions are already being made extensively by the
> rest of the very same Cygnus configure script.
Perhaps all of those places should be fixed not to use a literal
"configure".
> My patch fixes an existing problem that must be fixed, and it cannot
> introduce new problems that didn't exist before (as it does the same
> thing the rest of the script does), therefore, it should be checked
> in.
I didn't say the patch shouldn't be checked in (it's something for the
maintainers to decide), I just pointed out a possible regression that
could happen, in case it would be missed. This is what these forums
are for. If there's no regression, or if the regression is deemed not
important, it's fine with me.