This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
[PATCH] FreeBSD/i386 fixes
- To: gdb-patches at sourceware dot cygnus dot com
- Subject: [PATCH] FreeBSD/i386 fixes
- From: Mark Kettenis <kettenis at wins dot uva dot nl>
- Date: Thu, 1 Jun 2000 01:19:59 +0200
I just checked in the following, which fixes a stupid mistake I made
in i386bsd-nat.c:fill_gregset(), and adds some minor tweaks.
Mark
2000-06-01 Mark Kettenis <kettenis@gnu.org>
* i386bsd-nat.c: Include "gregset.h".
(CANNOT_STORE_REGISTER): Define to cannot_fetch_register instead
of CANNOT_FETCH_REGISTER, if not already defined.
(supply_gregset): Call supply_register with NULL as its second
argument instead of supplying our own zeroed out buffer.
(fill_gregset): Copy contents of correct registers instead of the
contents of register REGNO.
Index: i386bsd-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/i386bsd-nat.c,v
retrieving revision 1.1
diff -u -p -r1.1 i386bsd-nat.c
--- i386bsd-nat.c 2000/05/24 22:32:58 1.1
+++ i386bsd-nat.c 2000/05/31 23:05:01
@@ -38,6 +38,9 @@ typedef struct reg gregset_t;
typedef struct fpreg fpregset_t;
#endif
+#include "gregset.h"
+
+
/* In older BSD versions we cannot get at some of the segment
registers. FreeBSD for example didn't support the %fs and %gs
registers until the 3.0 release. We have autoconf checks for their
@@ -50,7 +53,7 @@ typedef struct fpreg fpregset_t;
/* Registers we shouldn't try to store. */
#if !defined (CANNOT_STORE_REGISTER)
-#define CANNOT_STORE_REGISTER(regno) CANNOT_FETCH_REGISTER (regno)
+#define CANNOT_STORE_REGISTER(regno) cannot_fetch_register (regno)
#endif
/* Offset to the gregset_t location where REG is stored. */
@@ -106,16 +109,12 @@ cannot_fetch_register (int regno)
void
supply_gregset (gregset_t *gregsetp)
{
- char buf[MAX_REGISTER_RAW_SIZE];
int i;
for (i = 0; i < NUM_GREGS; i++)
{
if (CANNOT_FETCH_REGISTER (i))
- {
- memset (buf, 0, REGISTER_RAW_SIZE (i));
- supply_register (i, buf);
- }
+ supply_register (i, NULL);
else
supply_register (i, REG_ADDR (gregsetp, i));
}
@@ -132,7 +131,7 @@ fill_gregset (gregset_t *gregsetp, int r
for (i = 0; i < NUM_GREGS; i++)
if ((regno == -1 || regno == i) && ! CANNOT_STORE_REGISTER (i))
- memcpy (REG_ADDR (gregsetp, i), ®isters[REGISTER_BYTE (regno)],
+ memcpy (REG_ADDR (gregsetp, i), ®isters[REGISTER_BYTE (i)],
REGISTER_RAW_SIZE (i));
}
@@ -180,7 +179,7 @@ fetch_inferior_registers (int regno)
supply_fpregset (&fpregs);
}
-}
+}
/* Store register REGNO back into the inferior. If REGNO is -1, do
this for all registers (including the floating point registers). */