This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: RFA: gdbarch IEEE_FLOAT
Jim Blandy wrote:
>
> > > > > + /* Provide a default value for IEEE_FLOAT. */
> > > > > + #ifndef IEEE_FLOAT
> > > > > + #define IEEE_FLOAT (0)
> > > > > + #endif
> > >
> > > Sounds great to me!
> >
> > BTW, is the default ``0'' or ``1''? The above has zero, but for
> > multi-arch it is set to one. (Just let me know, I'll tweek it when I
> > remove it :-).
>
> Well, for old targets it has to be zero.
>
> I was thinking that, for new gdbarch-style targets, 1 was the more
> convenient default, but on more careful reflection, I'm not sure
> that's smart: if someone is converting an existing port to gdbarch, it
> would be very confusing for IEEE_FLOAT to suddenly change its default
> value.
>
> So the default should be zero.
(The other option is to refuse to provide a default.)
I'll make it zero as, hopefully, the person doing the multi-arch will
remember to change #define IEEE_FLOAT 1 into the corresponding arch
initialization.
Andrew