Re: (patch) hpjyg15: hppah-nat.c & related

[Jeffrey A Law <law at cygnus dot com>]

  In message <382B585D.421E98F3@cygnus.com>you write:
  > Jimmy Guo wrote:
  > > 
  > > This patch updates hppah-nat.c and related files target.[ch] and
  > > infrun.c.  See ChangeLog below.
  > 
  > Jim,
  > 
  > Don't forget that the GDB's coding style is defined by the output of
  > indent.  Looking more closely I noticed that some of the changes are to
  > ``fix'' the indentation. Please just grit your teath and ignore it.
  > 
  > It's a good idea to carefully review the diffs and revert/remove any
  > changes not specific to the problem at hand.
  > 
  > Doing this makes the reviewers life so much easier.
Agreed.

What I would recommend is to send pure formatting changes to unrelated
code as a separate change.  That makes it *much* easier for the review to
separate the formatting fixes from patches that require one to think about
the consequences of a change.

Additionally, raw formatting patches can go almost immediately since by
definition they do not change the behavior of GDB.

This is a special case of the general rule that independent changes should be
sent as independent patches.

jeff