Re: RFA: new gdbarch methods for inserting/removing breakpoints

[Kevin Buettner <kevinb at cygnus dot com>]

On Oct 14,  9:13am, Andrew Cagney wrote:

> Kevin Buettner wrote:
> > 
> > Andrew, et.al,
> > 
> > I would like to check in the changes below.  These changes will allow
> > us to write architecture specific versions of
> > memory_insert_breakpoint() and memory_remove_breakpoint().  Custom
> > versions of these functions are needed on architectures where an
> > instruction is a strange size and/or does not fall neatly on a
> > byte-aligned boundary.  (E.g, ia64.)
> 
> Should ``default_memory_insert_breakpoint'' be made the default so that
> other targets continue to work?
> I may have missed it?

I think you missed it.  (But I'm new to the gdbarch stuff, so perhaps
I forgot to do something.)

For the targets which don't use gdbarch, the defines for
MEMORY_INSERT_BREAKPOINT and MEMORY_REMOVE_BREAKPOINT in mem-break.c
should take care of setting up the defaults.  (I tested it on Linux.)

For the targets which do use gdbarch, you'll notice that I put
default_memory_{insert,remove}_breakpoint in the seventh field in the
newly added lines to gdbarch.sh.  This causes the appropriate values
to be placed in the initialization of default_gdbarch.

Is there something else I needed to do?

Kevin