Re: RFA: remote test; Was: patch to remote.c for larger download packet support (part 1)

[Andrew Cagney <ac131313 at cygnus dot com>]

"Frank Ch. Eigler" wrote:

I believe that Stan is responsible for testsuites.

> The first patch is against gdb proper.  The second is a new test case family
> that checks the effect of changing the parameter over several repeated
> downloads.

Regardless of what happens to the bulk of your patch, and assuming Stan
approves, the testsuite addition should (almost) go straight in.  Just
check the BTWs, below.

> +    set load_begin_time [clock clicks]
> +    set result [gdb_load $executable]
> +    set load_end_time [clock clicks]
> +    if {$result < 0} then { fail "$test - loading executable"; return }
> +    verbose "$test - time [expr ($load_end_time - $load_begin_time) / 1000] ms"
> +    pass $test

FYI, the message attatched to the pass/fail alternatives should be
identical.

> +gdb_load_timed $binfile {}
> +gdb_load_timed $binfile 50
> +gdb_load_timed $binfile 100
> +gdb_load_timed $binfile 200
> +gdb_load_timed $binfile 400

Given previous e-mail I'd add a test with ``0'' and perhaphs ``-1''.

	enjoy,
		Andrew