This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project. See the GDB home page for more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

gdb-981121 : register_valid is `SIGNED char'



Compiling gdb-981121 on AIX 4.2, I get the following messages :

  gcc -c -g -O2    -I. -I/usr/gnu/tmp/gdb-981121/gdb -I/usr/gnu/tmp/gdb-981121/gdb/config -DHAVE_CONFIG_H -I/usr/gnu/tmp/gdb-981121/gdb/../include/opcode -I/usr/gnu/tmp/gdb-981121/gdb/../readline -I../bfd -I/usr/gnu/tmp/gdb-981121/gdb/../bfd  -I/usr/gnu/tmp/gdb-981121/gdb/../include -I../intl -I/usr/gnu/tmp/gdb-981121/gdb/../intl   /usr/gnu/tmp/gdb-981121/gdb/findvar.c
  /usr/gnu/tmp/gdb-981121/gdb/findvar.c: In function `read_relative_register_raw_bytes':
  /usr/gnu/tmp/gdb-981121/gdb/findvar.c:533: warning: comparison is always 0 due to limited range of data type
  /usr/gnu/tmp/gdb-981121/gdb/findvar.c: In function `value_of_register':
  /usr/gnu/tmp/gdb-981121/gdb/findvar.c:559: warning: comparison is always 0 due to limited range of data type
  /usr/gnu/tmp/gdb-981121/gdb/findvar.c: In function `value_from_register':
  /usr/gnu/tmp/gdb-981121/gdb/findvar.c:1407: warning: comparison is always 0 due to limited range of data type
  /usr/gnu/tmp/gdb-981121/gdb/findvar.c:1472: warning: comparison is always 0 due to limited range of data type

Here is a fix :

Tue Dec  8 00:34:20 1998  Philippe De Muyter  <phdm@macqel.be>

	* inferior.h (register_valid): Variable's type is `SIGNED char', not
 	`char'.
	* findvar.c (register_valid): Ditto.

--- ./gdb/inferior.h	Tue Dec  8 00:19:21 1998
+++ ./gdb/inferior.h	Tue Dec  8 00:19:02 1998
@@ -100,9 +100,10 @@
 extern char registers[];
 
 /* Array of validity bits (one per register).  Nonzero at position XXX_REGNUM
-   means that `registers' contains a valid copy of inferior register XXX.  */
+   means that `registers' contains a valid copy of inferior register XXX.
+   -1 if register value is not available. */
 
-extern char register_valid[NUM_REGS];
+extern SIGNED char register_valid[NUM_REGS];
 
 extern void clear_proceed_status PARAMS ((void));
 
--- ./gdb/findvar.c	Fri Dec  4 01:01:38 1998
+++ ./gdb/findvar.c	Thu Nov 26 20:14:38 1998
@@ -598,8 +598,9 @@ value_of_register (regnum)
 
 char registers[REGISTER_BYTES + /* SLOP */ 256];
 
-/* Nonzero if that register has been fetched.  */
-char register_valid[NUM_REGS];
+/* Nonzero if that register has been fetched,
+   -1 if register value not available. */
+SIGNED char register_valid[NUM_REGS];
 
 /* The thread/process associated with the current set of registers.  For now,
    -1 is special, and means `no current process'.  */