This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Remove dwarf2_per_objfile global
- From: Simon Marchi <simark at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 7 Jan 2018 16:23:39 -0000
- Subject: [binutils-gdb] Remove dwarf2_per_objfile global
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ed2dc618b3d2b0be01ffdf74c4c75504b707bcf1
commit ed2dc618b3d2b0be01ffdf74c4c75504b707bcf1
Author: Simon Marchi <simon.marchi@ericsson.com>
Date: Sun Jan 7 11:22:46 2018 -0500
Remove dwarf2_per_objfile global
This patch removes the global variable dwarf2_per_objfile. This global
variable is set at the various entry points of dwarf2read.c (using
dw2_setup), and is referred to throughout the file. Instead of passing
data between functions in global variables like this one, it would be
better if the functions that depend on it either received it as argument
or got it from the existing arguments they receive. For example, a
function receiving a reference to a dwarf2_per_cu_data can access it
from dwarf2_per_cu_data::dwarf2_per_objfile.
This patch has been tested on the buildbot.
gdb/ChangeLog:
* dwarf2read.c (struct mapped_debug_names): Add constructor.
<dwarf2_per_objfile>: New field.
(dwarf2_per_objfile): Remove global.
(get_dwarf2_per_objfile): New function.
(set_dwarf2_per_objfile): New function.
(dwarf2_build_psymtabs_hard): Change objfile parameter to
dwarf2_per_objfile.
(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
(read_abbrev_offset): Likewise.
(read_indirect_string): Likewise.
(read_indirect_line_string): Likewise.
(read_indirect_string_at_offset): Likewise.
(read_indirect_string_from_dwz): Likewise.
(dwarf2_find_containing_comp_unit): Change objfile parameter to
dwarf2_per_objfile.
(age_cached_comp_units): Add dwarf2_per_objfile parameter.
(create_all_comp_units): Change objfile parameter to
dwarf2_per_objfile.
(create_all_type_units): Likewise.
(process_queue): Add dwarf2_per_objfile parameter.
(read_and_check_comp_unit_head): Likewise.
(lookup_dwo_unit_in_dwp): Likewise.
(get_dwp_file): Likewise.
(process_cu_includes): Likewise.
(struct free_dwo_file_cleanup_data): New struct.
(dwarf2_has_info): Use get_dwarf2_per_objfile and
set_dwarf2_per_objfile.
(dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
(dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
context, adjust calls.
(dw2_instantiate_symtab): Likewise.
(dw2_get_cutu): Add dwarf2_per_objfile parameter.
(dw2_get_cu): Likewise.
(create_cu_from_index_list): Change objfile parameter to
dwarf2_per_objfile.
(create_cus_from_index_list): Get dwarf2_per_objfile from
context, adjust calls.
(create_cus_from_index): Likewise.
(create_signatured_type_table_from_index): Change objfile
parameter to dwarf2_per_objfile.
(create_signatured_type_table_from_debug_names): Change objfile
parameter to dwarf2_per_objfile.
(create_addrmap_from_index): Likewise.
(create_addrmap_from_aranges): Likewise.
(dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
(dw2_setup): Remove.
(dw2_get_file_names_reader): Get dwarf2_per_objfile from
context.
(dw2_find_last_source_symtab): Get dwarf2_per_objfile using
get_dwarf2_per_objfile.
(dw2_forget_cached_source_info): Likewise.
(dw2_map_symtabs_matching_filename): Likewise.
(struct dw2_symtab_iterator) <index>: Remove.
<dwarf2_per_objfile>: New field.
(dw2_symtab_iter_init): Replace index parameter with
dwarf2_per_objfile.
(dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
(dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
(dw2_print_stats): Likewise.
(dw2_dump): Likewise.
(dw2_expand_symtabs_for_function): Likewise.
(dw2_expand_all_symtabs): Likewise.
(dw2_expand_symtabs_with_fullname): Likewise.
(dw2_expand_marked_cus): Replace index and objfile parameters
with dwarf2_per_objfile.
(dw_expand_symtabs_matching_file_matcher): Add
dwarf2_per_objfile parameter and adjust calls.
(dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
adjust calls.
(dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
(dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
adjust calls.
(create_cus_from_debug_names_list): Replace objfile parameter
with dwarf2_per_objfile and adjust calls.
(create_cus_from_debug_names): Likewise.
(dwarf2_read_debug_names): Likewise.
(mapped_debug_names::namei_to_name): Adjust call.
(dw2_debug_names_iterator::next): Likewise.
(dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
(dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
(dw2_debug_names_dump): Likewise.
(dw2_debug_names_expand_symtabs_for_function): Likewise.
(dw2_debug_names_expand_symtabs_matching): Likewise.
(dwarf2_initialize_objfile): Likewise.
(dwarf2_build_psymtabs): Likewise.
(get_abbrev_section_for_cu): Get dwarf2_per_objfile from
this_cu.
(error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
(read_and_check_comp_unit_head): Likewise.
(read_abbrev_offset): Likewise.
(create_debug_type_hash_table): Likewise.
(create_debug_types_hash_table): Likewise.
(create_all_type_units): Replace objfile parameter with
dwarf2_per_objfile.
(add_type_unit): Add dwarf2_per_objfile parameter.
(fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
with dwarf2_per_objfile.
(lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
(lookup_dwp_signatured_type): Likewise.
(lookup_signatured_type): Likewise.
(read_cutu_die_from_dwo): Likewise.
(init_tu_and_read_dwo_dies): Likewise.
(init_cutu_and_read_dies): Likewise.
(init_cutu_and_read_dies_no_follow): Likewise.
(allocate_type_unit_groups_table): Add objfile parameter.
(create_type_unit_group): Use dwarf2_per_objfile from cu.
(get_type_unit_group): Likewise.
(process_psymtab_comp_unit): Update call.
(build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
(build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
(print_tu_stats): Likewise.
(build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
in void* parameter.
(build_type_psymtabs): Change objfile parameter to
dwarf2_per_objfile.
(process_skeletonless_type_unit): Use dwarf2_per_objfile
passed in void* parameter.
(process_skeletonless_type_units): Change objfile parameter to
dwarf2_per_objfile.
(set_partial_user): Likewise.
(dwarf2_build_psymtabs_hard): Likewise.
(read_comp_units_from_section): Likewise.
(create_all_comp_units): Likewise.
(scan_partial_symbols): Update calls.
(add_partial_symbol): Likewise.
(dwarf2_read_symtab): Use get_dwarf2_per_objfile.
(maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
(process_queue): Add dwarf2_per_objfile parameter.
(get_compunit_symtab): Use dwarf2_per_objfile from cu.
(compute_compunit_symtab_includes): Likewise.
(process_cu_includes): Add dwarf2_per_objfile parameter.
(process_full_comp_unit): Use dwarf2_per_objfile from cu.
(process_full_type_unit): Likewise.
(process_imported_unit_die): Update call.
(handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
(read_file_scope): Likewise.
(allocate_dwo_file_hash_table): Add objfile parameter.
(lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
(create_cus_hash_table): Likewise.
(create_dwp_hash_table): Likewise.
(create_dwo_unit_in_dwp_v1): Likewise.
(create_dwp_v2_section): Likewise.
(create_dwo_unit_in_dwp_v2): Likewise.
(lookup_dwo_unit_in_dwp): Likewise.
(try_open_dwop_file): Likewise.
(open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
(open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
cleanup to include a reference to dwarf2_per_objfile.
(open_dwp_file): Add dwarf2_per_objfile parameter.
(open_and_init_dwp_file): Likewise.
(get_dwp_file): Likewise.
(lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
(queue_and_load_all_dwo_tus): Update call.
(free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
data.
(dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
(dwarf2_ranges_process): Likewise.
(dwarf2_get_pc_bounds): Likewise.
(mark_common_block_symbol_computed): Likewise.
(abbrev_table_read_table): Add dwarf2_per_objfile parameter.
(dwarf2_read_abbrevs): Update call.
(read_partial_die): Use dwarf2_per_objfile from cu.
(find_partial_die): Likewise.
(fixup_partial_die): Likewise.
(read_attribute_value): Likewise.
(read_indirect_string_at_offset_from): Add objfile parameter.
(read_indirect_string_at_offset): Add dwarf2_per_objfile
parameter.
(read_indirect_string_from_dwz): Add objfile parameter.
(read_indirect_string): Add objfile parameter.
(read_addr_index_1): Add dwarf2_per_objfile parameter.
(read_addr_index): Use dwarf2_per_objfile from cu.
(dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
call dw2_setup.
(read_str_index): Use dwarf2_per_objfile from cu.
(get_debug_line_section): Likewise.
(read_formatted_entries): Add dwarf2_per_objfile parameter.
(dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
(new_symbol_full): Use dwarf2_per_objfile from cu.
(build_error_marker_type): Likewise.
(lookup_die_type): Likewise.
(determine_prefix): Likewise.
(follow_die_offset): Likewise.
(dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
(dwarf2_fetch_constant_bytes): Don't call dw2_setup.
(dwarf2_fetch_die_type_sect_off): Likewise.
(dwarf2_get_die_type): Likewise.
(follow_die_sig_1): Use dwarf2_per_objfile from cu.
(get_signatured_type): Likewise.
(get_DW_AT_signature_type): Likewise.
(dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
(dwarf_decode_macros): Use dwarf2_per_objfile from cu.
(cu_debug_loc_section): Likewise.
(fill_in_loclist_baton): Likewise.
(dwarf2_symbol_mark_computed): Likewise.
(dwarf2_find_containing_comp_unit): Change objfile parameter to
dwarf2_per_objfile.
(free_cached_comp_units): Use dwarf2_per_objfile passed in void*
parameter.
(age_cached_comp_units): Add dwarf2_per_objfile parameter.
(free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
(dwarf2_free_objfile): Use get_dwarf2_per_objfile.
(set_die_type): Use dwarf2_free_objfile from cu.
(get_die_type_at_offset): Likewise.
(dwarf2_per_objfile_free): Don't assign global variable.
(debug_names) <constructor>: Add dwarf2_per_objfile
parameter, update m_debugstrlookup construction.
(debug_names::debug_str_lookup): Add dwarf2_per_objfile
parameter.
<m_dwarf2_per_objfile>: New field.
<lookup>: Use m_dwarf2_per_objfile.
(check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
(psyms_seen_size): Likewise.
(write_gdbindex): Replace objfile parameter with
dwarf2_per_objfile.
(write_debug_names): Likewise.
(write_psymtabs_to_index): Likewise.
(save_gdb_index_command): Use get_dwarf2_per_objfile, update
calls.
Diff:
---
gdb/ChangeLog | 222 ++++++++++++
gdb/dwarf2read.c | 1024 ++++++++++++++++++++++++++++++++----------------------
2 files changed, 836 insertions(+), 410 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 196a58e..7775af2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,227 @@
2018-01-07 Simon Marchi <simon.marchi@ericsson.com>
+ * dwarf2read.c (struct mapped_debug_names): Add constructor.
+ <dwarf2_per_objfile>: New field.
+ (dwarf2_per_objfile): Remove global.
+ (get_dwarf2_per_objfile): New function.
+ (set_dwarf2_per_objfile): New function.
+ (dwarf2_build_psymtabs_hard): Change objfile parameter to
+ dwarf2_per_objfile.
+ (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
+ (read_abbrev_offset): Likewise.
+ (read_indirect_string): Likewise.
+ (read_indirect_line_string): Likewise.
+ (read_indirect_string_at_offset): Likewise.
+ (read_indirect_string_from_dwz): Likewise.
+ (dwarf2_find_containing_comp_unit): Change objfile parameter to
+ dwarf2_per_objfile.
+ (age_cached_comp_units): Add dwarf2_per_objfile parameter.
+ (create_all_comp_units): Change objfile parameter to
+ dwarf2_per_objfile.
+ (create_all_type_units): Likewise.
+ (process_queue): Add dwarf2_per_objfile parameter.
+ (read_and_check_comp_unit_head): Likewise.
+ (lookup_dwo_unit_in_dwp): Likewise.
+ (get_dwp_file): Likewise.
+ (process_cu_includes): Likewise.
+ (struct free_dwo_file_cleanup_data): New struct.
+ (dwarf2_has_info): Use get_dwarf2_per_objfile and
+ set_dwarf2_per_objfile.
+ (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
+ (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
+ context, adjust calls.
+ (dw2_instantiate_symtab): Likewise.
+ (dw2_get_cutu): Add dwarf2_per_objfile parameter.
+ (dw2_get_cu): Likewise.
+ (create_cu_from_index_list): Change objfile parameter to
+ dwarf2_per_objfile.
+ (create_cus_from_index_list): Get dwarf2_per_objfile from
+ context, adjust calls.
+ (create_cus_from_index): Likewise.
+ (create_signatured_type_table_from_index): Change objfile
+ parameter to dwarf2_per_objfile.
+ (create_signatured_type_table_from_debug_names): Change objfile
+ parameter to dwarf2_per_objfile.
+ (create_addrmap_from_index): Likewise.
+ (create_addrmap_from_aranges): Likewise.
+ (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
+ (dw2_setup): Remove.
+ (dw2_get_file_names_reader): Get dwarf2_per_objfile from
+ context.
+ (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
+ get_dwarf2_per_objfile.
+ (dw2_forget_cached_source_info): Likewise.
+ (dw2_map_symtabs_matching_filename): Likewise.
+ (struct dw2_symtab_iterator) <index>: Remove.
+ <dwarf2_per_objfile>: New field.
+ (dw2_symtab_iter_init): Replace index parameter with
+ dwarf2_per_objfile.
+ (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
+ (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
+ (dw2_print_stats): Likewise.
+ (dw2_dump): Likewise.
+ (dw2_expand_symtabs_for_function): Likewise.
+ (dw2_expand_all_symtabs): Likewise.
+ (dw2_expand_symtabs_with_fullname): Likewise.
+ (dw2_expand_marked_cus): Replace index and objfile parameters
+ with dwarf2_per_objfile.
+ (dw_expand_symtabs_matching_file_matcher): Add
+ dwarf2_per_objfile parameter and adjust calls.
+ (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
+ adjust calls.
+ (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
+ (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
+ adjust calls.
+ (create_cus_from_debug_names_list): Replace objfile parameter
+ with dwarf2_per_objfile and adjust calls.
+ (create_cus_from_debug_names): Likewise.
+ (dwarf2_read_debug_names): Likewise.
+ (mapped_debug_names::namei_to_name): Adjust call.
+ (dw2_debug_names_iterator::next): Likewise.
+ (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
+ (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
+ (dw2_debug_names_dump): Likewise.
+ (dw2_debug_names_expand_symtabs_for_function): Likewise.
+ (dw2_debug_names_expand_symtabs_matching): Likewise.
+ (dwarf2_initialize_objfile): Likewise.
+ (dwarf2_build_psymtabs): Likewise.
+ (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
+ this_cu.
+ (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
+ (read_and_check_comp_unit_head): Likewise.
+ (read_abbrev_offset): Likewise.
+ (create_debug_type_hash_table): Likewise.
+ (create_debug_types_hash_table): Likewise.
+ (create_all_type_units): Replace objfile parameter with
+ dwarf2_per_objfile.
+ (add_type_unit): Add dwarf2_per_objfile parameter.
+ (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
+ with dwarf2_per_objfile.
+ (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
+ (lookup_dwp_signatured_type): Likewise.
+ (lookup_signatured_type): Likewise.
+ (read_cutu_die_from_dwo): Likewise.
+ (init_tu_and_read_dwo_dies): Likewise.
+ (init_cutu_and_read_dies): Likewise.
+ (init_cutu_and_read_dies_no_follow): Likewise.
+ (allocate_type_unit_groups_table): Add objfile parameter.
+ (create_type_unit_group): Use dwarf2_per_objfile from cu.
+ (get_type_unit_group): Likewise.
+ (process_psymtab_comp_unit): Update call.
+ (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
+ (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
+ (print_tu_stats): Likewise.
+ (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
+ in void* parameter.
+ (build_type_psymtabs): Change objfile parameter to
+ dwarf2_per_objfile.
+ (process_skeletonless_type_unit): Use dwarf2_per_objfile
+ passed in void* parameter.
+ (process_skeletonless_type_units): Change objfile parameter to
+ dwarf2_per_objfile.
+ (set_partial_user): Likewise.
+ (dwarf2_build_psymtabs_hard): Likewise.
+ (read_comp_units_from_section): Likewise.
+ (create_all_comp_units): Likewise.
+ (scan_partial_symbols): Update calls.
+ (add_partial_symbol): Likewise.
+ (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
+ (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
+ (process_queue): Add dwarf2_per_objfile parameter.
+ (get_compunit_symtab): Use dwarf2_per_objfile from cu.
+ (compute_compunit_symtab_includes): Likewise.
+ (process_cu_includes): Add dwarf2_per_objfile parameter.
+ (process_full_comp_unit): Use dwarf2_per_objfile from cu.
+ (process_full_type_unit): Likewise.
+ (process_imported_unit_die): Update call.
+ (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
+ (read_file_scope): Likewise.
+ (allocate_dwo_file_hash_table): Add objfile parameter.
+ (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
+ (create_cus_hash_table): Likewise.
+ (create_dwp_hash_table): Likewise.
+ (create_dwo_unit_in_dwp_v1): Likewise.
+ (create_dwp_v2_section): Likewise.
+ (create_dwo_unit_in_dwp_v2): Likewise.
+ (lookup_dwo_unit_in_dwp): Likewise.
+ (try_open_dwop_file): Likewise.
+ (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
+ (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
+ cleanup to include a reference to dwarf2_per_objfile.
+ (open_dwp_file): Add dwarf2_per_objfile parameter.
+ (open_and_init_dwp_file): Likewise.
+ (get_dwp_file): Likewise.
+ (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
+ (queue_and_load_all_dwo_tus): Update call.
+ (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
+ data.
+ (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
+ (dwarf2_ranges_process): Likewise.
+ (dwarf2_get_pc_bounds): Likewise.
+ (mark_common_block_symbol_computed): Likewise.
+ (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
+ (dwarf2_read_abbrevs): Update call.
+ (read_partial_die): Use dwarf2_per_objfile from cu.
+ (find_partial_die): Likewise.
+ (fixup_partial_die): Likewise.
+ (read_attribute_value): Likewise.
+ (read_indirect_string_at_offset_from): Add objfile parameter.
+ (read_indirect_string_at_offset): Add dwarf2_per_objfile
+ parameter.
+ (read_indirect_string_from_dwz): Add objfile parameter.
+ (read_indirect_string): Add objfile parameter.
+ (read_addr_index_1): Add dwarf2_per_objfile parameter.
+ (read_addr_index): Use dwarf2_per_objfile from cu.
+ (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
+ call dw2_setup.
+ (read_str_index): Use dwarf2_per_objfile from cu.
+ (get_debug_line_section): Likewise.
+ (read_formatted_entries): Add dwarf2_per_objfile parameter.
+ (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
+ (new_symbol_full): Use dwarf2_per_objfile from cu.
+ (build_error_marker_type): Likewise.
+ (lookup_die_type): Likewise.
+ (determine_prefix): Likewise.
+ (follow_die_offset): Likewise.
+ (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
+ (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
+ (dwarf2_fetch_die_type_sect_off): Likewise.
+ (dwarf2_get_die_type): Likewise.
+ (follow_die_sig_1): Use dwarf2_per_objfile from cu.
+ (get_signatured_type): Likewise.
+ (get_DW_AT_signature_type): Likewise.
+ (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
+ (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
+ (cu_debug_loc_section): Likewise.
+ (fill_in_loclist_baton): Likewise.
+ (dwarf2_symbol_mark_computed): Likewise.
+ (dwarf2_find_containing_comp_unit): Change objfile parameter to
+ dwarf2_per_objfile.
+ (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
+ parameter.
+ (age_cached_comp_units): Add dwarf2_per_objfile parameter.
+ (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
+ (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
+ (set_die_type): Use dwarf2_free_objfile from cu.
+ (get_die_type_at_offset): Likewise.
+ (dwarf2_per_objfile_free): Don't assign global variable.
+ (debug_names) <constructor>: Add dwarf2_per_objfile
+ parameter, update m_debugstrlookup construction.
+ (debug_names::debug_str_lookup): Add dwarf2_per_objfile
+ parameter.
+ <m_dwarf2_per_objfile>: New field.
+ <lookup>: Use m_dwarf2_per_objfile.
+ (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
+ (psyms_seen_size): Likewise.
+ (write_gdbindex): Replace objfile parameter with
+ dwarf2_per_objfile.
+ (write_debug_names): Likewise.
+ (write_psymtabs_to_index): Likewise.
+ (save_gdb_index_command): Use get_dwarf2_per_objfile, update
+ calls.
+
+2018-01-07 Simon Marchi <simon.marchi@ericsson.com>
+
* dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
<dwarf2_per_objfile>: New field.
(struct dwarf2_per_cu_data) <objfile>: Remove.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 78f1aab..ba56b45 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -320,6 +320,11 @@ struct mapped_index final : public mapped_index_base
Uninitialized map has CU_COUNT 0. */
struct mapped_debug_names final : public mapped_index_base
{
+ mapped_debug_names (struct dwarf2_per_objfile *dwarf2_per_objfile_)
+ : dwarf2_per_objfile (dwarf2_per_objfile_)
+ {}
+
+ struct dwarf2_per_objfile *dwarf2_per_objfile;
bfd_endian dwarf5_byte_order;
bool dwarf5_is_dwarf64;
bool augmentation_is_gdb;
@@ -514,7 +519,24 @@ public:
gdb::optional<filename_seen_cache> filenames_cache;
};
-static struct dwarf2_per_objfile *dwarf2_per_objfile;
+/* Get the dwarf2_per_objfile associated to OBJFILE. */
+
+struct dwarf2_per_objfile *
+get_dwarf2_per_objfile (struct objfile *objfile)
+{
+ return ((struct dwarf2_per_objfile *)
+ objfile_data (objfile, dwarf2_objfile_data_key));
+}
+
+/* Set the dwarf2_per_objfile associated to OBJFILE. */
+
+void
+set_dwarf2_per_objfile (struct objfile *objfile,
+ struct dwarf2_per_objfile *dwarf2_per_objfile)
+{
+ gdb_assert (get_dwarf2_per_objfile (objfile) == NULL);
+ set_objfile_data (objfile, dwarf2_objfile_data_key, dwarf2_per_objfile);
+}
/* Default names of the debugging sections. */
@@ -1708,7 +1730,8 @@ static void build_type_psymtabs_reader (const struct die_reader_specs *reader,
struct die_info *type_unit_die,
int has_children, void *data);
-static void dwarf2_build_psymtabs_hard (struct objfile *);
+static void dwarf2_build_psymtabs_hard
+ (struct dwarf2_per_objfile *dwarf2_per_objfile);
static void scan_partial_symbols (struct partial_die_info *,
CORE_ADDR *, CORE_ADDR *,
@@ -1741,7 +1764,8 @@ static struct abbrev_info *abbrev_table_lookup_abbrev
(const struct abbrev_table *, unsigned int);
static struct abbrev_table *abbrev_table_read_table
- (struct dwarf2_section_info *, sect_offset);
+ (struct dwarf2_per_objfile *dwarf2_per_objfile, struct dwarf2_section_info *,
+ sect_offset);
static void abbrev_table_free (struct abbrev_table *);
@@ -1798,25 +1822,28 @@ static LONGEST read_offset (bfd *, const gdb_byte *,
static LONGEST read_offset_1 (bfd *, const gdb_byte *, unsigned int);
-static sect_offset read_abbrev_offset (struct dwarf2_section_info *,
- sect_offset);
+static sect_offset read_abbrev_offset
+ (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct dwarf2_section_info *, sect_offset);
static const gdb_byte *read_n_bytes (bfd *, const gdb_byte *, unsigned int);
static const char *read_direct_string (bfd *, const gdb_byte *, unsigned int *);
-static const char *read_indirect_string (bfd *, const gdb_byte *,
- const struct comp_unit_head *,
- unsigned int *);
+static const char *read_indirect_string
+ (struct dwarf2_per_objfile *dwarf2_per_objfile, bfd *, const gdb_byte *,
+ const struct comp_unit_head *, unsigned int *);
-static const char *read_indirect_line_string (bfd *, const gdb_byte *,
- const struct comp_unit_head *,
- unsigned int *);
+static const char *read_indirect_line_string
+ (struct dwarf2_per_objfile *dwarf2_per_objfile, bfd *, const gdb_byte *,
+ const struct comp_unit_head *, unsigned int *);
-static const char *read_indirect_string_at_offset (bfd *abfd,
- LONGEST str_offset);
+static const char *read_indirect_string_at_offset
+ (struct dwarf2_per_objfile *dwarf2_per_objfile, bfd *abfd,
+ LONGEST str_offset);
-static const char *read_indirect_string_from_dwz (struct dwz_file *, LONGEST);
+static const char *read_indirect_string_from_dwz
+ (struct objfile *objfile, struct dwz_file *, LONGEST);
static LONGEST read_signed_leb128 (bfd *, const gdb_byte *, unsigned int *);
@@ -2113,7 +2140,8 @@ static hashval_t partial_die_hash (const void *item);
static int partial_die_eq (const void *item_lhs, const void *item_rhs);
static struct dwarf2_per_cu_data *dwarf2_find_containing_comp_unit
- (sect_offset sect_off, unsigned int offset_in_dwz, struct objfile *objfile);
+ (sect_offset sect_off, unsigned int offset_in_dwz,
+ struct dwarf2_per_objfile *dwarf2_per_objfile);
static void init_one_comp_unit (struct dwarf2_cu *cu,
struct dwarf2_per_cu_data *per_cu);
@@ -2126,16 +2154,16 @@ static void free_heap_comp_unit (void *);
static void free_cached_comp_units (void *);
-static void age_cached_comp_units (void);
+static void age_cached_comp_units (struct dwarf2_per_objfile *dwarf2_per_objfile);
static void free_one_cached_comp_unit (struct dwarf2_per_cu_data *);
static struct type *set_die_type (struct die_info *, struct type *,
struct dwarf2_cu *);
-static void create_all_comp_units (struct objfile *);
+static void create_all_comp_units (struct dwarf2_per_objfile *dwarf2_per_objfile);
-static int create_all_type_units (struct objfile *);
+static int create_all_type_units (struct dwarf2_per_objfile *dwarf2_per_objfile);
static void load_full_comp_unit (struct dwarf2_per_cu_data *,
enum language);
@@ -2163,7 +2191,7 @@ static void dwarf2_release_queue (void *dummy);
static void queue_comp_unit (struct dwarf2_per_cu_data *per_cu,
enum language pretend_language);
-static void process_queue (void);
+static void process_queue (struct dwarf2_per_objfile *dwarf2_per_objfile);
/* The return type of find_file_and_directory. Note, the enclosed
string pointers are only valid while this object is valid. */
@@ -2194,7 +2222,8 @@ static char *file_full_name (int file, struct line_header *lh,
enum class rcuh_kind { COMPILE, TYPE };
static const gdb_byte *read_and_check_comp_unit_head
- (struct comp_unit_head *header,
+ (struct dwarf2_per_objfile* dwarf2_per_objfile,
+ struct comp_unit_head *header,
struct dwarf2_section_info *section,
struct dwarf2_section_info *abbrev_section, const gdb_byte *info_ptr,
rcuh_kind section_kind);
@@ -2213,10 +2242,12 @@ static htab_t allocate_signatured_type_table (struct objfile *objfile);
static htab_t allocate_dwo_unit_table (struct objfile *objfile);
static struct dwo_unit *lookup_dwo_unit_in_dwp
- (struct dwp_file *dwp_file, const char *comp_dir,
+ (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct dwp_file *dwp_file, const char *comp_dir,
ULONGEST signature, int is_debug_types);
-static struct dwp_file *get_dwp_file (void);
+static struct dwp_file *get_dwp_file
+ (struct dwarf2_per_objfile *dwarf2_per_objfile);
static struct dwo_unit *lookup_dwo_comp_unit
(struct dwarf2_per_cu_data *, const char *, const char *, ULONGEST);
@@ -2228,7 +2259,13 @@ static void queue_and_load_all_dwo_tus (struct dwarf2_per_cu_data *);
static void free_dwo_file_cleanup (void *);
-static void process_cu_includes (void);
+struct free_dwo_file_cleanup_data
+{
+ struct dwo_file *dwo_file;
+ struct dwarf2_per_objfile *dwarf2_per_objfile;
+};
+
+static void process_cu_includes (struct dwarf2_per_objfile *dwarf2_per_objfile);
static void check_producer (struct dwarf2_cu *cu);
@@ -2425,16 +2462,17 @@ dwarf2_has_info (struct objfile *objfile,
if (objfile->flags & OBJF_READNEVER)
return 0;
- dwarf2_per_objfile = ((struct dwarf2_per_objfile *)
- objfile_data (objfile, dwarf2_objfile_data_key));
- if (!dwarf2_per_objfile)
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
+
+ if (dwarf2_per_objfile == NULL)
{
/* Initialize per-objfile state. */
struct dwarf2_per_objfile *data
= XOBNEW (&objfile->objfile_obstack, struct dwarf2_per_objfile);
dwarf2_per_objfile = new (data) struct dwarf2_per_objfile (objfile, names);
- set_objfile_data (objfile, dwarf2_objfile_data_key, dwarf2_per_objfile);
+ set_dwarf2_per_objfile (objfile, dwarf2_per_objfile);
}
return (!dwarf2_per_objfile->info.is_virtual
&& dwarf2_per_objfile->info.s.section != NULL
@@ -2855,7 +2893,7 @@ locate_dwz_sections (bfd *abfd, asection *sectp, void *arg)
is such a section but the file cannot be found. */
static struct dwz_file *
-dwarf2_get_dwz_file (void)
+dwarf2_get_dwz_file (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
const char *filename;
struct dwz_file *result;
@@ -3071,6 +3109,7 @@ static void
dw2_do_instantiate_symtab (struct dwarf2_per_cu_data *per_cu)
{
struct cleanup *back_to;
+ struct dwarf2_per_objfile *dwarf2_per_objfile = per_cu->dwarf2_per_objfile;
/* Skip type_unit_groups, reading the type units they contain
is handled elsewhere. */
@@ -3095,15 +3134,15 @@ dw2_do_instantiate_symtab (struct dwarf2_per_cu_data *per_cu)
&& dwarf2_per_objfile->index_table != NULL
&& dwarf2_per_objfile->index_table->version <= 7
/* DWP files aren't supported yet. */
- && get_dwp_file () == NULL)
+ && get_dwp_file (dwarf2_per_objfile) == NULL)
queue_and_load_all_dwo_tus (per_cu);
}
- process_queue ();
+ process_queue (dwarf2_per_objfile);
/* Age the cache, releasing compilation units that have not
been used recently. */
- age_cached_comp_units ();
+ age_cached_comp_units (dwarf2_per_objfile);
do_cleanups (back_to);
}
@@ -3115,13 +3154,16 @@ dw2_do_instantiate_symtab (struct dwarf2_per_cu_data *per_cu)
static struct compunit_symtab *
dw2_instantiate_symtab (struct dwarf2_per_cu_data *per_cu)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = per_cu->dwarf2_per_objfile;
+
gdb_assert (dwarf2_per_objfile->using_index);
if (!per_cu->v.quick->compunit_symtab)
{
- struct cleanup *back_to = make_cleanup (free_cached_comp_units, NULL);
+ struct cleanup *back_to = make_cleanup (free_cached_comp_units,
+ dwarf2_per_objfile);
scoped_restore decrementer = increment_reading_symtab ();
dw2_do_instantiate_symtab (per_cu);
- process_cu_includes ();
+ process_cu_includes (dwarf2_per_objfile);
do_cleanups (back_to);
}
@@ -3142,7 +3184,8 @@ dw2_instantiate_symtab (struct dwarf2_per_cu_data *per_cu)
*/
static struct dwarf2_per_cu_data *
-dw2_get_cutu (int index)
+dw2_get_cutu (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ int index)
{
if (index >= dwarf2_per_objfile->n_comp_units)
{
@@ -3159,7 +3202,7 @@ dw2_get_cutu (int index)
refers to a CU. */
static struct dwarf2_per_cu_data *
-dw2_get_cu (int index)
+dw2_get_cu (struct dwarf2_per_objfile *dwarf2_per_objfile, int index)
{
gdb_assert (index >= 0 && index < dwarf2_per_objfile->n_comp_units);
@@ -3171,11 +3214,12 @@ dw2_get_cu (int index)
values. */
static dwarf2_per_cu_data *
-create_cu_from_index_list (struct objfile *objfile,
+create_cu_from_index_list (struct dwarf2_per_objfile *dwarf2_per_objfile,
struct dwarf2_section_info *section,
int is_dwz,
sect_offset sect_off, ULONGEST length)
{
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
dwarf2_per_cu_data *the_cu
= OBSTACK_ZALLOC (&objfile->objfile_obstack,
struct dwarf2_per_cu_data);
@@ -3200,6 +3244,8 @@ create_cus_from_index_list (struct objfile *objfile,
int base_offset)
{
offset_type i;
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
for (i = 0; i < n_elements; i += 2)
{
@@ -3211,7 +3257,8 @@ create_cus_from_index_list (struct objfile *objfile,
cu_list += 2 * 8;
dwarf2_per_objfile->all_comp_units[base_offset + i / 2]
- = create_cu_from_index_list (objfile, section, is_dwz, sect_off, length);
+ = create_cu_from_index_list (dwarf2_per_objfile, section, is_dwz,
+ sect_off, length);
}
}
@@ -3224,6 +3271,8 @@ create_cus_from_index (struct objfile *objfile,
const gdb_byte *dwz_list, offset_type dwz_elements)
{
struct dwz_file *dwz;
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
dwarf2_per_objfile->n_comp_units = (cu_list_elements + dwz_elements) / 2;
dwarf2_per_objfile->all_comp_units =
@@ -3236,7 +3285,7 @@ create_cus_from_index (struct objfile *objfile,
if (dwz_elements == 0)
return;
- dwz = dwarf2_get_dwz_file ();
+ dwz = dwarf2_get_dwz_file (dwarf2_per_objfile);
create_cus_from_index_list (objfile, dwz_list, dwz_elements, &dwz->info, 1,
cu_list_elements / 2);
}
@@ -3251,6 +3300,8 @@ create_signatured_type_table_from_index (struct objfile *objfile,
{
offset_type i;
htab_t sig_types_hash;
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
dwarf2_per_objfile->n_type_units
= dwarf2_per_objfile->n_allocated_type_units
@@ -3301,11 +3352,13 @@ create_signatured_type_table_from_index (struct objfile *objfile,
static void
create_signatured_type_table_from_debug_names
- (struct objfile *objfile,
+ (struct dwarf2_per_objfile *dwarf2_per_objfile,
const mapped_debug_names &map,
struct dwarf2_section_info *section,
struct dwarf2_section_info *abbrev_section)
{
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
+
dwarf2_read_section (objfile, section);
dwarf2_read_section (objfile, abbrev_section);
@@ -3331,7 +3384,8 @@ create_signatured_type_table_from_debug_names
map.dwarf5_byte_order));
comp_unit_head cu_header;
- read_and_check_comp_unit_head (&cu_header, section, abbrev_section,
+ read_and_check_comp_unit_head (dwarf2_per_objfile, &cu_header, section,
+ abbrev_section,
section->buffer + to_underlying (sect_off),
rcuh_kind::TYPE);
@@ -3360,8 +3414,10 @@ create_signatured_type_table_from_debug_names
populate the objfile's psymtabs_addrmap. */
static void
-create_addrmap_from_index (struct objfile *objfile, struct mapped_index *index)
+create_addrmap_from_index (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct mapped_index *index)
{
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
struct gdbarch *gdbarch = get_objfile_arch (objfile);
const gdb_byte *iter, *end;
struct addrmap *mutable_map;
@@ -3404,7 +3460,8 @@ create_addrmap_from_index (struct objfile *objfile, struct mapped_index *index)
lo = gdbarch_adjust_dwarf2_addr (gdbarch, lo + baseaddr);
hi = gdbarch_adjust_dwarf2_addr (gdbarch, hi + baseaddr);
- addrmap_set_empty (mutable_map, lo, hi - 1, dw2_get_cutu (cu_index));
+ addrmap_set_empty (mutable_map, lo, hi - 1,
+ dw2_get_cutu (dwarf2_per_objfile, cu_index));
}
objfile->psymtabs_addrmap = addrmap_create_fixed (mutable_map,
@@ -3415,9 +3472,10 @@ create_addrmap_from_index (struct objfile *objfile, struct mapped_index *index)
populate the objfile's psymtabs_addrmap. */
static void
-create_addrmap_from_aranges (struct objfile *objfile,
+create_addrmap_from_aranges (struct dwarf2_per_objfile *dwarf2_per_objfile,
struct dwarf2_section_info *section)
{
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
bfd *abfd = objfile->obfd;
struct gdbarch *gdbarch = get_objfile_arch (objfile);
const CORE_ADDR baseaddr = ANOFFSET (objfile->section_offsets,
@@ -3432,7 +3490,7 @@ create_addrmap_from_aranges (struct objfile *objfile,
debug_info_offset_to_per_cu;
for (int cui = 0; cui < dwarf2_per_objfile->n_comp_units; ++cui)
{
- dwarf2_per_cu_data *per_cu = dw2_get_cutu (cui);
+ dwarf2_per_cu_data *per_cu = dw2_get_cutu (dwarf2_per_objfile, cui);
const auto insertpair
= debug_info_offset_to_per_cu.emplace (per_cu->sect_off, per_cu);
if (!insertpair.second)
@@ -3793,6 +3851,8 @@ dwarf2_read_index (struct objfile *objfile)
const gdb_byte *cu_list, *types_list, *dwz_list = NULL;
offset_type cu_list_elements, types_list_elements, dwz_list_elements = 0;
struct dwz_file *dwz;
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
if (!read_index_from_section (objfile, objfile_name (objfile),
use_deprecated_index_sections,
@@ -3807,7 +3867,7 @@ dwarf2_read_index (struct objfile *objfile)
/* If there is a .dwz file, read it so we can get its CU list as
well. */
- dwz = dwarf2_get_dwz_file ();
+ dwz = dwarf2_get_dwz_file (dwarf2_per_objfile);
if (dwz != NULL)
{
struct mapped_index dwz_map;
@@ -3846,7 +3906,7 @@ dwarf2_read_index (struct objfile *objfile)
types_list_elements);
}
- create_addrmap_from_index (objfile, &local_map);
+ create_addrmap_from_index (dwarf2_per_objfile, &local_map);
map = XOBNEW (&objfile->objfile_obstack, struct mapped_index);
map = new (map) mapped_index ();
@@ -3860,17 +3920,6 @@ dwarf2_read_index (struct objfile *objfile)
return 1;
}
-/* A helper for the "quick" functions which sets the global
- dwarf2_per_objfile according to OBJFILE. */
-
-static void
-dw2_setup (struct objfile *objfile)
-{
- dwarf2_per_objfile = ((struct dwarf2_per_objfile *)
- objfile_data (objfile, dwarf2_objfile_data_key));
- gdb_assert (dwarf2_per_objfile);
-}
-
/* die_reader_func for dw2_get_file_names. */
static void
@@ -3881,7 +3930,8 @@ dw2_get_file_names_reader (const struct die_reader_specs *reader,
void *data)
{
struct dwarf2_cu *cu = reader->cu;
- struct dwarf2_per_cu_data *this_cu = cu->per_cu;
+ struct dwarf2_per_cu_data *this_cu = cu->per_cu;
+ struct dwarf2_per_objfile *dwarf2_per_objfile = cu->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct dwarf2_per_cu_data *lh_cu;
struct attribute *attr;
@@ -3994,14 +4044,15 @@ dw2_get_real_path (struct objfile *objfile,
static struct symtab *
dw2_find_last_source_symtab (struct objfile *objfile)
{
- struct compunit_symtab *cust;
- int index;
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
+ int index = dwarf2_per_objfile->n_comp_units - 1;
+ dwarf2_per_cu_data *dwarf_cu = dw2_get_cutu (dwarf2_per_objfile, index);
+ compunit_symtab *cust = dw2_instantiate_symtab (dwarf_cu);
- dw2_setup (objfile);
- index = dwarf2_per_objfile->n_comp_units - 1;
- cust = dw2_instantiate_symtab (dw2_get_cutu (index));
if (cust == NULL)
return NULL;
+
return compunit_primary_filetab (cust);
}
@@ -4029,7 +4080,8 @@ dw2_free_cached_file_names (void **slot, void *info)
static void
dw2_forget_cached_source_info (struct objfile *objfile)
{
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
htab_traverse_noresize (dwarf2_per_objfile->quick_file_names_table,
dw2_free_cached_file_names, NULL);
@@ -4067,16 +4119,16 @@ dw2_map_symtabs_matching_filename
{
int i;
const char *name_basename = lbasename (name);
-
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
/* The rule is CUs specify all the files, including those used by
any TU, so there's no need to scan TUs here. */
- for (i = 0; i < dwarf2_per_objfile->n_comp_units; ++i)
+ for (int i = 0; i < dwarf2_per_objfile->n_comp_units; ++i)
{
int j;
- struct dwarf2_per_cu_data *per_cu = dw2_get_cu (i);
+ struct dwarf2_per_cu_data *per_cu = dw2_get_cu (dwarf2_per_objfile, i);
struct quick_file_names *file_data;
/* We only need to look at symtabs not already expanded. */
@@ -4138,8 +4190,8 @@ dw2_map_symtabs_matching_filename
struct dw2_symtab_iterator
{
- /* The internalized form of .gdb_index. */
- struct mapped_index *index;
+ /* The dwarf2_per_objfile owning the CUs we are iterating on. */
+ struct dwarf2_per_objfile *dwarf2_per_objfile;
/* If non-zero, only look for symbols that match BLOCK_INDEX. */
int want_specific_block;
/* One of GLOBAL_BLOCK or STATIC_BLOCK.
@@ -4167,20 +4219,23 @@ struct dw2_symtab_iterator
static void
dw2_symtab_iter_init (struct dw2_symtab_iterator *iter,
- struct mapped_index *index,
+ struct dwarf2_per_objfile *dwarf2_per_objfile,
int want_specific_block,
int block_index,
domain_enum domain,
const char *name)
{
- iter->index = index;
+ iter->dwarf2_per_objfile = dwarf2_per_objfile;
iter->want_specific_block = want_specific_block;
iter->block_index = block_index;
iter->domain = domain;
iter->next = 0;
iter->global_seen = 0;
- if (find_slot_in_mapped_hash (index, name, &iter->vec))
+ mapped_index *index = dwarf2_per_objfile->index_table;
+
+ /* index is NULL if OBJF_READNOW. */
+ if (index != NULL && find_slot_in_mapped_hash (index, name, &iter->vec))
iter->length = MAYBE_SWAP (*iter->vec);
else
{
@@ -4194,6 +4249,8 @@ dw2_symtab_iter_init (struct dw2_symtab_iterator *iter,
static struct dwarf2_per_cu_data *
dw2_symtab_iter_next (struct dw2_symtab_iterator *iter)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = iter->dwarf2_per_objfile;
+
for ( ; iter->next < iter->length; ++iter->next)
{
offset_type cu_index_and_attrs =
@@ -4210,7 +4267,7 @@ dw2_symtab_iter_next (struct dw2_symtab_iterator *iter)
and indices >= 7 may elide them for certain symbols
(gold does this). */
int attrs_valid =
- (iter->index->version >= 7
+ (dwarf2_per_objfile->index_table->version >= 7
&& symbol_kind != GDB_INDEX_SYMBOL_KIND_NONE);
/* Don't crash on bad data. */
@@ -4224,7 +4281,7 @@ dw2_symtab_iter_next (struct dw2_symtab_iterator *iter)
continue;
}
- per_cu = dw2_get_cutu (cu_index);
+ per_cu = dw2_get_cutu (dwarf2_per_objfile, cu_index);
/* Skip if already read in. */
if (per_cu->v.quick->compunit_symtab)
@@ -4280,46 +4337,39 @@ dw2_lookup_symbol (struct objfile *objfile, int block_index,
const char *name, domain_enum domain)
{
struct compunit_symtab *stab_best = NULL;
- struct mapped_index *index;
-
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
lookup_name_info lookup_name (name, symbol_name_match_type::FULL);
- index = dwarf2_per_objfile->index_table;
-
- /* index is NULL if OBJF_READNOW. */
- if (index)
- {
- struct dw2_symtab_iterator iter;
- struct dwarf2_per_cu_data *per_cu;
+ struct dw2_symtab_iterator iter;
+ struct dwarf2_per_cu_data *per_cu;
- dw2_symtab_iter_init (&iter, index, 1, block_index, domain, name);
+ dw2_symtab_iter_init (&iter, dwarf2_per_objfile, 1, block_index, domain, name);
- while ((per_cu = dw2_symtab_iter_next (&iter)) != NULL)
- {
- struct symbol *sym, *with_opaque = NULL;
- struct compunit_symtab *stab = dw2_instantiate_symtab (per_cu);
- const struct blockvector *bv = COMPUNIT_BLOCKVECTOR (stab);
- struct block *block = BLOCKVECTOR_BLOCK (bv, block_index);
+ while ((per_cu = dw2_symtab_iter_next (&iter)) != NULL)
+ {
+ struct symbol *sym, *with_opaque = NULL;
+ struct compunit_symtab *stab = dw2_instantiate_symtab (per_cu);
+ const struct blockvector *bv = COMPUNIT_BLOCKVECTOR (stab);
+ struct block *block = BLOCKVECTOR_BLOCK (bv, block_index);
- sym = block_find_symbol (block, name, domain,
- block_find_non_opaque_type_preferred,
- &with_opaque);
+ sym = block_find_symbol (block, name, domain,
+ block_find_non_opaque_type_preferred,
+ &with_opaque);
- /* Some caution must be observed with overloaded functions
- and methods, since the index will not contain any overload
- information (but NAME might contain it). */
+ /* Some caution must be observed with overloaded functions
+ and methods, since the index will not contain any overload
+ information (but NAME might contain it). */
- if (sym != NULL
- && SYMBOL_MATCHES_SEARCH_NAME (sym, lookup_name))
- return stab;
- if (with_opaque != NULL
- && SYMBOL_MATCHES_SEARCH_NAME (with_opaque, lookup_name))
- stab_best = stab;
+ if (sym != NULL
+ && SYMBOL_MATCHES_SEARCH_NAME (sym, lookup_name))
+ return stab;
+ if (with_opaque != NULL
+ && SYMBOL_MATCHES_SEARCH_NAME (with_opaque, lookup_name))
+ stab_best = stab;
- /* Keep looking through other CUs. */
- }
+ /* Keep looking through other CUs. */
}
return stab_best;
@@ -4328,14 +4378,14 @@ dw2_lookup_symbol (struct objfile *objfile, int block_index,
static void
dw2_print_stats (struct objfile *objfile)
{
- int i, total, count;
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
+ int total = dwarf2_per_objfile->n_comp_units + dwarf2_per_objfile->n_type_units;
+ int count = 0;
- dw2_setup (objfile);
- total = dwarf2_per_objfile->n_comp_units + dwarf2_per_objfile->n_type_units;
- count = 0;
- for (i = 0; i < total; ++i)
+ for (int i = 0; i < total; ++i)
{
- struct dwarf2_per_cu_data *per_cu = dw2_get_cutu (i);
+ struct dwarf2_per_cu_data *per_cu = dw2_get_cutu (dwarf2_per_objfile, i);
if (!per_cu->v.quick->compunit_symtab)
++count;
@@ -4352,7 +4402,9 @@ dw2_print_stats (struct objfile *objfile)
static void
dw2_dump (struct objfile *objfile)
{
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
+
gdb_assert (dwarf2_per_objfile->using_index);
printf_filtered (".gdb_index:");
if (dwarf2_per_objfile->index_table != NULL)
@@ -4377,38 +4429,33 @@ static void
dw2_expand_symtabs_for_function (struct objfile *objfile,
const char *func_name)
{
- struct mapped_index *index;
-
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
- index = dwarf2_per_objfile->index_table;
+ struct dw2_symtab_iterator iter;
+ struct dwarf2_per_cu_data *per_cu;
- /* index is NULL if OBJF_READNOW. */
- if (index)
- {
- struct dw2_symtab_iterator iter;
- struct dwarf2_per_cu_data *per_cu;
+ /* Note: It doesn't matter what we pass for block_index here. */
+ dw2_symtab_iter_init (&iter, dwarf2_per_objfile, 0, GLOBAL_BLOCK, VAR_DOMAIN,
+ func_name);
- /* Note: It doesn't matter what we pass for block_index here. */
- dw2_symtab_iter_init (&iter, index, 0, GLOBAL_BLOCK, VAR_DOMAIN,
- func_name);
+ while ((per_cu = dw2_symtab_iter_next (&iter)) != NULL)
+ dw2_instantiate_symtab (per_cu);
- while ((per_cu = dw2_symtab_iter_next (&iter)) != NULL)
- dw2_instantiate_symtab (per_cu);
- }
}
static void
dw2_expand_all_symtabs (struct objfile *objfile)
{
- int i;
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
+ int total_units = (dwarf2_per_objfile->n_comp_units
+ + dwarf2_per_objfile->n_type_units);
- dw2_setup (objfile);
-
- for (i = 0; i < (dwarf2_per_objfile->n_comp_units
- + dwarf2_per_objfile->n_type_units); ++i)
+ for (int i = 0; i < total_units; ++i)
{
- struct dwarf2_per_cu_data *per_cu = dw2_get_cutu (i);
+ struct dwarf2_per_cu_data *per_cu
+ = dw2_get_cutu (dwarf2_per_objfile, i);
dw2_instantiate_symtab (per_cu);
}
@@ -4418,19 +4465,18 @@ static void
dw2_expand_symtabs_with_fullname (struct objfile *objfile,
const char *fullname)
{
- int i;
-
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
/* We don't need to consider type units here.
This is only called for examining code, e.g. expand_line_sal.
There can be an order of magnitude (or more) more type units
than comp units, and we avoid them if we can. */
- for (i = 0; i < dwarf2_per_objfile->n_comp_units; ++i)
+ for (int i = 0; i < dwarf2_per_objfile->n_comp_units; ++i)
{
int j;
- struct dwarf2_per_cu_data *per_cu = dw2_get_cutu (i);
+ struct dwarf2_per_cu_data *per_cu = dw2_get_cutu (dwarf2_per_objfile, i);
struct quick_file_names *file_data;
/* We only need to look at symtabs not already expanded. */
@@ -5288,14 +5334,14 @@ dw2_expand_symtabs_matching_one
static void
dw2_expand_marked_cus
- (mapped_index &index, offset_type idx,
- struct objfile *objfile,
+ (struct dwarf2_per_objfile *dwarf2_per_objfile, offset_type idx,
gdb::function_view<expand_symtabs_file_matcher_ftype> file_matcher,
gdb::function_view<expand_symtabs_exp_notify_ftype> expansion_notify,
search_domain kind)
{
offset_type *vec, vec_len, vec_idx;
bool global_seen = false;
+ mapped_index &index = *dwarf2_per_objfile->index_table;
vec = (offset_type *) (index.constant_pool
+ MAYBE_SWAP (index.symbol_table[idx].vec));
@@ -5354,11 +5400,12 @@ dw2_expand_marked_cus
{
complaint (&symfile_complaints,
_(".gdb_index entry has bad CU index"
- " [in module %s]"), objfile_name (objfile));
+ " [in module %s]"),
+ objfile_name (dwarf2_per_objfile->objfile));
continue;
}
- per_cu = dw2_get_cutu (cu_index);
+ per_cu = dw2_get_cutu (dwarf2_per_objfile, cu_index);
dw2_expand_symtabs_matching_one (per_cu, file_matcher,
expansion_notify);
}
@@ -5370,7 +5417,8 @@ dw2_expand_marked_cus
static void
dw_expand_symtabs_matching_file_matcher
- (gdb::function_view<expand_symtabs_file_matcher_ftype> file_matcher)
+ (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ gdb::function_view<expand_symtabs_file_matcher_ftype> file_matcher)
{
if (file_matcher == NULL)
return;
@@ -5390,7 +5438,7 @@ dw_expand_symtabs_matching_file_matcher
for (int i = 0; i < dwarf2_per_objfile->n_comp_units; ++i)
{
int j;
- struct dwarf2_per_cu_data *per_cu = dw2_get_cu (i);
+ struct dwarf2_per_cu_data *per_cu = dw2_get_cu (dwarf2_per_objfile, i);
struct quick_file_names *file_data;
void **slot;
@@ -5456,13 +5504,14 @@ dw2_expand_symtabs_matching
gdb::function_view<expand_symtabs_exp_notify_ftype> expansion_notify,
enum search_domain kind)
{
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
/* index_table is NULL if OBJF_READNOW. */
if (!dwarf2_per_objfile->index_table)
return;
- dw_expand_symtabs_matching_file_matcher (file_matcher);
+ dw_expand_symtabs_matching_file_matcher (dwarf2_per_objfile, file_matcher);
mapped_index &index = *dwarf2_per_objfile->index_table;
@@ -5470,7 +5519,7 @@ dw2_expand_symtabs_matching
symbol_matcher,
kind, [&] (offset_type idx)
{
- dw2_expand_marked_cus (index, idx, objfile, file_matcher,
+ dw2_expand_marked_cus (dwarf2_per_objfile, idx, file_matcher,
expansion_notify, kind);
});
}
@@ -5513,8 +5562,6 @@ dw2_find_pc_sect_compunit_symtab (struct objfile *objfile,
struct dwarf2_per_cu_data *data;
struct compunit_symtab *result;
- dw2_setup (objfile);
-
if (!objfile->psymtabs_addrmap)
return NULL;
@@ -5538,7 +5585,8 @@ static void
dw2_map_symbol_filenames (struct objfile *objfile, symbol_filename_ftype *fun,
void *data, int need_fullname)
{
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
if (!dwarf2_per_objfile->filenames_cache)
{
@@ -5554,7 +5602,7 @@ dw2_map_symbol_filenames (struct objfile *objfile, symbol_filename_ftype *fun,
for (int i = 0; i < dwarf2_per_objfile->n_comp_units; ++i)
{
- struct dwarf2_per_cu_data *per_cu = dw2_get_cutu (i);
+ dwarf2_per_cu_data *per_cu = dw2_get_cutu (dwarf2_per_objfile, i);
if (per_cu->v.quick->compunit_symtab)
{
@@ -5568,7 +5616,7 @@ dw2_map_symbol_filenames (struct objfile *objfile, symbol_filename_ftype *fun,
for (int i = 0; i < dwarf2_per_objfile->n_comp_units; ++i)
{
- struct dwarf2_per_cu_data *per_cu = dw2_get_cu (i);
+ dwarf2_per_cu_data *per_cu = dw2_get_cu (dwarf2_per_objfile, i);
struct quick_file_names *file_data;
void **slot;
@@ -5825,7 +5873,7 @@ read_debug_names_from_section (struct objfile *objfile,
list. */
static void
-create_cus_from_debug_names_list (struct objfile *objfile,
+create_cus_from_debug_names_list (struct dwarf2_per_objfile *dwarf2_per_objfile,
const mapped_debug_names &map,
dwarf2_section_info §ion,
bool is_dwz, int base_offset)
@@ -5848,7 +5896,7 @@ create_cus_from_debug_names_list (struct objfile *objfile,
{
const ULONGEST length = sect_off_next - sect_off_prev;
dwarf2_per_objfile->all_comp_units[base_offset + (i - 1)]
- = create_cu_from_index_list (objfile, §ion, is_dwz,
+ = create_cu_from_index_list (dwarf2_per_objfile, §ion, is_dwz,
sect_off_prev, length);
}
sect_off_prev = sect_off_next;
@@ -5856,28 +5904,30 @@ create_cus_from_debug_names_list (struct objfile *objfile,
}
/* Read the CU list from the mapped index, and use it to create all
- the CU objects for this objfile. */
+ the CU objects for this dwarf2_per_objfile. */
static void
-create_cus_from_debug_names (struct objfile *objfile,
+create_cus_from_debug_names (struct dwarf2_per_objfile *dwarf2_per_objfile,
const mapped_debug_names &map,
const mapped_debug_names &dwz_map)
{
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
dwarf2_per_objfile->n_comp_units = map.cu_count + dwz_map.cu_count;
dwarf2_per_objfile->all_comp_units
= XOBNEWVEC (&objfile->objfile_obstack, struct dwarf2_per_cu_data *,
dwarf2_per_objfile->n_comp_units);
- create_cus_from_debug_names_list (objfile, map, dwarf2_per_objfile->info,
+ create_cus_from_debug_names_list (dwarf2_per_objfile, map,
+ dwarf2_per_objfile->info,
false /* is_dwz */,
0 /* base_offset */);
if (dwz_map.cu_count == 0)
return;
- dwz_file *dwz = dwarf2_get_dwz_file ();
- create_cus_from_debug_names_list (objfile, dwz_map, dwz->info,
+ dwz_file *dwz = dwarf2_get_dwz_file (dwarf2_per_objfile);
+ create_cus_from_debug_names_list (dwarf2_per_objfile, dwz_map, dwz->info,
true /* is_dwz */,
map.cu_count /* base_offset */);
}
@@ -5886,9 +5936,11 @@ create_cus_from_debug_names (struct objfile *objfile,
elements of all the CUs and return true. Otherwise, return false. */
static bool
-dwarf2_read_debug_names (struct objfile *objfile)
+dwarf2_read_debug_names (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
- mapped_debug_names local_map, dwz_map;
+ mapped_debug_names local_map (dwarf2_per_objfile);
+ mapped_debug_names dwz_map (dwarf2_per_objfile);
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
if (!read_debug_names_from_section (objfile, objfile_name (objfile),
&dwarf2_per_objfile->debug_names,
@@ -5901,7 +5953,7 @@ dwarf2_read_debug_names (struct objfile *objfile)
/* If there is a .dwz file, read it so we can get its CU list as
well. */
- dwz_file *dwz = dwarf2_get_dwz_file ();
+ dwz_file *dwz = dwarf2_get_dwz_file (dwarf2_per_objfile);
if (dwz != NULL)
{
if (!read_debug_names_from_section (objfile,
@@ -5914,7 +5966,7 @@ dwarf2_read_debug_names (struct objfile *objfile)
}
}
- create_cus_from_debug_names (objfile, local_map, dwz_map);
+ create_cus_from_debug_names (dwarf2_per_objfile, local_map, dwz_map);
if (local_map.tu_count != 0)
{
@@ -5927,12 +5979,14 @@ dwarf2_read_debug_names (struct objfile *objfile)
dwarf2_per_objfile->types, 0);
create_signatured_type_table_from_debug_names
- (objfile, local_map, section, &dwarf2_per_objfile->abbrev);
+ (dwarf2_per_objfile, local_map, section, &dwarf2_per_objfile->abbrev);
}
- create_addrmap_from_aranges (objfile, &dwarf2_per_objfile->debug_aranges);
+ create_addrmap_from_aranges (dwarf2_per_objfile,
+ &dwarf2_per_objfile->debug_aranges);
- dwarf2_per_objfile->debug_names_table.reset (new mapped_debug_names);
+ dwarf2_per_objfile->debug_names_table.reset
+ (new mapped_debug_names (dwarf2_per_objfile));
*dwarf2_per_objfile->debug_names_table = std::move (local_map);
dwarf2_per_objfile->using_index = 1;
dwarf2_per_objfile->quick_file_names_table =
@@ -6019,7 +6073,7 @@ mapped_debug_names::namei_to_name (uint32_t namei) const
offset_size,
dwarf5_byte_order);
return read_indirect_string_at_offset
- (dwarf2_per_objfile->objfile->obfd, namei_string_offs);
+ (dwarf2_per_objfile, dwarf2_per_objfile->objfile->obfd, namei_string_offs);
}
/* Find a slot in .debug_names for the object named NAME. If NAME is
@@ -6068,7 +6122,7 @@ dw2_debug_names_iterator::find_vec_in_debug_names
_("Wrong .debug_names with name index %u but name_count=%u "
"[in module %s]"),
namei, map.name_count,
- objfile_name (dwarf2_per_objfile->objfile));
+ objfile_name (map.dwarf2_per_objfile->objfile));
return NULL;
}
@@ -6122,7 +6176,7 @@ dw2_debug_names_iterator::find_vec_in_debug_names
_("Wrong .debug_names with name index %u but name_count=%u "
"[in module %s]"),
namei, map.name_count,
- objfile_name (dwarf2_per_objfile->objfile));
+ objfile_name (map.dwarf2_per_objfile->objfile));
return NULL;
}
@@ -6141,7 +6195,9 @@ dw2_debug_names_iterator::next ()
if (m_addr == NULL)
return NULL;
- bfd *const abfd = dwarf2_per_objfile->objfile->obfd;
+ struct dwarf2_per_objfile *dwarf2_per_objfile = m_map.dwarf2_per_objfile;
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
+ bfd *const abfd = objfile->obfd;
again:
@@ -6157,7 +6213,7 @@ dw2_debug_names_iterator::next ()
complaint (&symfile_complaints,
_("Wrong .debug_names undefined abbrev code %s "
"[in module %s]"),
- pulongest (abbrev), objfile_name (dwarf2_per_objfile->objfile));
+ pulongest (abbrev), objfile_name (objfile));
return NULL;
}
const mapped_debug_names::index_val &indexval = indexval_it->second;
@@ -6183,7 +6239,7 @@ dw2_debug_names_iterator::next ()
complaint (&symfile_complaints,
_("Unsupported .debug_names form %s [in module %s]"),
dwarf_form_name (attr.form),
- objfile_name (dwarf2_per_objfile->objfile));
+ objfile_name (objfile));
return NULL;
}
switch (attr.dw_idx)
@@ -6199,7 +6255,7 @@ dw2_debug_names_iterator::next ()
objfile_name (dwarf2_per_objfile->objfile));
continue;
}
- per_cu = dw2_get_cutu (ull);
+ per_cu = dw2_get_cutu (dwarf2_per_objfile, ull);
break;
case DW_IDX_type_unit:
/* Don't crash on bad data. */
@@ -6212,7 +6268,8 @@ dw2_debug_names_iterator::next ()
objfile_name (dwarf2_per_objfile->objfile));
continue;
}
- per_cu = dw2_get_cutu (dwarf2_per_objfile->n_comp_units + ull);
+ per_cu = dw2_get_cutu (dwarf2_per_objfile,
+ dwarf2_per_objfile->n_comp_units + ull);
break;
case DW_IDX_GNU_internal:
if (!m_map.augmentation_is_gdb)
@@ -6326,7 +6383,8 @@ dw2_debug_names_lookup_symbol (struct objfile *objfile, int block_index_int,
const char *name, domain_enum domain)
{
const block_enum block_index = static_cast<block_enum> (block_index_int);
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
const auto &mapp = dwarf2_per_objfile->debug_names_table;
if (!mapp)
@@ -6376,7 +6434,9 @@ dw2_debug_names_lookup_symbol (struct objfile *objfile, int block_index_int,
static void
dw2_debug_names_dump (struct objfile *objfile)
{
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
+
gdb_assert (dwarf2_per_objfile->using_index);
printf_filtered (".debug_names:");
if (dwarf2_per_objfile->debug_names_table)
@@ -6390,7 +6450,8 @@ static void
dw2_debug_names_expand_symtabs_for_function (struct objfile *objfile,
const char *func_name)
{
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
/* dwarf2_per_objfile->debug_names_table is NULL if OBJF_READNOW. */
if (dwarf2_per_objfile->debug_names_table)
@@ -6416,13 +6477,14 @@ dw2_debug_names_expand_symtabs_matching
gdb::function_view<expand_symtabs_exp_notify_ftype> expansion_notify,
enum search_domain kind)
{
- dw2_setup (objfile);
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
/* debug_names_table is NULL if OBJF_READNOW. */
if (!dwarf2_per_objfile->debug_names_table)
return;
- dw_expand_symtabs_matching_file_matcher (file_matcher);
+ dw_expand_symtabs_matching_file_matcher (dwarf2_per_objfile, file_matcher);
mapped_debug_names &map = *dwarf2_per_objfile->debug_names_table;
@@ -6466,6 +6528,9 @@ const struct quick_symbol_functions dwarf2_debug_names_functions =
bool
dwarf2_initialize_objfile (struct objfile *objfile, dw_index_kind *index_kind)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
+
/* If we're about to read full symbols, don't bother with the
indices. In this case we also don't care if some other debug
format is making psymtabs, because they are all about to be
@@ -6475,15 +6540,15 @@ dwarf2_initialize_objfile (struct objfile *objfile, dw_index_kind *index_kind)
int i;
dwarf2_per_objfile->using_index = 1;
- create_all_comp_units (objfile);
- create_all_type_units (objfile);
+ create_all_comp_units (dwarf2_per_objfile);
+ create_all_type_units (dwarf2_per_objfile);
dwarf2_per_objfile->quick_file_names_table =
create_quick_file_names_table (dwarf2_per_objfile->n_comp_units);
for (i = 0; i < (dwarf2_per_objfile->n_comp_units
+ dwarf2_per_objfile->n_type_units); ++i)
{
- struct dwarf2_per_cu_data *per_cu = dw2_get_cutu (i);
+ dwarf2_per_cu_data *per_cu = dw2_get_cutu (dwarf2_per_objfile, i);
per_cu->v.quick = OBSTACK_ZALLOC (&objfile->objfile_obstack,
struct dwarf2_per_cu_quick_data);
@@ -6496,7 +6561,7 @@ dwarf2_initialize_objfile (struct objfile *objfile, dw_index_kind *index_kind)
return true;
}
- if (dwarf2_read_debug_names (objfile))
+ if (dwarf2_read_debug_names (dwarf2_per_objfile))
{
*index_kind = dw_index_kind::DEBUG_NAMES;
return true;
@@ -6518,6 +6583,8 @@ dwarf2_initialize_objfile (struct objfile *objfile, dw_index_kind *index_kind)
void
dwarf2_build_psymtabs (struct objfile *objfile)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
if (objfile->global_psymbols.capacity () == 0
&& objfile->static_psymbols.capacity () == 0)
@@ -6529,7 +6596,7 @@ dwarf2_build_psymtabs (struct objfile *objfile)
objfile's obstack is still uselessly kept around. However,
freeing it seems unsafe. */
psymtab_discarder psymtabs (objfile);
- dwarf2_build_psymtabs_hard (objfile);
+ dwarf2_build_psymtabs_hard (dwarf2_per_objfile);
psymtabs.keep ();
}
CATCH (except, RETURN_MASK_ERROR)
@@ -6690,9 +6757,10 @@ static struct dwarf2_section_info *
get_abbrev_section_for_cu (struct dwarf2_per_cu_data *this_cu)
{
struct dwarf2_section_info *abbrev;
+ struct dwarf2_per_objfile *dwarf2_per_objfile = this_cu->dwarf2_per_objfile;
if (this_cu->is_dwz)
- abbrev = &dwarf2_get_dwz_file ()->abbrev;
+ abbrev = &dwarf2_get_dwz_file (dwarf2_per_objfile)->abbrev;
else
abbrev = &dwarf2_per_objfile->abbrev;
@@ -6704,7 +6772,8 @@ get_abbrev_section_for_cu (struct dwarf2_per_cu_data *this_cu)
Perform various error checking on the header. */
static void
-error_check_comp_unit_head (struct comp_unit_head *header,
+error_check_comp_unit_head (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct comp_unit_head *header,
struct dwarf2_section_info *section,
struct dwarf2_section_info *abbrev_section)
{
@@ -6738,7 +6807,8 @@ error_check_comp_unit_head (struct comp_unit_head *header,
The result is a pointer to the start of the first DIE. */
static const gdb_byte *
-read_and_check_comp_unit_head (struct comp_unit_head *header,
+read_and_check_comp_unit_head (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct comp_unit_head *header,
struct dwarf2_section_info *section,
struct dwarf2_section_info *abbrev_section,
const gdb_byte *info_ptr,
@@ -6752,7 +6822,8 @@ read_and_check_comp_unit_head (struct comp_unit_head *header,
header->first_die_cu_offset = (cu_offset) (info_ptr - beg_of_comp_unit);
- error_check_comp_unit_head (header, section, abbrev_section);
+ error_check_comp_unit_head (dwarf2_per_objfile, header, section,
+ abbrev_section);
return info_ptr;
}
@@ -6760,7 +6831,8 @@ read_and_check_comp_unit_head (struct comp_unit_head *header,
/* Fetch the abbreviation table offset from a comp or type unit header. */
static sect_offset
-read_abbrev_offset (struct dwarf2_section_info *section,
+read_abbrev_offset (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct dwarf2_section_info *section,
sect_offset sect_off)
{
bfd *abfd = get_section_bfd_owner (section);
@@ -6896,7 +6968,8 @@ add_signatured_type_cu_to_table (void **slot, void *datum)
therefore DW_UT_type. */
static void
-create_debug_type_hash_table (struct dwo_file *dwo_file,
+create_debug_type_hash_table (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct dwo_file *dwo_file,
dwarf2_section_info *section, htab_t &types_htab,
rcuh_kind section_kind)
{
@@ -6947,7 +7020,7 @@ create_debug_type_hash_table (struct dwo_file *dwo_file,
/* We need to read the type's signature in order to build the hash
table, but we don't need anything else just yet. */
- ptr = read_and_check_comp_unit_head (&header, section,
+ ptr = read_and_check_comp_unit_head (dwarf2_per_objfile, &header, section,
abbrev_section, ptr, section_kind);
length = get_cu_length (&header);
@@ -7047,7 +7120,8 @@ create_debug_type_hash_table (struct dwo_file *dwo_file,
Note: This function processes DWO files only, not DWP files. */
static void
-create_debug_types_hash_table (struct dwo_file *dwo_file,
+create_debug_types_hash_table (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct dwo_file *dwo_file,
VEC (dwarf2_section_info_def) *types,
htab_t &types_htab)
{
@@ -7060,8 +7134,8 @@ create_debug_types_hash_table (struct dwo_file *dwo_file,
for (ix = 0;
VEC_iterate (dwarf2_section_info_def, types, ix, section);
++ix)
- create_debug_type_hash_table (dwo_file, section, types_htab,
- rcuh_kind::TYPE);
+ create_debug_type_hash_table (dwarf2_per_objfile, dwo_file, section,
+ types_htab, rcuh_kind::TYPE);
}
/* Create the hash table of all entries in the .debug_types section,
@@ -7070,14 +7144,16 @@ create_debug_types_hash_table (struct dwo_file *dwo_file,
otherwise non-zero. */
static int
-create_all_type_units (struct objfile *objfile)
+create_all_type_units (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
htab_t types_htab = NULL;
struct signatured_type **iter;
- create_debug_type_hash_table (NULL, &dwarf2_per_objfile->info, types_htab,
+ create_debug_type_hash_table (dwarf2_per_objfile, NULL,
+ &dwarf2_per_objfile->info, types_htab,
rcuh_kind::COMPILE);
- create_debug_types_hash_table (NULL, dwarf2_per_objfile->types, types_htab);
+ create_debug_types_hash_table (dwarf2_per_objfile, NULL,
+ dwarf2_per_objfile->types, types_htab);
if (types_htab == NULL)
{
dwarf2_per_objfile->signatured_types = NULL;
@@ -7104,7 +7180,8 @@ create_all_type_units (struct objfile *objfile)
Otherwise we find one. */
static struct signatured_type *
-add_type_unit (ULONGEST sig, void **slot)
+add_type_unit (struct dwarf2_per_objfile *dwarf2_per_objfile, ULONGEST sig,
+ void **slot)
{
struct objfile *objfile = dwarf2_per_objfile->objfile;
int n_type_units = dwarf2_per_objfile->n_type_units;
@@ -7152,7 +7229,7 @@ add_type_unit (ULONGEST sig, void **slot)
Fill in SIG_ENTRY with DWO_ENTRY. */
static void
-fill_in_sig_entry_from_dwo_entry (struct objfile *objfile,
+fill_in_sig_entry_from_dwo_entry (struct dwarf2_per_objfile *dwarf2_per_objfile,
struct signatured_type *sig_entry,
struct dwo_unit *dwo_entry)
{
@@ -7195,6 +7272,7 @@ fill_in_sig_entry_from_dwo_entry (struct objfile *objfile,
static struct signatured_type *
lookup_dwo_signatured_type (struct dwarf2_cu *cu, ULONGEST sig)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = cu->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct dwo_file *dwo_file;
struct dwo_unit find_dwo_entry, *dwo_entry;
@@ -7248,9 +7326,9 @@ lookup_dwo_signatured_type (struct dwarf2_cu *cu, ULONGEST sig)
/* If the global table doesn't have an entry for this TU, add one. */
if (sig_entry == NULL)
- sig_entry = add_type_unit (sig, slot);
+ sig_entry = add_type_unit (dwarf2_per_objfile, sig, slot);
- fill_in_sig_entry_from_dwo_entry (objfile, sig_entry, dwo_entry);
+ fill_in_sig_entry_from_dwo_entry (dwarf2_per_objfile, sig_entry, dwo_entry);
sig_entry->per_cu.tu_read = 1;
return sig_entry;
}
@@ -7263,8 +7341,9 @@ lookup_dwo_signatured_type (struct dwarf2_cu *cu, ULONGEST sig)
static struct signatured_type *
lookup_dwp_signatured_type (struct dwarf2_cu *cu, ULONGEST sig)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = cu->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
- struct dwp_file *dwp_file = get_dwp_file ();
+ struct dwp_file *dwp_file = get_dwp_file (dwarf2_per_objfile);
struct dwo_unit *dwo_entry;
struct signatured_type find_sig_entry, *sig_entry;
void **slot;
@@ -7293,13 +7372,13 @@ lookup_dwp_signatured_type (struct dwarf2_cu *cu, ULONGEST sig)
if (dwp_file->tus == NULL)
return NULL;
- dwo_entry = lookup_dwo_unit_in_dwp (dwp_file, NULL,
+ dwo_entry = lookup_dwo_unit_in_dwp (dwarf2_per_objfile, dwp_file, NULL,
sig, 1 /* is_debug_types */);
if (dwo_entry == NULL)
return NULL;
- sig_entry = add_type_unit (sig, slot);
- fill_in_sig_entry_from_dwo_entry (objfile, sig_entry, dwo_entry);
+ sig_entry = add_type_unit (dwarf2_per_objfile, sig, slot);
+ fill_in_sig_entry_from_dwo_entry (dwarf2_per_objfile, sig_entry, dwo_entry);
return sig_entry;
}
@@ -7311,12 +7390,14 @@ lookup_dwp_signatured_type (struct dwarf2_cu *cu, ULONGEST sig)
static struct signatured_type *
lookup_signatured_type (struct dwarf2_cu *cu, ULONGEST sig)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = cu->dwarf2_per_objfile;
+
if (cu->dwo_unit
&& dwarf2_per_objfile->using_index)
{
/* We're in a DWO/DWP file, and we're using .gdb_index.
These cases require special processing. */
- if (get_dwp_file () == NULL)
+ if (get_dwp_file (dwarf2_per_objfile) == NULL)
return lookup_dwo_signatured_type (cu, sig);
else
return lookup_dwp_signatured_type (cu, sig);
@@ -7382,6 +7463,7 @@ read_cutu_die_from_dwo (struct dwarf2_per_cu_data *this_cu,
struct die_info **result_comp_unit_die,
int *result_has_children)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = this_cu->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct dwarf2_cu *cu = this_cu->cu;
struct dwarf2_section_info *section;
@@ -7459,7 +7541,8 @@ read_cutu_die_from_dwo (struct dwarf2_per_cu_data *this_cu,
{
struct signatured_type *sig_type = (struct signatured_type *) this_cu;
- info_ptr = read_and_check_comp_unit_head (&cu->header, section,
+ info_ptr = read_and_check_comp_unit_head (dwarf2_per_objfile,
+ &cu->header, section,
dwo_abbrev_section,
info_ptr, rcuh_kind::TYPE);
/* This is not an assert because it can be caused by bad debug info. */
@@ -7485,7 +7568,8 @@ read_cutu_die_from_dwo (struct dwarf2_per_cu_data *this_cu,
}
else
{
- info_ptr = read_and_check_comp_unit_head (&cu->header, section,
+ info_ptr = read_and_check_comp_unit_head (dwarf2_per_objfile,
+ &cu->header, section,
dwo_abbrev_section,
info_ptr, rcuh_kind::COMPILE);
gdb_assert (dwo_unit->sect_off == cu->header.sect_off);
@@ -7632,6 +7716,7 @@ init_tu_and_read_dwo_dies (struct dwarf2_per_cu_data *this_cu,
const gdb_byte *info_ptr;
struct die_info *comp_unit_die;
int has_children;
+ struct dwarf2_per_objfile *dwarf2_per_objfile = this_cu->dwarf2_per_objfile;
/* Verify we can do the following downcast, and that we have the
data we need. */
@@ -7727,6 +7812,7 @@ init_cutu_and_read_dies (struct dwarf2_per_cu_data *this_cu,
die_reader_func_ftype *die_reader_func,
void *data)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = this_cu->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct dwarf2_section_info *section = this_cu->section;
bfd *abfd = get_section_bfd_owner (section);
@@ -7805,7 +7891,8 @@ init_cutu_and_read_dies (struct dwarf2_per_cu_data *this_cu,
{
if (this_cu->is_debug_types)
{
- info_ptr = read_and_check_comp_unit_head (&cu->header, section,
+ info_ptr = read_and_check_comp_unit_head (dwarf2_per_objfile,
+ &cu->header, section,
abbrev_section, info_ptr,
rcuh_kind::TYPE);
@@ -7829,7 +7916,8 @@ init_cutu_and_read_dies (struct dwarf2_per_cu_data *this_cu,
}
else
{
- info_ptr = read_and_check_comp_unit_head (&cu->header, section,
+ info_ptr = read_and_check_comp_unit_head (dwarf2_per_objfile,
+ &cu->header, section,
abbrev_section,
info_ptr,
rcuh_kind::COMPILE);
@@ -7965,6 +8053,7 @@ init_cutu_and_read_dies_no_follow (struct dwarf2_per_cu_data *this_cu,
die_reader_func_ftype *die_reader_func,
void *data)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = this_cu->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct dwarf2_section_info *section = this_cu->section;
bfd *abfd = get_section_bfd_owner (section);
@@ -7995,7 +8084,8 @@ init_cutu_and_read_dies_no_follow (struct dwarf2_per_cu_data *this_cu,
cleanups = make_cleanup (free_stack_comp_unit, &cu);
begin_info_ptr = info_ptr = section->buffer + to_underlying (this_cu->sect_off);
- info_ptr = read_and_check_comp_unit_head (&cu.header, section,
+ info_ptr = read_and_check_comp_unit_head (dwarf2_per_objfile,
+ &cu.header, section,
abbrev_section, info_ptr,
(this_cu->is_debug_types
? rcuh_kind::TYPE
@@ -8068,13 +8158,13 @@ eq_type_unit_group (const void *item_lhs, const void *item_rhs)
/* Allocate a hash table for type unit groups. */
static htab_t
-allocate_type_unit_groups_table (void)
+allocate_type_unit_groups_table (struct objfile *objfile)
{
return htab_create_alloc_ex (3,
hash_type_unit_group,
eq_type_unit_group,
NULL,
- &dwarf2_per_objfile->objfile->objfile_obstack,
+ &objfile->objfile_obstack,
hashtab_obstack_allocate,
dummy_obstack_deallocate);
}
@@ -8091,6 +8181,7 @@ allocate_type_unit_groups_table (void)
static struct type_unit_group *
create_type_unit_group (struct dwarf2_cu *cu, sect_offset line_offset_struct)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = cu->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct dwarf2_per_cu_data *per_cu;
struct type_unit_group *tu_group;
@@ -8136,6 +8227,7 @@ create_type_unit_group (struct dwarf2_cu *cu, sect_offset line_offset_struct)
static struct type_unit_group *
get_type_unit_group (struct dwarf2_cu *cu, const struct attribute *stmt_list)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = cu->dwarf2_per_objfile;
struct tu_stats *tu_stats = &dwarf2_per_objfile->tu_stats;
struct type_unit_group *tu_group;
void **slot;
@@ -8145,7 +8237,7 @@ get_type_unit_group (struct dwarf2_cu *cu, const struct attribute *stmt_list)
if (dwarf2_per_objfile->type_unit_groups == NULL)
{
dwarf2_per_objfile->type_unit_groups =
- allocate_type_unit_groups_table ();
+ allocate_type_unit_groups_table (dwarf2_per_objfile->objfile);
}
/* Do we need to create a new group, or can we use an existing one? */
@@ -8390,7 +8482,7 @@ process_psymtab_comp_unit (struct dwarf2_per_cu_data *this_cu,
}
/* Age out any secondary CUs. */
- age_cached_comp_units ();
+ age_cached_comp_units (this_cu->dwarf2_per_objfile);
}
/* Reader function for build_type_psymtabs. */
@@ -8402,6 +8494,8 @@ build_type_psymtabs_reader (const struct die_reader_specs *reader,
int has_children,
void *data)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = reader->cu->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct dwarf2_cu *cu = reader->cu;
struct dwarf2_per_cu_data *per_cu = cu->per_cu;
@@ -8480,7 +8574,7 @@ sort_tu_by_abbrev_offset (const void *ap, const void *bp)
dwarf2_per_objfile->type_unit_groups. */
static void
-build_type_psymtabs_1 (void)
+build_type_psymtabs_1 (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
struct tu_stats *tu_stats = &dwarf2_per_objfile->tu_stats;
struct cleanup *cleanups;
@@ -8527,7 +8621,8 @@ build_type_psymtabs_1 (void)
sorted_by_abbrev[i].sig_type = sig_type;
sorted_by_abbrev[i].abbrev_offset =
- read_abbrev_offset (sig_type->per_cu.section,
+ read_abbrev_offset (dwarf2_per_objfile,
+ sig_type->per_cu.section,
sig_type->per_cu.sect_off);
}
cleanups = make_cleanup (xfree, sorted_by_abbrev);
@@ -8555,7 +8650,8 @@ build_type_psymtabs_1 (void)
}
abbrev_offset = tu->abbrev_offset;
abbrev_table =
- abbrev_table_read_table (&dwarf2_per_objfile->abbrev,
+ abbrev_table_read_table (dwarf2_per_objfile,
+ &dwarf2_per_objfile->abbrev,
abbrev_offset);
++tu_stats->nr_uniq_abbrev_tables;
}
@@ -8570,7 +8666,7 @@ build_type_psymtabs_1 (void)
/* Print collected type unit statistics. */
static void
-print_tu_stats (void)
+print_tu_stats (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
struct tu_stats *tu_stats = &dwarf2_per_objfile->tu_stats;
@@ -8594,6 +8690,8 @@ print_tu_stats (void)
static int
build_type_psymtab_dependencies (void **slot, void *info)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = (struct dwarf2_per_objfile *) info;
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct type_unit_group *tu_group = (struct type_unit_group *) *slot;
struct dwarf2_per_cu_data *per_cu = &tu_group->per_cu;
@@ -8626,12 +8724,12 @@ build_type_psymtab_dependencies (void **slot, void *info)
Build partial symbol tables for the .debug_types comp-units. */
static void
-build_type_psymtabs (struct objfile *objfile)
+build_type_psymtabs (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
- if (! create_all_type_units (objfile))
+ if (! create_all_type_units (dwarf2_per_objfile))
return;
- build_type_psymtabs_1 ();
+ build_type_psymtabs_1 (dwarf2_per_objfile);
}
/* Traversal function for process_skeletonless_type_unit.
@@ -8641,7 +8739,8 @@ static int
process_skeletonless_type_unit (void **slot, void *info)
{
struct dwo_unit *dwo_unit = (struct dwo_unit *) *slot;
- struct objfile *objfile = (struct objfile *) info;
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = (struct dwarf2_per_objfile *) info;
struct signatured_type find_entry, *entry;
/* If this TU doesn't exist in the global table, add it and read it in. */
@@ -8649,7 +8748,7 @@ process_skeletonless_type_unit (void **slot, void *info)
if (dwarf2_per_objfile->signatured_types == NULL)
{
dwarf2_per_objfile->signatured_types
- = allocate_signatured_type_table (objfile);
+ = allocate_signatured_type_table (dwarf2_per_objfile->objfile);
}
find_entry.signature = dwo_unit->signature;
@@ -8662,8 +8761,8 @@ process_skeletonless_type_unit (void **slot, void *info)
/* This does the job that create_all_type_units would have done for
this TU. */
- entry = add_type_unit (dwo_unit->signature, slot);
- fill_in_sig_entry_from_dwo_entry (objfile, entry, dwo_unit);
+ entry = add_type_unit (dwarf2_per_objfile, dwo_unit->signature, slot);
+ fill_in_sig_entry_from_dwo_entry (dwarf2_per_objfile, entry, dwo_unit);
*slot = entry;
/* This does the job that build_type_psymtabs_1 would have done. */
@@ -8694,28 +8793,28 @@ process_dwo_file_for_skeletonless_type_units (void **slot, void *info)
Note: This can't be done until we know what all the DWO files are. */
static void
-process_skeletonless_type_units (struct objfile *objfile)
+process_skeletonless_type_units (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
/* Skeletonless TUs in DWP files without .gdb_index is not supported yet. */
- if (get_dwp_file () == NULL
+ if (get_dwp_file (dwarf2_per_objfile) == NULL
&& dwarf2_per_objfile->dwo_files != NULL)
{
htab_traverse_noresize (dwarf2_per_objfile->dwo_files,
process_dwo_file_for_skeletonless_type_units,
- objfile);
+ dwarf2_per_objfile);
}
}
-/* Compute the 'user' field for each psymtab in OBJFILE. */
+/* Compute the 'user' field for each psymtab in DWARF2_PER_OBJFILE. */
static void
-set_partial_user (struct objfile *objfile)
+set_partial_user (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
int i;
for (i = 0; i < dwarf2_per_objfile->n_comp_units; ++i)
{
- struct dwarf2_per_cu_data *per_cu = dw2_get_cutu (i);
+ struct dwarf2_per_cu_data *per_cu = dw2_get_cutu (dwarf2_per_objfile, i);
struct partial_symtab *pst = per_cu->v.psymtab;
int j;
@@ -8735,10 +8834,11 @@ set_partial_user (struct objfile *objfile)
.debug_info and .debug_abbrev sections. */
static void
-dwarf2_build_psymtabs_hard (struct objfile *objfile)
+dwarf2_build_psymtabs_hard (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
struct cleanup *back_to;
int i;
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
if (dwarf_read_debug)
{
@@ -8752,11 +8852,11 @@ dwarf2_build_psymtabs_hard (struct objfile *objfile)
/* Any cached compilation units will be linked by the per-objfile
read_in_chain. Make sure to free them when we're done. */
- back_to = make_cleanup (free_cached_comp_units, NULL);
+ back_to = make_cleanup (free_cached_comp_units, dwarf2_per_objfile);
- build_type_psymtabs (objfile);
+ build_type_psymtabs (dwarf2_per_objfile);
- create_all_comp_units (objfile);
+ create_all_comp_units (dwarf2_per_objfile);
/* Create a temporary address map on a temporary obstack. We later
copy this to the final obstack. */
@@ -8768,25 +8868,25 @@ dwarf2_build_psymtabs_hard (struct objfile *objfile)
for (i = 0; i < dwarf2_per_objfile->n_comp_units; ++i)
{
- struct dwarf2_per_cu_data *per_cu = dw2_get_cutu (i);
+ struct dwarf2_per_cu_data *per_cu = dw2_get_cutu (dwarf2_per_objfile, i);
process_psymtab_comp_unit (per_cu, 0, language_minimal);
}
/* This has to wait until we read the CUs, we need the list of DWOs. */
- process_skeletonless_type_units (objfile);
+ process_skeletonless_type_units (dwarf2_per_objfile);
/* Now that all TUs have been processed we can fill in the dependencies. */
if (dwarf2_per_objfile->type_unit_groups != NULL)
{
htab_traverse_noresize (dwarf2_per_objfile->type_unit_groups,
- build_type_psymtab_dependencies, NULL);
+ build_type_psymtab_dependencies, dwarf2_per_objfile);
}
if (dwarf_read_debug)
- print_tu_stats ();
+ print_tu_stats (dwarf2_per_objfile);
- set_partial_user (objfile);
+ set_partial_user (dwarf2_per_objfile);
objfile->psymtabs_addrmap = addrmap_create_fixed (objfile->psymtabs_addrmap,
&objfile->objfile_obstack);
@@ -8831,7 +8931,7 @@ load_partial_comp_unit (struct dwarf2_per_cu_data *this_cu)
}
static void
-read_comp_units_from_section (struct objfile *objfile,
+read_comp_units_from_section (struct dwarf2_per_objfile *dwarf2_per_objfile,
struct dwarf2_section_info *section,
struct dwarf2_section_info *abbrev_section,
unsigned int is_dwz,
@@ -8840,6 +8940,7 @@ read_comp_units_from_section (struct objfile *objfile,
struct dwarf2_per_cu_data ***all_comp_units)
{
const gdb_byte *info_ptr;
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
if (dwarf_read_debug)
fprintf_unfiltered (gdb_stdlog, "Reading %s for %s\n",
@@ -8857,8 +8958,9 @@ read_comp_units_from_section (struct objfile *objfile,
sect_offset sect_off = (sect_offset) (info_ptr - section->buffer);
comp_unit_head cu_header;
- read_and_check_comp_unit_head (&cu_header, section, abbrev_section,
- info_ptr, rcuh_kind::COMPILE);
+ read_and_check_comp_unit_head (dwarf2_per_objfile, &cu_header, section,
+ abbrev_section, info_ptr,
+ rcuh_kind::COMPILE);
/* Save the compilation unit for later lookup. */
if (cu_header.unit_type != DW_UT_type)
@@ -8900,25 +9002,26 @@ read_comp_units_from_section (struct objfile *objfile,
This is only done for -readnow and building partial symtabs. */
static void
-create_all_comp_units (struct objfile *objfile)
+create_all_comp_units (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
int n_allocated;
int n_comp_units;
struct dwarf2_per_cu_data **all_comp_units;
struct dwz_file *dwz;
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
n_comp_units = 0;
n_allocated = 10;
all_comp_units = XNEWVEC (struct dwarf2_per_cu_data *, n_allocated);
- read_comp_units_from_section (objfile, &dwarf2_per_objfile->info,
+ read_comp_units_from_section (dwarf2_per_objfile, &dwarf2_per_objfile->info,
&dwarf2_per_objfile->abbrev, 0,
&n_allocated, &n_comp_units, &all_comp_units);
- dwz = dwarf2_get_dwz_file ();
+ dwz = dwarf2_get_dwz_file (dwarf2_per_objfile);
if (dwz != NULL)
- read_comp_units_from_section (objfile, &dwz->info, &dwz->abbrev, 1,
- &n_allocated, &n_comp_units,
+ read_comp_units_from_section (dwarf2_per_objfile, &dwz->info, &dwz->abbrev,
+ 1, &n_allocated, &n_comp_units,
&all_comp_units);
dwarf2_per_objfile->all_comp_units = XOBNEWVEC (&objfile->objfile_obstack,
@@ -9016,7 +9119,7 @@ scan_partial_symbols (struct partial_die_info *first_die, CORE_ADDR *lowpc,
per_cu = dwarf2_find_containing_comp_unit
(pdi->d.sect_off, pdi->is_dwz,
- cu->dwarf2_per_objfile->objfile);
+ cu->dwarf2_per_objfile);
/* Go read the partial unit, if needed. */
if (per_cu->v.psymtab == NULL)
@@ -9178,7 +9281,8 @@ partial_die_full_name (struct partial_die_info *pdi,
static void
add_partial_symbol (struct partial_die_info *pdi, struct dwarf2_cu *cu)
{
- struct objfile *objfile = cu->dwarf2_per_objfile->objfile;
+ struct dwarf2_per_objfile *dwarf2_per_objfile = cu->dwarf2_per_objfile;
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
struct gdbarch *gdbarch = get_objfile_arch (objfile);
CORE_ADDR addr = 0;
const char *actual_name = NULL;
@@ -9714,6 +9818,9 @@ static void
dwarf2_read_symtab (struct partial_symtab *self,
struct objfile *objfile)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = get_dwarf2_per_objfile (objfile);
+
if (self->readin)
{
warning (_("bug: psymtab for %s is already read in."),
@@ -9728,11 +9835,6 @@ dwarf2_read_symtab (struct partial_symtab *self,
gdb_flush (gdb_stdout);
}
- /* Restore our global data. */
- dwarf2_per_objfile
- = (struct dwarf2_per_objfile *) objfile_data (objfile,
- dwarf2_objfile_data_key);
-
/* If this psymtab is constructed from a debug-only objfile, the
has_section_at_zero flag will not necessarily be correct. We
can get the correct value for this flag by looking at the data
@@ -9740,9 +9842,7 @@ dwarf2_read_symtab (struct partial_symtab *self,
if (objfile->separate_debug_objfile_backlink)
{
struct dwarf2_per_objfile *dpo_backlink
- = ((struct dwarf2_per_objfile *)
- objfile_data (objfile->separate_debug_objfile_backlink,
- dwarf2_objfile_data_key));
+ = get_dwarf2_per_objfile (objfile->separate_debug_objfile_backlink);
dwarf2_per_objfile->has_section_at_zero
= dpo_backlink->has_section_at_zero;
@@ -9757,7 +9857,7 @@ dwarf2_read_symtab (struct partial_symtab *self,
printf_filtered (_("done.\n"));
}
- process_cu_includes ();
+ process_cu_includes (dwarf2_per_objfile);
}
/* Reading in full CUs. */
@@ -9801,7 +9901,7 @@ maybe_queue_comp_unit (struct dwarf2_cu *dependent_cu,
/* We may arrive here during partial symbol reading, if we need full
DIEs to process an unusual case (e.g. template arguments). Do
not queue PER_CU, just tell our caller to load its DIEs. */
- if (dwarf2_per_objfile->reading_partial_symbols)
+ if (per_cu->dwarf2_per_objfile->reading_partial_symbols)
{
if (per_cu->cu == NULL || per_cu->cu->dies == NULL)
return 1;
@@ -9834,7 +9934,7 @@ maybe_queue_comp_unit (struct dwarf2_cu *dependent_cu,
/* Process the queue. */
static void
-process_queue (void)
+process_queue (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
struct dwarf2_queue_item *item, *next_item;
@@ -10229,7 +10329,7 @@ fixup_go_packaging (struct dwarf2_cu *cu)
static struct compunit_symtab *
get_compunit_symtab (struct dwarf2_per_cu_data *per_cu)
{
- return (dwarf2_per_objfile->using_index
+ return (per_cu->dwarf2_per_objfile->using_index
? per_cu->v.quick->compunit_symtab
: per_cu->v.psymtab->compunit_symtab);
}
@@ -10329,7 +10429,7 @@ compute_compunit_symtab_includes (struct dwarf2_per_cu_data *per_cu)
/* Now we have a transitive closure of all the included symtabs. */
len = VEC_length (compunit_symtab_ptr, result_symtabs);
cust->includes
- = XOBNEWVEC (&dwarf2_per_objfile->objfile->objfile_obstack,
+ = XOBNEWVEC (&per_cu->dwarf2_per_objfile->objfile->objfile_obstack,
struct compunit_symtab *, len + 1);
for (ix = 0;
VEC_iterate (compunit_symtab_ptr, result_symtabs, ix,
@@ -10348,7 +10448,7 @@ compute_compunit_symtab_includes (struct dwarf2_per_cu_data *per_cu)
read. */
static void
-process_cu_includes (void)
+process_cu_includes (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
int ix;
struct dwarf2_per_cu_data *iter;
@@ -10373,7 +10473,8 @@ process_full_comp_unit (struct dwarf2_per_cu_data *per_cu,
enum language pretend_language)
{
struct dwarf2_cu *cu = per_cu->cu;
- struct objfile *objfile = per_cu->dwarf2_per_objfile->objfile;
+ struct dwarf2_per_objfile *dwarf2_per_objfile = per_cu->dwarf2_per_objfile;
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
struct gdbarch *gdbarch = get_objfile_arch (objfile);
CORE_ADDR lowpc, highpc;
struct compunit_symtab *cust;
@@ -10477,7 +10578,8 @@ process_full_type_unit (struct dwarf2_per_cu_data *per_cu,
enum language pretend_language)
{
struct dwarf2_cu *cu = per_cu->cu;
- struct objfile *objfile = per_cu->dwarf2_per_objfile->objfile;
+ struct dwarf2_per_objfile *dwarf2_per_objfile = per_cu->dwarf2_per_objfile;
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
struct compunit_symtab *cust;
struct cleanup *delayed_list_cleanup;
struct signatured_type *sig_type;
@@ -10565,7 +10667,7 @@ process_imported_unit_die (struct die_info *die, struct dwarf2_cu *cu)
bool is_dwz = (attr->form == DW_FORM_GNU_ref_alt || cu->per_cu->is_dwz);
dwarf2_per_cu_data *per_cu
= dwarf2_find_containing_comp_unit (sect_off, is_dwz,
- cu->dwarf2_per_objfile->objfile);
+ cu->dwarf2_per_objfile);
/* If necessary, add it to the queue and load its DIEs. */
if (maybe_queue_comp_unit (cu, per_cu, cu->language))
@@ -11452,6 +11554,7 @@ static void
handle_DW_AT_stmt_list (struct die_info *die, struct dwarf2_cu *cu,
const char *comp_dir, CORE_ADDR lowpc) /* ARI: editCase function */
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = cu->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct attribute *attr;
struct line_header line_header_local;
@@ -11550,6 +11653,7 @@ handle_DW_AT_stmt_list (struct die_info *die, struct dwarf2_cu *cu,
static void
read_file_scope (struct die_info *die, struct dwarf2_cu *cu)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = cu->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct gdbarch *gdbarch = get_objfile_arch (objfile);
CORE_ADDR lowpc = ((CORE_ADDR) -1);
@@ -11801,10 +11905,8 @@ eq_dwo_file (const void *item_lhs, const void *item_rhs)
/* Allocate a hash table for DWO files. */
static htab_t
-allocate_dwo_file_hash_table (void)
+allocate_dwo_file_hash_table (struct objfile *objfile)
{
- struct objfile *objfile = dwarf2_per_objfile->objfile;
-
return htab_create_alloc_ex (41,
hash_dwo_file,
eq_dwo_file,
@@ -11817,13 +11919,16 @@ allocate_dwo_file_hash_table (void)
/* Lookup DWO file DWO_NAME. */
static void **
-lookup_dwo_file_slot (const char *dwo_name, const char *comp_dir)
+lookup_dwo_file_slot (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ const char *dwo_name,
+ const char *comp_dir)
{
struct dwo_file find_entry;
void **slot;
if (dwarf2_per_objfile->dwo_files == NULL)
- dwarf2_per_objfile->dwo_files = allocate_dwo_file_hash_table ();
+ dwarf2_per_objfile->dwo_files
+ = allocate_dwo_file_hash_table (dwarf2_per_objfile->objfile);
memset (&find_entry, 0, sizeof (find_entry));
find_entry.dwo_name = dwo_name;
@@ -11923,7 +12028,8 @@ create_dwo_cu_reader (const struct die_reader_specs *reader,
Note: This function processes DWO files only, not DWP files. */
static void
-create_cus_hash_table (struct dwo_file &dwo_file, dwarf2_section_info §ion,
+create_cus_hash_table (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct dwo_file &dwo_file, dwarf2_section_info §ion,
htab_t &cus_htab)
{
struct objfile *objfile = dwarf2_per_objfile->objfile;
@@ -12128,7 +12234,8 @@ create_cus_hash_table (struct dwo_file &dwo_file, dwarf2_section_info §ion,
Note: This function processes DWP files only, not DWO files. */
static struct dwp_hash_table *
-create_dwp_hash_table (struct dwp_file *dwp_file, int is_debug_types)
+create_dwp_hash_table (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct dwp_file *dwp_file, int is_debug_types)
{
struct objfile *objfile = dwarf2_per_objfile->objfile;
bfd *dbfd = dwp_file->dbfd;
@@ -12365,7 +12472,8 @@ locate_v1_virtual_dwo_sections (asection *sectp,
This is for DWP version 1 files. */
static struct dwo_unit *
-create_dwo_unit_in_dwp_v1 (struct dwp_file *dwp_file,
+create_dwo_unit_in_dwp_v1 (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct dwp_file *dwp_file,
uint32_t unit_index,
const char *comp_dir,
ULONGEST signature, int is_debug_types)
@@ -12463,7 +12571,9 @@ create_dwo_unit_in_dwp_v1 (struct dwp_file *dwp_file,
get_section_id (§ions.loc),
get_section_id (§ions.str_offsets));
/* Can we use an existing virtual DWO file? */
- dwo_file_slot = lookup_dwo_file_slot (virtual_dwo_name.c_str (), comp_dir);
+ dwo_file_slot = lookup_dwo_file_slot (dwarf2_per_objfile,
+ virtual_dwo_name.c_str (),
+ comp_dir);
/* Create one if necessary. */
if (*dwo_file_slot == NULL)
{
@@ -12522,7 +12632,8 @@ create_dwo_unit_in_dwp_v1 (struct dwp_file *dwp_file,
of just that piece. */
static struct dwarf2_section_info
-create_dwp_v2_section (struct dwarf2_section_info *section,
+create_dwp_v2_section (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct dwarf2_section_info *section,
bfd_size_type offset, bfd_size_type size)
{
struct dwarf2_section_info result;
@@ -12563,7 +12674,8 @@ create_dwp_v2_section (struct dwarf2_section_info *section,
This is for DWP version 2 files. */
static struct dwo_unit *
-create_dwo_unit_in_dwp_v2 (struct dwp_file *dwp_file,
+create_dwo_unit_in_dwp_v2 (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct dwp_file *dwp_file,
uint32_t unit_index,
const char *comp_dir,
ULONGEST signature, int is_debug_types)
@@ -12657,7 +12769,9 @@ create_dwo_unit_in_dwp_v2 (struct dwp_file *dwp_file,
(long) (sections.str_offsets_size
? sections.str_offsets_offset : 0));
/* Can we use an existing virtual DWO file? */
- dwo_file_slot = lookup_dwo_file_slot (virtual_dwo_name.c_str (), comp_dir);
+ dwo_file_slot = lookup_dwo_file_slot (dwarf2_per_objfile,
+ virtual_dwo_name.c_str (),
+ comp_dir);
/* Create one if necessary. */
if (*dwo_file_slot == NULL)
{
@@ -12673,22 +12787,23 @@ create_dwo_unit_in_dwp_v2 (struct dwp_file *dwp_file,
virtual_dwo_name.size ());
dwo_file->comp_dir = comp_dir;
dwo_file->sections.abbrev =
- create_dwp_v2_section (&dwp_file->sections.abbrev,
+ create_dwp_v2_section (dwarf2_per_objfile, &dwp_file->sections.abbrev,
sections.abbrev_offset, sections.abbrev_size);
dwo_file->sections.line =
- create_dwp_v2_section (&dwp_file->sections.line,
+ create_dwp_v2_section (dwarf2_per_objfile, &dwp_file->sections.line,
sections.line_offset, sections.line_size);
dwo_file->sections.loc =
- create_dwp_v2_section (&dwp_file->sections.loc,
+ create_dwp_v2_section (dwarf2_per_objfile, &dwp_file->sections.loc,
sections.loc_offset, sections.loc_size);
dwo_file->sections.macinfo =
- create_dwp_v2_section (&dwp_file->sections.macinfo,
+ create_dwp_v2_section (dwarf2_per_objfile, &dwp_file->sections.macinfo,
sections.macinfo_offset, sections.macinfo_size);
dwo_file->sections.macro =
- create_dwp_v2_section (&dwp_file->sections.macro,
+ create_dwp_v2_section (dwarf2_per_objfile, &dwp_file->sections.macro,
sections.macro_offset, sections.macro_size);
dwo_file->sections.str_offsets =
- create_dwp_v2_section (&dwp_file->sections.str_offsets,
+ create_dwp_v2_section (dwarf2_per_objfile,
+ &dwp_file->sections.str_offsets,
sections.str_offsets_offset,
sections.str_offsets_size);
/* The "str" section is global to the entire DWP file. */
@@ -12717,7 +12832,8 @@ create_dwo_unit_in_dwp_v2 (struct dwp_file *dwp_file,
dwo_unit->signature = signature;
dwo_unit->section =
XOBNEW (&objfile->objfile_obstack, struct dwarf2_section_info);
- *dwo_unit->section = create_dwp_v2_section (is_debug_types
+ *dwo_unit->section = create_dwp_v2_section (dwarf2_per_objfile,
+ is_debug_types
? &dwp_file->sections.types
: &dwp_file->sections.info,
sections.info_or_types_offset,
@@ -12731,7 +12847,8 @@ create_dwo_unit_in_dwp_v2 (struct dwp_file *dwp_file,
Returns NULL if the signature isn't found. */
static struct dwo_unit *
-lookup_dwo_unit_in_dwp (struct dwp_file *dwp_file, const char *comp_dir,
+lookup_dwo_unit_in_dwp (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ struct dwp_file *dwp_file, const char *comp_dir,
ULONGEST signature, int is_debug_types)
{
const struct dwp_hash_table *dwp_htab =
@@ -12769,13 +12886,15 @@ lookup_dwo_unit_in_dwp (struct dwp_file *dwp_file, const char *comp_dir,
if (dwp_file->version == 1)
{
- *slot = create_dwo_unit_in_dwp_v1 (dwp_file, unit_index,
+ *slot = create_dwo_unit_in_dwp_v1 (dwarf2_per_objfile,
+ dwp_file, unit_index,
comp_dir, signature,
is_debug_types);
}
else
{
- *slot = create_dwo_unit_in_dwp_v2 (dwp_file, unit_index,
+ *slot = create_dwo_unit_in_dwp_v2 (dwarf2_per_objfile,
+ dwp_file, unit_index,
comp_dir, signature,
is_debug_types);
}
@@ -12804,7 +12923,8 @@ lookup_dwo_unit_in_dwp (struct dwp_file *dwp_file, const char *comp_dir,
NOTE: This function is derived from symfile_bfd_open. */
static gdb_bfd_ref_ptr
-try_open_dwop_file (const char *file_name, int is_dwp, int search_cwd)
+try_open_dwop_file (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ const char *file_name, int is_dwp, int search_cwd)
{
int desc, flags;
char *absolute_name;
@@ -12860,10 +12980,12 @@ try_open_dwop_file (const char *file_name, int is_dwp, int search_cwd)
same as symfile_bfd_open. */
static gdb_bfd_ref_ptr
-open_dwo_file (const char *file_name, const char *comp_dir)
+open_dwo_file (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ const char *file_name, const char *comp_dir)
{
if (IS_ABSOLUTE_PATH (file_name))
- return try_open_dwop_file (file_name, 0 /*is_dwp*/, 0 /*search_cwd*/);
+ return try_open_dwop_file (dwarf2_per_objfile, file_name,
+ 0 /*is_dwp*/, 0 /*search_cwd*/);
/* Before trying the search path, try DWO_NAME in COMP_DIR. */
@@ -12874,7 +12996,9 @@ open_dwo_file (const char *file_name, const char *comp_dir)
/* NOTE: If comp_dir is a relative path, this will also try the
search path, which seems useful. */
- gdb_bfd_ref_ptr abfd (try_open_dwop_file (path_to_try, 0 /*is_dwp*/,
+ gdb_bfd_ref_ptr abfd (try_open_dwop_file (dwarf2_per_objfile,
+ path_to_try,
+ 0 /*is_dwp*/,
1 /*search_cwd*/));
xfree (path_to_try);
if (abfd != NULL)
@@ -12887,7 +13011,8 @@ open_dwo_file (const char *file_name, const char *comp_dir)
if (*debug_file_directory == '\0')
return NULL;
- return try_open_dwop_file (file_name, 0 /*is_dwp*/, 1 /*search_cwd*/);
+ return try_open_dwop_file (dwarf2_per_objfile, file_name,
+ 0 /*is_dwp*/, 1 /*search_cwd*/);
}
/* This function is mapped across the sections and remembers the offset and
@@ -12959,11 +13084,12 @@ static struct dwo_file *
open_and_init_dwo_file (struct dwarf2_per_cu_data *per_cu,
const char *dwo_name, const char *comp_dir)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = per_cu->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct dwo_file *dwo_file;
struct cleanup *cleanups;
- gdb_bfd_ref_ptr dbfd (open_dwo_file (dwo_name, comp_dir));
+ gdb_bfd_ref_ptr dbfd (open_dwo_file (dwarf2_per_objfile, dwo_name, comp_dir));
if (dbfd == NULL)
{
if (dwarf_read_debug)
@@ -12975,15 +13101,20 @@ open_and_init_dwo_file (struct dwarf2_per_cu_data *per_cu,
dwo_file->comp_dir = comp_dir;
dwo_file->dbfd = dbfd.release ();
- cleanups = make_cleanup (free_dwo_file_cleanup, dwo_file);
+ free_dwo_file_cleanup_data *cleanup_data = XNEW (free_dwo_file_cleanup_data);
+ cleanup_data->dwo_file = dwo_file;
+ cleanup_data->dwarf2_per_objfile = dwarf2_per_objfile;
+
+ cleanups = make_cleanup (free_dwo_file_cleanup, cleanup_data);
bfd_map_over_sections (dwo_file->dbfd, dwarf2_locate_dwo_sections,
&dwo_file->sections);
- create_cus_hash_table (*dwo_file, dwo_file->sections.info, dwo_file->cus);
+ create_cus_hash_table (dwarf2_per_objfile, *dwo_file, dwo_file->sections.info,
+ dwo_file->cus);
- create_debug_types_hash_table (dwo_file, dwo_file->sections.types,
- dwo_file->tus);
+ create_debug_types_hash_table (dwarf2_per_objfile, dwo_file,
+ dwo_file->sections.types, dwo_file->tus);
discard_cleanups (cleanups);
@@ -13131,9 +13262,11 @@ allocate_dwp_loaded_cutus_table (struct objfile *objfile)
same as symfile_bfd_open. */
static gdb_bfd_ref_ptr
-open_dwp_file (const char *file_name)
+open_dwp_file (struct dwarf2_per_objfile *dwarf2_per_objfile,
+ const char *file_name)
{
- gdb_bfd_ref_ptr abfd (try_open_dwop_file (file_name, 1 /*is_dwp*/,
+ gdb_bfd_ref_ptr abfd (try_open_dwop_file (dwarf2_per_objfile, file_name,
+ 1 /*is_dwp*/,
1 /*search_cwd*/));
if (abfd != NULL)
return abfd;
@@ -13151,7 +13284,8 @@ open_dwp_file (const char *file_name)
/* Don't implicitly search the current directory here.
If the user wants to search "." to handle this case,
it must be added to debug-file-directory. */
- return try_open_dwop_file (lbasename (file_name), 1 /*is_dwp*/,
+ return try_open_dwop_file (dwarf2_per_objfile,
+ lbasename (file_name), 1 /*is_dwp*/,
0 /*search_cwd*/);
}
@@ -13163,7 +13297,7 @@ open_dwp_file (const char *file_name)
The result is NULL if it can't be found. */
static struct dwp_file *
-open_and_init_dwp_file (void)
+open_and_init_dwp_file (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
struct objfile *objfile = dwarf2_per_objfile->objfile;
struct dwp_file *dwp_file;
@@ -13186,14 +13320,14 @@ open_and_init_dwp_file (void)
dwp_name += ".dwp";
- gdb_bfd_ref_ptr dbfd (open_dwp_file (dwp_name.c_str ()));
+ gdb_bfd_ref_ptr dbfd (open_dwp_file (dwarf2_per_objfile, dwp_name.c_str ()));
if (dbfd == NULL
&& strcmp (objfile->original_name, objfile_name (objfile)) != 0)
{
/* Try to find .dwp for the binary file after gdb_realpath resolving. */
dwp_name = objfile_name (objfile);
dwp_name += ".dwp";
- dbfd = open_dwp_file (dwp_name.c_str ());
+ dbfd = open_dwp_file (dwarf2_per_objfile, dwp_name.c_str ());
}
if (dbfd == NULL)
@@ -13215,9 +13349,9 @@ open_and_init_dwp_file (void)
bfd_map_over_sections (dwp_file->dbfd, dwarf2_locate_common_dwp_sections,
dwp_file);
- dwp_file->cus = create_dwp_hash_table (dwp_file, 0);
+ dwp_file->cus = create_dwp_hash_table (dwarf2_per_objfile, dwp_file, 0);
- dwp_file->tus = create_dwp_hash_table (dwp_file, 1);
+ dwp_file->tus = create_dwp_hash_table (dwarf2_per_objfile, dwp_file, 1);
/* The DWP file version is stored in the hash table. Oh well. */
if (dwp_file->cus && dwp_file->tus
@@ -13261,11 +13395,12 @@ open_and_init_dwp_file (void)
/* Wrapper around open_and_init_dwp_file, only open it once. */
static struct dwp_file *
-get_dwp_file (void)
+get_dwp_file (struct dwarf2_per_objfile *dwarf2_per_objfile)
{
if (! dwarf2_per_objfile->dwp_checked)
{
- dwarf2_per_objfile->dwp_file = open_and_init_dwp_file ();
+ dwarf2_per_objfile->dwp_file
+ = open_and_init_dwp_file (dwarf2_per_objfile);
dwarf2_per_objfile->dwp_checked = 1;
}
return dwarf2_per_objfile->dwp_file;
@@ -13292,6 +13427,7 @@ lookup_dwo_cutu (struct dwarf2_per_cu_data *this_unit,
const char *dwo_name, const char *comp_dir,
ULONGEST signature, int is_debug_types)
{
+ struct dwarf2_per_objfile *dwarf2_per_objfile = this_unit->dwarf2_per_objfile;
struct objfile *objfile = dwarf2_per_objfile->objfile;
const char *kind = is_debug_types ? "TU" : "CU";
void **dwo_file_slot;
@@ -13303,7 +13439,7 @@ lookup_dwo_cutu (struct dwarf2_per_cu_data *this_unit,
look for the original DWO file. It makes gdb behave differently
depending on whether one is debugging in the build tree. */
- dwp_file = get_dwp_file ();
+ dwp_file = get_dwp_file (dwarf2_per_objfile);
if (dwp_file != NULL)
{
const struct dwp_hash_table *dwp_htab =
@@ -13312,7 +13448,7 @@ lookup_dwo_cutu (struct dwarf2_per_cu_data *this_unit,
if (dwp_htab != NULL)
{
struct dwo_unit *dwo_cutu =
- lookup_dwo_unit_in_dwp (dwp_file, comp_dir,
+ lookup_dwo_unit_in_dwp (dwarf2_per_objfile, dwp_file, comp_dir,
signature, is_debug_types);
if (dwo_cutu != NULL)
@@ -13332,7 +13468,8 @@ lookup_dwo_cutu (struct dwarf2_per_cu_data *this_unit,
{
/* No DWP file, look for the DWO file. */
- dwo_file_slot = lookup_dwo_file_slot (dwo_name, comp_dir);
+ dwo_file_slot = lookup_dwo_file_slot (dwarf2_per_objfile,
+ dwo_name, comp_dir);
if (*dwo_file_slot == NULL)
{
/* Read in the file and build a table of the CUs/TUs it contains. */
@@ -13467,7 +13604,7 @@ queue_and_load_all_dwo_tus (struct dwarf2_per_cu_data *per_cu)
struct dwo_file *dwo_file;
gdb_assert (!per_cu->is_debug_types);
- gdb_assert (get_dwp_file () == NULL);
+ gdb_assert (get_dwp_file (per_cu->dwarf2_per_objfile) == NULL);
gdb_assert (per_cu->cu != NULL);
dwo_unit = per_cu->cu->dwo_unit;
@@ -13497,10 +13634,13 @@ free_dwo_file (struct dwo_file *dwo_file, struct objfile *objfile)
static void
free_dwo_file_cleanup (void *arg)
{
- struct dwo_file *dwo_file = (struct dwo_file *) arg;
- struct objfile *objfile = dwarf2_per_objfile->objfile;
+ struct free_dwo_file_cleanup_data *data
+ = (struct free_dwo_file_cleanup_data *) arg;
+ struct objfile *objfile = data->dwarf2_per_objfile->objfile;
- free_dwo_file (dwo_file, objfile);
+ free_dwo_file (data->dwo_file, objfile);
+
+ xfree (data);
}
/* Traversal function for free_dwo_files. */
@@ -14302,7 +14442,9 @@ static bool
dwarf2_rnglists_process (unsigned offset, struct dwarf2_cu *cu,
Callback &&callback)
{
- struct objfile *objfile = cu->dwarf2_per_objfile->objfile;
+ struct dwarf2_per_objfile *dwarf2_per_objfile
+ = cu->dwarf2_per_objfile;
+ struct objfile *objfile = dwarf2_per_objfile->objfile;
bfd *obfd = objfile->obfd;
/* Base address selection entry. */
CORE_ADDR base;
@@ -14468,7 +14610,9 @@ static int
dwarf2_ran[...]
[diff truncated at 100000 bytes]