This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix gdb snapshots
- From: Tom Tromey <tromey at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 29 Nov 2017 18:57:01 -0000
- Subject: [binutils-gdb] Fix gdb snapshots
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5dcf52c19f7045fb179f703426d345b8a81d2210
commit 5dcf52c19f7045fb179f703426d345b8a81d2210
Author: Tom Tromey <tom@tromey.com>
Date: Wed Nov 29 09:27:40 2017 -0700
Fix gdb snapshots
Joel pointed out that gdb snapshots were broken by my Makefile patch
series. The bug is that rmdir in distclean was failing, because the
directory did not exist. This fixes the bug by only invoking rmdir when
the directory exists.
Tested using "src-release.sh gdb".
2017-11-29 Tom Tromey <tom@tromey.com>
* Makefile.in (distclean): Handle the case where rmdir fails.
Diff:
---
gdb/ChangeLog | 4 ++++
gdb/Makefile.in | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index bef5793..bd1eccf 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2017-11-29 Tom Tromey <tom@tromey.com>
+ * Makefile.in (distclean): Handle the case where rmdir fails.
+
+2017-11-29 Tom Tromey <tom@tromey.com>
+
* symfile.c (_initialize_symfile): Update usage text for
add-symbol-file, symbol-file, load.
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 6e16bc6..284559b 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1995,7 +1995,7 @@ distclean: clean
rm -f Makefile
rm -rf $(DEPDIR)
for i in $(CONFIG_SRC_SUBDIR); do \
- rmdir $$i/$(DEPDIR); \
+ if test -d $$i/$(DEPDIR); then rmdir $$i/$(DEPDIR); fi \
done
maintainer-clean: local-maintainer-clean do-maintainer-clean distclean