This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Remove "do_nothing"
- From: Tom Tromey <tromey at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 9 Oct 2017 23:40:21 -0000
- Subject: [binutils-gdb] Remove "do_nothing"
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0c478e2d060bebea341696806fed6f67122efab6
commit 0c478e2d060bebea341696806fed6f67122efab6
Author: Tom Tromey <tom@tromey.com>
Date: Sun Oct 8 16:19:48 2017 -0600
Remove "do_nothing"
The do_nothing function in mi-main.c is used as a splay tree
key-deleting function; but NULL serves the same purpose and is used
elsewhere in gdb. This patch removes the unneeded function.
ChangeLog
2017-10-09 Tom Tromey <tom@tromey.com>
* mi/mi-main.c (do_nothing): Remove.
(list_available_thread_groups): Update.
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/mi/mi-main.c | 7 +------
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f1fd73c..ce21e25 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-10-09 Tom Tromey <tom@tromey.com>
+
+ * mi/mi-main.c (do_nothing): Remove.
+ (list_available_thread_groups): Update.
+
2017-10-09 Pedro Alves <palves@redhat.com>
* infrun.c (handle_inferior_event_1) <TARGET_WAITKIND_EXECD>: Skip
diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
index 289445f..98fff4f 100644
--- a/gdb/mi/mi-main.c
+++ b/gdb/mi/mi-main.c
@@ -702,11 +702,6 @@ output_cores (struct ui_out *uiout, const char *field_name, const char *xcores)
}
static void
-do_nothing (splay_tree_key k)
-{
-}
-
-static void
free_vector_of_osdata_items (splay_tree_value xvalue)
{
VEC (osdata_item_s) *value = (VEC (osdata_item_s) *) xvalue;
@@ -756,7 +751,7 @@ list_available_thread_groups (const std::set<int> &ids, int recurse)
make_cleanup_osdata_free (threads);
tree = splay_tree_new (splay_tree_int_comparator,
- do_nothing,
+ NULL,
free_vector_of_osdata_items);
make_cleanup (free_splay_tree, tree);