This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Remove one explicit rule for monitor.o


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=aa70c9f1950b25b48f8fd6770f5d38a8252c24a4

commit aa70c9f1950b25b48f8fd6770f5d38a8252c24a4
Author: Yao Qi <yao.qi@linaro.org>
Date:   Tue Sep 19 10:18:57 2017 +0100

    Remove one explicit rule for monitor.o
    
    gdb/monitor.c was removed by 40e0b27 (Delete the remaining ROM monitor
    targets).
    
    gdb:
    
    2017-09-19  Yao Qi  <yao.qi@linaro.org>
    
    	* Makefile.in (monitor.o): Remove the rule.

Diff:
---
 gdb/ChangeLog   |  4 ++++
 gdb/Makefile.in | 11 -----------
 2 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ab982ab..4779273 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2017-09-19  Yao Qi  <yao.qi@linaro.org>
 
+	* Makefile.in (monitor.o): Remove the rule.
+
+2017-09-19  Yao Qi  <yao.qi@linaro.org>
+
 	* annotate.h (struct annotate_arg_emitter): Use
 	DISABLE_COPY_AND_ASSIGN.
 	* common/refcounted-object.h (refcounted_object): Likewise.
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 9dfc117..5740d43 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2711,17 +2711,6 @@ ALLDEPFILES = \
 # Some files need explicit build rules (due to -Werror problems) or due
 # to sub-directory fun 'n' games.
 
-# FIXME: cagney/2003-08-10: "monitor.c" gets -Wformat-nonliteral
-# errors.  It turns out that that is the least of monitor.c's
-# problems.  The function print_vsprintf appears to be using
-# va_arg(long) to extract CORE_ADDR parameters - something that
-# definitly will not work.  "monitor.c" needs to be rewritten so that
-# it doesn't use format strings and instead uses callbacks.
-monitor.o: $(srcdir)/monitor.c
-	$(COMPILE.pre) $(INTERNAL_CFLAGS) $(GDB_WARN_CFLAGS_NO_FORMAT) \
-		$(COMPILE.post) $(srcdir)/monitor.c
-	$(POSTCOMPILE)
-
 # Do not try to build "printcmd.c" with -Wformat-nonliteral.  It manually
 # checks format strings.
 printcmd.o: $(srcdir)/printcmd.c


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]