This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Remove last cleanups from go-exp.y


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fef704bfec3fdec29b08fca2bd0a5226a04c3113

commit fef704bfec3fdec29b08fca2bd0a5226a04c3113
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Aug 13 10:40:35 2017 -0600

    Remove last cleanups from go-exp.y
    
    This removes the last remaining cleanups from go-exp.y.
    
    2017-09-05  Tom Tromey  <tom@tromey.com>
    
    	* go-exp.y (go_parse): Don't create a cleanup.

Diff:
---
 gdb/ChangeLog |  4 ++++
 gdb/go-exp.y  | 11 +----------
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c8ba539..32c6379 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2017-09-05  Tom Tromey  <tom@tromey.com>
 
+	* go-exp.y (go_parse): Don't create a cleanup.
+
+2017-09-05  Tom Tromey  <tom@tromey.com>
+
 	* d-exp.y (PrimaryExpression): Use std::string.
 	(d_parse): Don't create a cleanup.
 
diff --git a/gdb/go-exp.y b/gdb/go-exp.y
index 098e734..629093a 100644
--- a/gdb/go-exp.y
+++ b/gdb/go-exp.y
@@ -1560,18 +1560,11 @@ yylex (void)
 int
 go_parse (struct parser_state *par_state)
 {
-  int result;
-  struct cleanup *back_to;
-
   /* Setting up the parser state.  */
   scoped_restore pstate_restore = make_scoped_restore (&pstate);
   gdb_assert (par_state != NULL);
   pstate = par_state;
 
-  /* Note that parsing (within yyparse) freely installs cleanups
-     assuming they'll be run here (below).  */
-  back_to = make_cleanup (null_cleanup, NULL);
-
   scoped_restore restore_yydebug = make_scoped_restore (&yydebug,
 							parser_debug);
 
@@ -1583,9 +1576,7 @@ go_parse (struct parser_state *par_state)
   popping = 0;
   name_obstack.clear ();
 
-  result = yyparse ();
-  do_cleanups (back_to);
-  return result;
+  return yyparse ();
 }
 
 void


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]