This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Fix calls in gdb.arch/thumb2-it.exp


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8f8f815255bf36800cdfff93fd88a62aaa39ce16

commit 8f8f815255bf36800cdfff93fd88a62aaa39ce16
Author: Thomas Preud'homme <thomas.preudhomme@arm.com>
Date:   Wed Sep 6 17:54:26 2017 +0100

    Fix calls in gdb.arch/thumb2-it.exp
    
    Tests in gdb.arch/thumb2-it.exp call functions defined in assembly
    without type debugging information. Since
    7022349d5c86bae74b49225515f42d2e221bd368 ("Stop assuming no-debug-info
    functions return int") this triggers an error which leads to many tests
    to FAIL. This patch cast the call to indicate the return type of the
    functions when calling them.
    
    2017-09-06  Thomas Preud'homme  <thomas.preudhomme@arm.com>
    
    gdb/testsuite/
    	* gdb.arch/thumb2-it.exp: Cast call to assembly defined function.

Diff:
---
 gdb/testsuite/ChangeLog              | 4 ++++
 gdb/testsuite/gdb.arch/thumb2-it.exp | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3f64c6c..a4f2a14 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2017-09-06  Thomas Preud'homme  <thomas.preudhomme@arm.com>
+
+	* gdb.arch/thumb2-it.exp: Cast call to assembly defined function.
+
 2017-09-06  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	* gdb.threads/tls-nodebug-pie.c: New file.
diff --git a/gdb/testsuite/gdb.arch/thumb2-it.exp b/gdb/testsuite/gdb.arch/thumb2-it.exp
index ab0dae3..e100d06 100644
--- a/gdb/testsuite/gdb.arch/thumb2-it.exp
+++ b/gdb/testsuite/gdb.arch/thumb2-it.exp
@@ -58,7 +58,7 @@ proc test_it_block { func } {
 	return
     }
 
-    gdb_test "call ${func}()" "Breakpoint.*@ Setup.*" "$func, call"
+    gdb_test "call (int) ${func}()" "Breakpoint.*@ Setup.*" "$func, call"
 
     set expected 0
     set reached 0
@@ -155,7 +155,7 @@ for { set i 1 } { $i <= 8 } { incr i } {
 }
 
 gdb_breakpoint "*it_breakpoints"
-gdb_test "call it_breakpoints()" "Breakpoint.*"
+gdb_test "call (int) it_breakpoints()" "Breakpoint.*"
 for { set i 1 } { $i <= 7 } { incr i } {
     test_it_break ${i}
 }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]