This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] "gdb.arch/i386-pkru.exp: probe PKRU support" shouldn't FAIL if not supported
- From: Pedro Alves <palves at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 8 Mar 2017 13:14:31 -0000
- Subject: [binutils-gdb] "gdb.arch/i386-pkru.exp: probe PKRU support" shouldn't FAIL if not supported
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=25dcbff6ef0088e080d92b3cbc346ae0b5071d9d
commit 25dcbff6ef0088e080d92b3cbc346ae0b5071d9d
Author: Pedro Alves <palves@redhat.com>
Date: Wed Mar 8 13:09:45 2017 +0000
"gdb.arch/i386-pkru.exp: probe PKRU support" shouldn't FAIL if not supported
Currently I get:
(gdb) print have_pkru()
$1 = 0
(gdb) FAIL: gdb.arch/i386-pkru.exp: probe PKRU support
UNSUPPORTED: gdb.arch/i386-pkru.exp: processor does not support protection key feature.
Probing suceeded, so that should be a PASS -> UNSUPPORTED.
gdb/testsuite/ChangeLog:
2017-03-08 Pedro Alves <palves@redhat.com>
* gdb.arch/i386-pkru.exp (probe PKRU support): Handle detecting
PKRU as not supported as a PASS.
Diff:
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.arch/i386-pkru.exp | 3 +++
2 files changed, 8 insertions(+)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index b2b14db..26135e5 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2017-03-08 Pedro Alves <palves@redhat.com>
+ * gdb.arch/i386-pkru.exp (probe PKRU support): Handle detecting
+ PKRU as not supported as a PASS.
+
+2017-03-08 Pedro Alves <palves@redhat.com>
+
* gdb.base/break-fun-addr.exp: Use $testfile1/$testfile2 for test
prefix instead of $binfile1/$binfile2.
* gdb.btrace/gcore.exp: Use "core" instead of unstable path name
diff --git a/gdb/testsuite/gdb.arch/i386-pkru.exp b/gdb/testsuite/gdb.arch/i386-pkru.exp
index 5f243f1..eb77037 100644
--- a/gdb/testsuite/gdb.arch/i386-pkru.exp
+++ b/gdb/testsuite/gdb.arch/i386-pkru.exp
@@ -40,6 +40,9 @@ gdb_test_multiple "print have_pkru()" $test {
pass $test
set supports_pkru 1
}
+ -re ".. = 0\r\n$gdb_prompt $" {
+ pass $test
+ }
}
if { !$supports_pkru } {