This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Use ui_file_as_string in gdb/printcmd.c


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=02030646c2a799614d31e52008403d8be067ac5d

commit 02030646c2a799614d31e52008403d8be067ac5d
Author: Pedro Alves <palves@redhat.com>
Date:   Tue Nov 8 15:26:45 2016 +0000

    Use ui_file_as_string in gdb/printcmd.c
    
    Yet another cleanup eliminated.
    
    gdb/ChangeLog:
    2016-11-08  Pedro Alves  <palves@redhat.com>
    
    	* printcmd.c (eval_command): Use ui_file_as_string and
    	std::string.

Diff:
---
 gdb/ChangeLog  | 5 +++++
 gdb/printcmd.c | 6 ++----
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 08699ed..254893f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2016-11-08  Pedro Alves  <palves@redhat.com>
 
+	* printcmd.c (eval_command): Use ui_file_as_string and
+	std::string.
+
+2016-11-08  Pedro Alves  <palves@redhat.com>
+
 	* top.c (quit_confirm): Use ui_file_as_string and std::string.
 
 2016-11-08  Pedro Alves  <palves@redhat.com>
diff --git a/gdb/printcmd.c b/gdb/printcmd.c
index b70ed19..23de57c 100644
--- a/gdb/printcmd.c
+++ b/gdb/printcmd.c
@@ -2719,14 +2719,12 @@ eval_command (char *arg, int from_tty)
 {
   struct ui_file *ui_out = mem_fileopen ();
   struct cleanup *cleanups = make_cleanup_ui_file_delete (ui_out);
-  char *expanded;
 
   ui_printf (arg, ui_out);
 
-  expanded = ui_file_xstrdup (ui_out, NULL);
-  make_cleanup (xfree, expanded);
+  std::string expanded = ui_file_as_string (ui_out);
 
-  execute_command (expanded, from_tty);
+  execute_command (&expanded[0], from_tty);
 
   do_cleanups (cleanups);
 }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]