This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] xtensa: Add missing statics
- From: Simon Marchi <simark at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 3 Nov 2015 18:35:37 -0000
- Subject: [binutils-gdb] xtensa: Add missing statics
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1c215b97f9a64d6ba9821e8a0cf0f44526f29d78
commit 1c215b97f9a64d6ba9821e8a0cf0f44526f29d78
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date: Tue Nov 3 13:33:16 2015 -0500
xtensa: Add missing statics
This actually fixes the build in C:
/home/simark/src/binutils-gdb/gdb/xtensa-linux-nat.c:100:1: error: no previous prototype for â??supply_gregset_regâ?? [-Werror=missing-prototypes]
supply_gregset_reg (struct regcache *regcache,
^
/home/simark/src/binutils-gdb/gdb/xtensa-linux-nat.c:257:1: error: no previous prototype for â??xtensa_linux_fetch_inferior_registersâ?? [-Werror=missing-prototypes]
xtensa_linux_fetch_inferior_registers (struct target_ops *ops,
^
/home/simark/src/binutils-gdb/gdb/xtensa-linux-nat.c:272:1: error: no previous prototype for â??xtensa_linux_store_inferior_registersâ?? [-Werror=missing-prototypes]
xtensa_linux_store_inferior_registers (struct target_ops *ops,
^
cc1: all warnings being treated as errors
These functions are local to this file, so they should be static.
gdb/ChangeLog:
* xtensa-linux-nat.c (supply_gregset_reg): Make static.
(xtensa_linux_fetch_inferior_registers): Likewise.
(xtensa_linux_store_inferior_registers): Likewise.
Diff:
---
gdb/ChangeLog | 6 ++++++
gdb/xtensa-linux-nat.c | 6 +++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8cb45b8..b098a63 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
2015-11-03 Simon Marchi <simon.marchi@polymtl.ca>
+ * xtensa-linux-nat.c (supply_gregset_reg): Make static.
+ (xtensa_linux_fetch_inferior_registers): Likewise.
+ (xtensa_linux_store_inferior_registers): Likewise.
+
+2015-11-03 Simon Marchi <simon.marchi@polymtl.ca>
+
* arm-linux-nat.c (arm_linux_read_description): Add cast.
2015-11-03 Simon Marchi <simon.marchi@polymtl.ca>
diff --git a/gdb/xtensa-linux-nat.c b/gdb/xtensa-linux-nat.c
index 5538d5b..d024408 100644
--- a/gdb/xtensa-linux-nat.c
+++ b/gdb/xtensa-linux-nat.c
@@ -96,7 +96,7 @@ fill_gregset (const struct regcache *regcache,
}
}
-void
+static void
supply_gregset_reg (struct regcache *regcache,
const gdb_gregset_t *gregsetp, int regnum)
{
@@ -253,7 +253,7 @@ store_xtregs (struct regcache *regcache, int regnum)
perror_with_name (_("Couldn't write extended registers"));
}
-void
+static void
xtensa_linux_fetch_inferior_registers (struct target_ops *ops,
struct regcache *regcache, int regnum)
{
@@ -268,7 +268,7 @@ xtensa_linux_fetch_inferior_registers (struct target_ops *ops,
fetch_xtregs (regcache, regnum);
}
-void
+static void
xtensa_linux_store_inferior_registers (struct target_ops *ops,
struct regcache *regcache, int regnum)
{