This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] gdbserver: Move pointer dereference to after assert checks.
- From: Antoine Tremblay <hexa at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 29 Oct 2015 18:30:03 -0000
- Subject: [binutils-gdb] gdbserver: Move pointer dereference to after assert checks.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=692916105d13be0ca5588bf8aa94b8ba04239269
commit 692916105d13be0ca5588bf8aa94b8ba04239269
Author: Henrik Wallin <henrik.wallin@windriver.com>
Date: Wed Oct 14 13:14:26 2015 +0200
gdbserver: Move pointer dereference to after assert checks.
gdb/gdbserver/ChangeLog:
* linux-arm-low.c (arm_new_thread): Move pointer dereference
to after assert checks.
Signed-off-by: Henrik Wallin <henrik.wallin@windriver.com>
Diff:
---
gdb/gdbserver/ChangeLog | 5 +++++
gdb/gdbserver/linux-arm-low.c | 7 +++++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 70d832f..52d6b50 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2015-10-29 Henrik Wallin <henrik.wallin@windriver.com>
+
+ * linux-arm-low.c (arm_new_thread): Move pointer dereference
+ to after assert checks.
+
2015-10-29 Simon Marchi <simon.marchi@ericsson.com>
* proc-service.c (ps_pdread): Add/adjust casts.
diff --git a/gdb/gdbserver/linux-arm-low.c b/gdb/gdbserver/linux-arm-low.c
index bab2aaf..e10955f 100644
--- a/gdb/gdbserver/linux-arm-low.c
+++ b/gdb/gdbserver/linux-arm-low.c
@@ -706,8 +706,8 @@ arm_new_thread (struct lwp_info *lwp)
static void
arm_new_fork (struct process_info *parent, struct process_info *child)
{
- struct arch_process_info *parent_proc_info = parent->priv->arch_private;
- struct arch_process_info *child_proc_info = child->priv->arch_private;
+ struct arch_process_info *parent_proc_info;
+ struct arch_process_info *child_proc_info;
struct lwp_info *child_lwp;
struct arch_lwp_info *child_lwp_info;
int i;
@@ -718,6 +718,9 @@ arm_new_fork (struct process_info *parent, struct process_info *child)
gdb_assert (child->priv != NULL
&& child->priv->arch_private != NULL);
+ parent_proc_info = parent->priv->arch_private;
+ child_proc_info = child->priv->arch_private;
+
/* Linux kernel before 2.6.33 commit
72f674d203cd230426437cdcf7dd6f681dad8b0d
will inherit hardware debug registers from parent