This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] gdb: Make use of safe-ctype.h header.


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8d3fea161a8e1d280d207406ba3fee0d44776ce6

commit 8d3fea161a8e1d280d207406ba3fee0d44776ce6
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date:   Mon Sep 7 23:46:49 2015 +0100

    gdb: Make use of safe-ctype.h header.
    
    In stack.c switch to using safe-ctype.h instead of ctype.h, update code
    as required.
    
    gdb/ChangeLog:
    
    	* stack.c: Include safe-ctype.h not ctype.h.
    	(parse_frame_specification): Use ISSPACE not isspace.
    	(backtrace_command): Use TOLOWER not tolower.

Diff:
---
 gdb/ChangeLog | 6 ++++++
 gdb/stack.c   | 6 +++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 64c4b4e..799bf30 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2015-10-12  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* stack.c: Include safe-ctype.h not ctype.h.
+	(parse_frame_specification): Use ISSPACE not isspace.
+	(backtrace_command): Use TOLOWER not tolower.
+
 2015-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* mep-tdep.c (current_me_module): Add cast.
diff --git a/gdb/stack.c b/gdb/stack.c
index 8af34f3..f257ce1 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -48,7 +48,7 @@
 #include "cli/cli-utils.h"
 #include "objfiles.h"
 
-#include <ctype.h>
+#include "safe-ctype.h"
 #include "symfile.h"
 #include "extension.h"
 
@@ -1305,7 +1305,7 @@ parse_frame_specification_1 (const char *frame_exp, const char *message,
 
 	  /* Parse the argument, extract it, save it.  */
 	  for (p = frame_exp;
-	       *p && !isspace (*p);
+	       *p && !ISSPACE (*p);
 	       p++);
 	  addr_string = savestring (frame_exp, p - frame_exp);
 	  frame_exp = p;
@@ -1894,7 +1894,7 @@ backtrace_command (char *arg, int from_tty)
 	  unsigned int j;
 
 	  for (j = 0; j < strlen (argv[i]); j++)
-	    argv[i][j] = tolower (argv[i][j]);
+	    argv[i][j] = TOLOWER (argv[i][j]);
 
 	  if (no_filters < 0 && subset_compare (argv[i], "no-filters"))
 	    no_filters = argc;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]