This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Factor out flags printing code from generic_val_print
- From: Simon Marchi <simark at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 27 Jul 2015 18:13:53 -0000
- Subject: [binutils-gdb] Factor out flags printing code from generic_val_print
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d93880bd1cd10d0ccf5346e261d5d145d50d8ab0
commit d93880bd1cd10d0ccf5346e261d5d145d50d8ab0
Author: Simon Marchi <simon.marchi@ericsson.com>
Date: Mon Jul 27 14:11:22 2015 -0400
Factor out flags printing code from generic_val_print
gdb/ChangeLog:
* valprint.c (generic_val_print): Factor out flags
printing code to ...
(generic_val_print_flags): ... this new function.
Diff:
---
gdb/ChangeLog | 6 ++++++
gdb/valprint.c | 24 ++++++++++++++++++------
2 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e16a24e..4c6e17c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
2015-07-27 Simon Marchi <simon.marchi@ericsson.com>
+ * valprint.c (generic_val_print): Factor out flags
+ printing code to ...
+ (generic_val_print_flags): ... this new function.
+
+2015-07-27 Simon Marchi <simon.marchi@ericsson.com>
+
* valprint.c (generic_val_print): Factor out enum
printing code to ...
(generic_val_print_enum): ... this new function.
diff --git a/gdb/valprint.c b/gdb/valprint.c
index f9d603a..d05b907 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -578,6 +578,22 @@ generic_val_print_enum (struct type *type, const gdb_byte *valaddr,
print_longest (stream, 'd', 0, val);
}
+/* generic_val_print helper for TYPE_CODE_FLAGS. */
+
+static void
+generic_val_print_flags (struct type *type, const gdb_byte *valaddr,
+ int embedded_offset, struct ui_file *stream,
+ const struct value *original_value,
+ const struct value_print_options *options)
+
+{
+ if (options->format)
+ val_print_scalar_formatted (type, valaddr, embedded_offset, original_value,
+ options, 0, stream);
+ else
+ val_print_type_code_flags (type, valaddr + embedded_offset, stream);
+}
+
/* A generic val_print that is suitable for use by language
implementations of the la_val_print method. This function can
handle most type codes, though not all, notably exception
@@ -630,12 +646,8 @@ generic_val_print (struct type *type, const gdb_byte *valaddr,
break;
case TYPE_CODE_FLAGS:
- if (options->format)
- val_print_scalar_formatted (type, valaddr, embedded_offset,
- original_value, options, 0, stream);
- else
- val_print_type_code_flags (type, valaddr + embedded_offset,
- stream);
+ generic_val_print_flags (type, valaddr, embedded_offset, stream,
+ original_value, options);
break;
case TYPE_CODE_FUNC: