This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] record-btrace.c: Remove redefinitions


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=928dbe07562fa842a990d1c3aa65e12343426e68

commit 928dbe07562fa842a990d1c3aa65e12343426e68
Author: Pedro Alves <palves@redhat.com>
Date:   Mon Feb 9 17:13:39 2015 +0000

    record-btrace.c: Remove redefinitions
    
    The set_record_btrace_cmdlist and show_record_btrace_cmdlist objects
    are declared twice in the file, seemingly a simply copy/paste
    oversight.  In C, the first time counts as forward declaration, but in
    C++, they are all definitions.  That results in:
    
     src/gdb/record-btrace.c:80:33: error: redefinition of â??cmd_list_element* set_record_btrace_cmdlistâ??
     src/gdb/record-btrace.c:61:33: error: â??cmd_list_element* set_record_btrace_cmdlistâ?? previously declared here
     src/gdb/record-btrace.c:81:33: error: redefinition of â??cmd_list_element* show_record_btrace_cmdlistâ??
     src/gdb/record-btrace.c:62:33: error: â??cmd_list_element* show_record_btrace_cmdlistâ?? previously declared here
    
    gdb/ChangeLog:
    2015-02-27  Pedro Alves  <palves@redhat.com>
    
    	* record-btrace.c (set_record_btrace_cmdlist)
    	(show_record_btrace_cmdlist): Remove redefinitions.
     ---
    
     gdb/record-btrace.c |    4 ----
     1 file changed, 4 deletions(-)

Diff:
---
 gdb/ChangeLog       | 5 +++++
 gdb/record-btrace.c | 4 ----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d5a0737..291e89d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-02-27  Pedro Alves  <palves@redhat.com>
+
+	* record-btrace.c (set_record_btrace_cmdlist)
+	(show_record_btrace_cmdlist): Remove redefinitions.
+
 2015-02-27  Tom Tromey  <tromey@redhat.com>
 	    Pedro Alves  <palves@redhat.com>
 
diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
index 102e0eb..35c775a 100644
--- a/gdb/record-btrace.c
+++ b/gdb/record-btrace.c
@@ -76,10 +76,6 @@ static struct btrace_config record_btrace_conf;
 /* Command list for "record btrace".  */
 static struct cmd_list_element *record_btrace_cmdlist;
 
-/* Command lists for "set/show record btrace".  */
-static struct cmd_list_element *set_record_btrace_cmdlist;
-static struct cmd_list_element *show_record_btrace_cmdlist;
-
 /* Command lists for "set/show record btrace bts".  */
 static struct cmd_list_element *set_record_btrace_bts_cmdlist;
 static struct cmd_list_element *show_record_btrace_bts_cmdlist;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]