This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] sim: Be sure of calling freeargv() after successfully call buildargv().
- From: Chen Gang <gchen at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 2 Feb 2015 20:21:34 -0000
- Subject: [binutils-gdb] sim: Be sure of calling freeargv() after successfully call buildargv().
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=907c4910c3175ce3e9fc9bfb897527ca241ffd24
commit 907c4910c3175ce3e9fc9bfb897527ca241ffd24
Author: Chen Gang <gang.chen.5i5j@gmail.com>
Date: Sat Jan 31 06:13:39 2015 +0800
sim: Be sure of calling freeargv() after successfully call buildargv().
Or there will be memory leak.
2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com>
* microblaze/interp.c (sim_do_command): Call freeargv() before
return.
Diff:
---
sim/ChangeLog | 5 +++++
sim/microblaze/interp.c | 3 +++
2 files changed, 8 insertions(+)
diff --git a/sim/ChangeLog b/sim/ChangeLog
index 628e6a8..a891ce5 100644
--- a/sim/ChangeLog
+++ b/sim/ChangeLog
@@ -1,5 +1,10 @@
2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com>
+ * microblaze/interp.c (sim_do_command): Call freeargv() before
+ return.
+
+2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com>
+
* mcore/interp.c (sim_do_command): Call freeargv() before return.
2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com>
diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c
index 1c8a22d..4fc4595 100644
--- a/sim/microblaze/interp.c
+++ b/sim/microblaze/interp.c
@@ -1019,6 +1019,7 @@ sim_do_command (SIM_DESC sd, const char *cmd)
if ((simargv[1] == NULL) || (simargv[2] == NULL))
{
fprintf (stderr, "Error: missing argument to watch cmd.\n");
+ freeargv (simargv);
return;
}
@@ -1062,6 +1063,8 @@ sim_do_command (SIM_DESC sd, const char *cmd)
fprintf (stderr,"Error: \"%s\" is not a valid M.CORE simulator command.\n",
cmd);
}
+
+ freeargv (simargv);
}
else
{