This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb/users/hjl/linux/master] [python, guile] Add comment beside conditions testing empty arrays.
- From: H.J.Lu <hjl at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 11 Jan 2015 16:20:48 -0000
- Subject: [binutils-gdb/users/hjl/linux/master] [python, guile] Add comment beside conditions testing empty arrays.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e810d75b1c9bef779b29df9d2c609fd5891d5917
commit e810d75b1c9bef779b29df9d2c609fd5891d5917
Author: Joel Brobecker <brobecker@adacore.com>
Date: Wed Jan 7 07:34:29 2015 +0400
[python,guile] Add comment beside conditions testing empty arrays.
gdb/ChangeLog:
* guile/scm-type.c (tyscm_array_1): Add comment.
* python/py-type.c (typy_array_1): Add comment.
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/guile/scm-type.c | 2 +-
gdb/python/py-type.c | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8e3737d..0b63d34 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-01-07 Joel Brobecker <brobecker@adacore.com>
+
+ * guile/scm-type.c (tyscm_array_1): Add comment.
+ * python/py-type.c (typy_array_1): Add comment.
+
2015-01-06 Joel Brobecker <brobecker@adacore.com>
* guile/scm-type.c (tyscm_array_1): Do not raise out-of-range
diff --git a/gdb/guile/scm-type.c b/gdb/guile/scm-type.c
index 4f46139..196b4a1 100644
--- a/gdb/guile/scm-type.c
+++ b/gdb/guile/scm-type.c
@@ -713,7 +713,7 @@ tyscm_array_1 (SCM self, SCM n1_scm, SCM n2_scm, int is_vector,
n1 = 0;
}
- if (n2 < n1 - 1)
+ if (n2 < n1 - 1) /* Note: An empty array has n2 == n1 - 1. */
{
gdbscm_out_of_range_error (func_name, SCM_ARG3,
scm_cons (scm_from_long (n1),
diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c
index 8e82c99..bf92363 100644
--- a/gdb/python/py-type.c
+++ b/gdb/python/py-type.c
@@ -528,7 +528,7 @@ typy_array_1 (PyObject *self, PyObject *args, int is_vector)
n1 = 0;
}
- if (n2 < n1 - 1)
+ if (n2 < n1 - 1) /* Note: An empty array has n2 == n1 - 1. */
{
PyErr_SetString (PyExc_ValueError,
_("Array length must not be negative"));