This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
gdb and binutils branch master updated. fafcc06ab29fe98d2767234dc77062d08ea0d3c7
- From: sergiodj at sourceware dot org
- To: gdb-cvs at sourceware dot org
- Date: 29 Dec 2014 19:24:19 -0000
- Subject: gdb and binutils branch master updated. fafcc06ab29fe98d2767234dc77062d08ea0d3c7
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via fafcc06ab29fe98d2767234dc77062d08ea0d3c7 (commit)
from b35b02984b80ff231dd11dc4f3c7bdba6bef95a7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fafcc06ab29fe98d2767234dc77062d08ea0d3c7
commit fafcc06ab29fe98d2767234dc77062d08ea0d3c7
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date: Mon Dec 29 14:22:20 2014 -0500
Sanitize input_interrupt output
Hi,
This patch is a follow-up of the following discussions:
<https://sourceware.org/ml/gdb-patches/2014-12/msg00421.html>
<https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01293.html>
input_interrupt is currently emiting non-printable characters, which
is confusing the dg-extract-results.sh script. This is obviously not
a good thing, and, by following Pedro's advices here:
<https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01320.html>
I adapted the function to print "client connection closed" when it
receives a NUL character, or use the "isprint" function to decide how
to print the received char. I tested it by running the testcases that
were printing the non-printable chars before:
gdb.base/gdb-sigterm.exp
gdb.threads/non-ldr-exc-1.exp
gdb.threads/non-ldr-exc-2.exp
gdb.threads/non-ldr-exc-3.exp
gdb.threads/non-ldr-exc-4.exp
gdb.threads/thread-execl.exp
and confirming that they print the right message. I tried a bit to
come up with a testcase for this, but failed, and since I did not want
to spend too much time on it, I'm sending the patch anyway.
Comments are welcome, as usual.
gdb/gdbserver/ChangeLog:
2014-12-29 Sergio Durigan Junior <sergiodj@redhat.com>
* remote-utils.c: Include ctype.h.
(input_interrupt): Explicitly handle the case when the char
received is the NUL byte. Improve the printing of non-ASCII
characters.
-----------------------------------------------------------------------
Summary of changes:
gdb/gdbserver/ChangeLog | 7 +++++++
gdb/gdbserver/remote-utils.c | 15 ++++++++++++---
2 files changed, 19 insertions(+), 3 deletions(-)
hooks/post-receive
--
gdb and binutils