gdb and binutils branch master updated. 1df4399f27f8ee817d8eb4c73bba42bb65844303

[palves at sourceware dot org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  1df4399f27f8ee817d8eb4c73bba42bb65844303 (commit)
      from  a5b6e449e36bcdb162271707fa145f316053ebbc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1df4399f27f8ee817d8eb4c73bba42bb65844303

commit 1df4399f27f8ee817d8eb4c73bba42bb65844303
Author: Pedro Alves <palves@redhat.com>
Date:   Tue Oct 28 13:42:10 2014 +0000

    gdb.base/sigstep.exp: cleanup and make it easier to extend
    
    Hacking on sigstep.exp, I found it harder to understand and extend
    than ideal.
    
     - GDB is currently not restarted between the different
       tests/combinations in the file, and some parts of the tests' setup
       are done on the top level, and shared between tests.  It's not
       trivial to understand which breakpoints each test procedure expects
       to be set or not set.  And it's not trivial to disable parts of the
       test if you want quickly try out just a subset of the tests
       (running the whole file takes a bit).
    
     - Because GDB is currently not restarted between tests, if some test
       triggers a ptrace/kernel bug, the following tests may end up with
       cascading fails.  That makes it hard to add a test to cover a
       kernel bug that isn't fixed yet, with a xfail/kfail.  E.g,. note
       how with kernels with bug gdb/8744 (stepi over sigreturn syscall
       exits program) the test program exits, and nothing restarts it
       afterwards...
    
     - The manual test message prefix management gets a bit in the way.
       Nowadays, we have with_test_prefix which makes it simpler.
    
     - 'i' is used as parameter name in the various procedures, meaning
       'the command the test', which isn't as obvious as it could.
    
    This commit addresses all that.
    
    gdb/testsuite/
    2014-10-28  Pedro Alves  <palves@redhat.com>
    
    	* gdb.base/sigstep.exp: Use build_executable instead of
    	prepare_for_testing.
    	(top level): Move code that starts GDB, runs to main and creates a
    	display to ...
    	(restart): ... this new procedure.
    	(top level): Move backtrace from signal handler test to ...
    	(validate_backtrace): ... this new procedure.
    	(advance, advancei): Rename parameter from 'i' to 'cmd'.  Use
    	with_test_prefix.  Always restart GDB.
    	(skip_to_handler): Rename parameter from 'i' to 'cmd'.  Use
    	with_test_prefix.  Always restart GDB.  No need to delete
    	breakpoints after the test.
    	(test_skip_handler): Remove prefix parameter.
    	(skip_over_handler, breakpoint_to_handler)
    	(breakpoint_to_handler_entry, breakpoint_over_handler): Rename
    	parameter from 'i' to 'cmd'.  Use with_test_prefix.  Always
    	restart GDB.  No need to delete breakpoints after the test.
    	(top level): Use foreach to call the test procedures with
    	different commands.

-----------------------------------------------------------------------

Summary of changes:
 gdb/testsuite/ChangeLog            |   22 ++
 gdb/testsuite/gdb.base/sigstep.exp |  545 ++++++++++++++++++------------------
 2 files changed, 291 insertions(+), 276 deletions(-)


hooks/post-receive
-- 
gdb and binutils