This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

gdb and binutils branch master updated. 0ea5cda8612bd2233f7a2f9d1eba0b62c2e6c015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  0ea5cda8612bd2233f7a2f9d1eba0b62c2e6c015 (commit)
      from  f7088df3b1c0370101edada54e26d24efb53125c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0ea5cda8612bd2233f7a2f9d1eba0b62c2e6c015

commit 0ea5cda8612bd2233f7a2f9d1eba0b62c2e6c015
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date:   Tue Oct 14 14:45:13 2014 -0400

    Only call {set,clear}_semaphore probe function if they are not NULL
    
    This patch is a response to what I commented on:
    
      <https://sourceware.org/ml/gdb-patches/2014-10/msg00046.html>
    
    When reviewing Jose's USDT probe support patches.  Basically, in his
    patch he had to create dummy functions for the set_semaphore and the
    clear_semaphore methods of probe_ops (gdb/probe.h), because those
    functions were called inconditionally from inside gdb/breakpoint.c and
    gdb/tracepoint.c.  However, the semaphore concept may not apply to all
    types of probes, and this is the case here: USDT probes do not have
    semaphores (although SDT probes do).
    
    Anyway, this is a simple (almost obvious) patch to guard the call to
    {set,clear}_semaphore.  It does not introduce any regression on a
    Fedora 20 x86_64.
    
    I will apply it in a few days in case there is no comment.
    
    gdb/ChangeLog:
    2014-10-14  Sergio Durigan Junior  <sergiodj@redhat.com>
    
    	* breakpoint.c (bkpt_probe_insert_location): Call set_semaphore
    	only if it is not NULL.
    	(bkpt_probe_remove_location): Likewise, for clear_semaphore.
    	* probe.h (struct probe_ops) <set_semaphore>: Update comment.
    	(struct probe_ops) <clear_semaphore>: Likewise.
    	* tracepoint.c (start_tracing): Call set_semaphore only if it is
    	not NULL.
    	(stop_tracing): Likewise, for clear_semaphore.

-----------------------------------------------------------------------

Summary of changes:
 gdb/ChangeLog    |   11 +++++++++++
 gdb/breakpoint.c |   14 ++++++++------
 gdb/probe.h      |    4 ++--
 gdb/tracepoint.c |    6 ++++--
 4 files changed, 25 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
gdb and binutils


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]