gdb and binutils branch master updated. 656e8868f333de49bf22e10112392ca404e5eb67

[palves at sourceware dot org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  656e8868f333de49bf22e10112392ca404e5eb67 (commit)
      from  a6c7053929dd26d04293429e8610209f5b1bf900 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=656e8868f333de49bf22e10112392ca404e5eb67

commit 656e8868f333de49bf22e10112392ca404e5eb67
Author: Pedro Alves <palves@redhat.com>
Date:   Thu Aug 21 17:09:24 2014 +0100

    infcmd.c: Remove stale TODO
    
    This TODO has been stale for over 2 years.  In bd5635a1 (1991), we
    already see the comment, when we only had a bare attach_command:
    
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     /*
      * TODO:
      * Should save/restore the tty state since it might be that the
      * program to be debugged was started on this tty and it wants
      * the tty in some state other than what we want.  If it's running
      * on another terminal or without a terminal, then saving and
      * restoring the tty state is a harmless no-op.
      * This only needs to be done if we are attaching to a process.
      */
    
     /*
      * attach_command --
      * takes a program started up outside of gdb and ``attaches'' to it.
      * This stops it cold in its tracks and allows us to start tracing it.
      * For this to work, we must be able to send the process a
      * signal and we must have the same effective uid as the program.
      */
     void
     attach_command (args, from_tty)
          char *args;
          int from_tty;
     {
       target_attach (args, from_tty);
     }
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    
    Later in b5a3d2aa (1992) target_terminal_init, etc. calls are added to
    attach_command, and in 7e97eb28 (1992) we see:
    
    +      /* If we attached to the process, we might or might not be sharing
    +        a terminal.  Avoid printing error msg if we are unable to set our
    +        terminal's process group to his process group ID.  */
    +      if (!attach_flag) {
    +       OOPSY ("ioctl TIOCSPGRP");
    
    Clearly the TODO has been stale for a long while.
    
    I considered preserving the text elsewhere, but then thought the
    comments in inflow.c already have all the necessary info.
    
    gdb/ChangeLog:
    
    	* infcmd.c (attach_command): Remove comment.

-----------------------------------------------------------------------

Summary of changes:
 gdb/ChangeLog |    4 ++++
 gdb/infcmd.c  |   10 ----------
 2 files changed, 4 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
gdb and binutils