This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
src/gdb ChangeLog s390-tdep.c
- From: palves at sourceware dot org
- To: gdb-cvs at sourceware dot org
- Date: Fri, 19 Apr 2013 15:22:47 +0000
- Subject: src/gdb ChangeLog s390-tdep.c
CVSROOT: /cvs/src
Module name: src
Changes by: palves@sourceware.org 2013-04-19 15:22:47
Modified files:
gdb : ChangeLog s390-tdep.c
Log message:
-Wpointer-sign: s390-tdep.c.
-Wpointer-sign reveals a bunch of:
../../src/gdb/s390-tdep.c:1342:7: error: pointer targets in passing argument 4 of âis_rxâ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:1038:1: note: expected âunsigned int *â but argument is of type âint *â
../../src/gdb/s390-tdep.c:1343:9: error: pointer targets in passing argument 5 of âis_rxyâ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:1055:1: note: expected âunsigned int *â but argument is of type âint *â
../../src/gdb/s390-tdep.c:1344:9: error: pointer targets in passing argument 5 of âis_rxyâ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:1055:1: note: expected âunsigned int *â but argument is of type âint *â
...
../../src/gdb/s390-tdep.c:1363:7: error: pointer targets in passing argument 5 of âis_rsâ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:966:1: note: expected âunsigned int *â but argument is of type âint *â
../../src/gdb/s390-tdep.c:1364:9: error: pointer targets in passing argument 6 of âis_rsyâ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:983:1: note: expected âunsigned int *â but argument is of type âint *â
../../src/gdb/s390-tdep.c:1365:9: error: pointer targets in passing argument 6 of âis_rsyâ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:983:1: note: expected âunsigned int *â but argument is of type âint *â
...
I don't know much about s390, but from reading the code I believe the
right fix is to treat d2 as signed.
gdb/
2013-04-19 Pedro Alves <palves@redhat.com>
* s390-tdep.c (is_rs, is_rsy, is_rx, is_rxy): Change type of 'd2'
parameter to int *.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15439&r2=1.15440
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/s390-tdep.c.diff?cvsroot=src&r1=1.210&r2=1.211