This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

src/gdb ChangeLog ser-tcp.c


CVSROOT:	/cvs/src
Module name:	src
Changes by:	palves@sourceware.org	2013-03-26 20:29:47

Modified files:
	gdb            : ChangeLog ser-tcp.c 

Log message:
	ser-tcp.c: Small signed->unsigned cleanup.
	
	The "set tcp connect-timeout" variable is unsigned:
	
	/* Timeout period for connections, in seconds.  */
	
	static unsigned int tcp_retry_limit = 15;
	
	And used like:
	
	/* Check for timeout.  */
	if (*polls > tcp_retry_limit * POLL_INTERVAL)
	{
	errno = ETIMEDOUT;
	return -1;
	}
	
	Which made me stop and look over why is it that 'polls' is signed.
	What I found is there's really no reason.
	
	gdb/
	2013-03-26  Pedro Alves  <palves@redhat.com>
	
	* ser-tcp.c (wait_for_connect): Make 'polls' parameter unsigned.
	(net_open): Make 'polls' local unsigned.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15320&r2=1.15321
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ser-tcp.c.diff?cvsroot=src&r1=1.43&r2=1.44


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]