src/gdb ChangeLog ada-lang.c testsuite/ChangeL ...

[brobecke at sourceware dot org]

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brobecke@sourceware.org	2011-11-29 01:00:52

Modified files:
	gdb            : ChangeLog ada-lang.c 
	gdb/testsuite  : ChangeLog 
Added files:
	gdb/testsuite/gdb.ada: fullname_bp.exp 
	gdb/testsuite/gdb.ada/fullname_bp: dn.adb dn.ads foo.adb pck.adb 
	                                   pck.ads 

Log message:
	wrong value returned by ada-lang.c:compare_names
	
	The ada-lang.c:compare_names function returns the wrong value
	when the first string starts with the same contents as the second
	string, followed by '_' and then some characters that do not make
	a symbol name suffix.  For instance:
	
	string1 = "generics__test_generics__instance__print"
	string2 = "generics__test_generics"
	
	In that case, compare_names (string1, string2) return -1, when
	clearly, string1 is greater than string2.
	
	A consequence of this problem is that GDB may fail to lookup
	"generics.test_generics" from our partial symtabs, because
	partial symbols are ordered by strcmp_iw_ordered:
	
	(gdb) b generics.test_generics
	Function "generics.test_generics" not defined.
	Make breakpoint pending on future shared library load? (y or [n])
	
	gdb/ChangeLog:
	
	* ada-lang.c (compare_names): Fix wrong return value in case
	string1 starts with the same contents as string2, followed
	by an underscore that do not start a symbol name suffix.
	
	gdb/testsuite/ChangeLog:
	
	* gdb.ada/fullname_bp: New testcase.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.13555&r2=1.13556
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ada-lang.c.diff?cvsroot=src&r1=1.316&r2=1.317
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.2948&r2=1.2949
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.ada/fullname_bp.exp.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.ada/fullname_bp/dn.adb.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.ada/fullname_bp/dn.ads.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.ada/fullname_bp/foo.adb.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.ada/fullname_bp/pck.adb.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.ada/fullname_bp/pck.ads.diff?cvsroot=src&r1=NONE&r2=1.1